Re: [PATCH] IOCTL support for dell-wmi-sysman driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3279 bytes --]

Hi KSR",

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Prasanth-KSR/IOCTL-support-for-dell-wmi-sysman-driver/20210209-223343
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 61556703b610a104de324e4f061dc6cf7b218b46
config: x86_64-randconfig-a015-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/00141bcb2495c75a902d3070e149760b1050322e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Prasanth-KSR/IOCTL-support-for-dell-wmi-sysman-driver/20210209-223343
        git checkout 00141bcb2495c75a902d3070e149760b1050322e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/dell-wmi-sysman/sysman.c:310:5: warning: no previous prototype for function 'validate_acpi_type' [-Wmissing-prototypes]
   int validate_acpi_type(union acpi_object *obj, const char *guid_string)
       ^
   drivers/platform/x86/dell-wmi-sysman/sysman.c:310:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int validate_acpi_type(union acpi_object *obj, const char *guid_string)
   ^
   static 
   1 warning generated.
--
>> drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c:218:5: warning: no previous prototype for function 'run_sysman_call' [-Wmissing-prototypes]
   int run_sysman_call(struct dell_wmi_sysman_buffer *buf)
       ^
   drivers/platform/x86/dell-wmi-sysman/biosattr-interface.c:218:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int run_sysman_call(struct dell_wmi_sysman_buffer *buf)
   ^
   static 
   1 warning generated.


vim +/validate_acpi_type +310 drivers/platform/x86/dell-wmi-sysman/sysman.c

   309	
 > 310	int validate_acpi_type(union acpi_object *obj, const char *guid_string)
   311	{
   312		u32 acpi_type;
   313	
   314		if (strcmp(guid_string, DELL_WMI_BIOS_INTEGER_ATTRIBUTE_GUID) == 0)
   315			acpi_type = ACPI_TYPE_INTEGER;
   316		else
   317			acpi_type = ACPI_TYPE_STRING;
   318	
   319		if (obj->package.elements[CURRENT_VAL].type != acpi_type)
   320			return -EIO;
   321	
   322		return 0;
   323	}
   324	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41107 bytes --]