From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Oh <peter.oh@eero.com>, Carl Huang <cjhuang@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] ath11k: fix a locking bug in ath11k_mac_op_start()
Date: Wed, 10 Feb 2021 07:46:27 +0000 (UTC) [thread overview]
Message-ID: <20210210074627.04D54C43463@smtp.codeaurora.org> (raw)
In-Reply-To: <YBk4GoeE+yc0wlJH@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This error path leads to a Smatch warning:
>
> drivers/net/wireless/ath/ath11k/mac.c:4269 ath11k_mac_op_start()
> error: double unlocked '&ar->conf_mutex' (orig line 4251)
>
> We're not holding the lock when we do the "goto err;" so it leads to a
> double unlock. The fix is to hold the lock for a little longer.
>
> Fixes: c83c500b55b6 ("ath11k: enable idle power save mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> [kvalo@codeaurora.org: move also rcu_assign_pointer() call]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
c202e2ebe1dc ath11k: fix a locking bug in ath11k_mac_op_start()
--
https://patchwork.kernel.org/project/linux-wireless/patch/YBk4GoeE+yc0wlJH@mwanda/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Oh <peter.oh@eero.com>, Carl Huang <cjhuang@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] ath11k: fix a locking bug in ath11k_mac_op_start()
Date: Wed, 10 Feb 2021 07:46:27 +0000 [thread overview]
Message-ID: <20210210074627.04D54C43463@smtp.codeaurora.org> (raw)
In-Reply-To: <YBk4GoeE+yc0wlJH@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This error path leads to a Smatch warning:
>
> drivers/net/wireless/ath/ath11k/mac.c:4269 ath11k_mac_op_start()
> error: double unlocked '&ar->conf_mutex' (orig line 4251)
>
> We're not holding the lock when we do the "goto err;" so it leads to a
> double unlock. The fix is to hold the lock for a little longer.
>
> Fixes: c83c500b55b6 ("ath11k: enable idle power save mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> [kvalo@codeaurora.org: move also rcu_assign_pointer() call]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
c202e2ebe1dc ath11k: fix a locking bug in ath11k_mac_op_start()
--
https://patchwork.kernel.org/project/linux-wireless/patch/YBk4GoeE+yc0wlJH@mwanda/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-02-10 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 11:31 [PATCH v2] ath11k: fix a locking bug in ath11k_mac_op_start() Dan Carpenter
2021-02-02 11:31 ` Dan Carpenter
2021-02-02 11:31 ` Dan Carpenter
2021-02-09 7:47 ` Kalle Valo
2021-02-09 7:47 ` Kalle Valo
2021-02-09 7:47 ` Kalle Valo
2021-02-09 8:10 ` Dan Carpenter
2021-02-09 8:10 ` Dan Carpenter
2021-02-09 8:10 ` Dan Carpenter
2021-02-10 7:46 ` Kalle Valo
2021-02-10 7:46 ` Kalle Valo [this message]
2021-02-10 7:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210074627.04D54C43463@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@eero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.