All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/can-utils: enable build using musl libc
@ 2021-02-10  9:13 Diego Hurtado de Mendoza
  2021-02-11 22:21 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Diego Hurtado de Mendoza @ 2021-02-10  9:13 UTC (permalink / raw)
  To: buildroot

From commit 20fb6d3288f3c9aac7975e505d9a25f21f64bdf9 this package was
disabled for musl because can-utils used the error() glibc extension
at that time.

Since then, can-utils fixed compilation on musl by replacing this
error() calls with err().
https://github.com/linux-can/can-utils/pull/163/commits/791b6de78673f005e9748983231f7260f6b69e99

This commit disables the musl check.

Signed-off-by: Diego Hurtado de Mendoza <diego.hdmp@gmail.com>
---
 package/can-utils/Config.in | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/package/can-utils/Config.in b/package/can-utils/Config.in
index da56378866..bdc84b461a 100644
--- a/package/can-utils/Config.in
+++ b/package/can-utils/Config.in
@@ -1,14 +1,9 @@
 config BR2_PACKAGE_CAN_UTILS
 	bool "can-utils"
 	depends on BR2_USE_MMU # fork()
-	depends on !BR2_TOOLCHAIN_USES_MUSL # error()
 	help
 	  SocketCAN is a set of open source CAN drivers and a
 	  networking stack.
 	  This package provides various tools for this stack.
 
 	  https://github.com/linux-can/can-utils
-
-comment "can-utils needs a glibc or uClibc toolchain"
-	depends on BR2_TOOLCHAIN_USES_MUSL
-	depends on BR2_USE_MMU
-- 
2.30.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/can-utils: enable build using musl libc
  2021-02-10  9:13 [Buildroot] [PATCH 1/1] package/can-utils: enable build using musl libc Diego Hurtado de Mendoza
@ 2021-02-11 22:21 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2021-02-11 22:21 UTC (permalink / raw)
  To: buildroot

>>>>> "Diego" == Diego Hurtado de Mendoza <diego.hdmp@gmail.com> writes:

 > From commit 20fb6d3288f3c9aac7975e505d9a25f21f64bdf9 this package was
 > disabled for musl because can-utils used the error() glibc extension
 > at that time.

 > Since then, can-utils fixed compilation on musl by replacing this
 > error() calls with err().
 > https://github.com/linux-can/can-utils/pull/163/commits/791b6de78673f005e9748983231f7260f6b69e99

 > This commit disables the musl check.

 > Signed-off-by: Diego Hurtado de Mendoza <diego.hdmp@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-11 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10  9:13 [Buildroot] [PATCH 1/1] package/can-utils: enable build using musl libc Diego Hurtado de Mendoza
2021-02-11 22:21 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.