From: Kees Cook <keescook@chromium.org>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Andy Lutomirski <luto@kernel.org>,
Balbir Singh <bsingharora@gmail.com>,
Borislav Petkov <bp@alien8.de>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Eugene Syromiatnikov <esyr@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Mike Kravetz <mike.kravetz@oracle.com>,
Nadav Amit <nadav.amit@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>,
Dave Martin <Dave.Martin@arm.com>,
Weijiang Yang <weijiang.yang@intel.com>,
Pengfei Xu <pengfei.xu@intel.com>,
haitao.huang@intel.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v20 07/25] x86/mm: Remove _PAGE_DIRTY from kernel RO pages
Date: Wed, 10 Feb 2021 11:35:01 -0800 [thread overview]
Message-ID: <202102101134.72F7495@keescook> (raw)
In-Reply-To: <20210210175703.12492-8-yu-cheng.yu@intel.com>
On Wed, Feb 10, 2021 at 09:56:45AM -0800, Yu-cheng Yu wrote:
> The x86 family of processors do not directly create read-only and Dirty
> PTEs. These PTEs are created by software. One such case is that kernel
> read-only pages are historically setup as Dirty.
>
> New processors that support Shadow Stack regard read-only and Dirty PTEs as
> shadow stack pages. This results in ambiguity between shadow stack and
> kernel read-only pages. To resolve this, removed Dirty from kernel read-
> only pages.
>
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2021-02-10 19:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:56 [PATCH v20 00/25] Control-flow Enforcement: Shadow Stack Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 01/25] Documentation/x86: Add CET description Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 02/25] x86/cet/shstk: Add Kconfig option for user-mode control-flow protection Yu-cheng Yu
2021-02-10 19:33 ` Kees Cook
2021-02-10 19:40 ` Yu, Yu-cheng
2021-02-10 17:56 ` [PATCH v20 03/25] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET) Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 04/25] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 05/25] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 06/25] x86/cet: Add control-protection fault handler Yu-cheng Yu
2021-02-10 19:34 ` Kees Cook
2021-02-10 19:48 ` Andy Lutomirski
2021-02-10 19:48 ` Andy Lutomirski
2021-02-10 17:56 ` [PATCH v20 07/25] x86/mm: Remove _PAGE_DIRTY from kernel RO pages Yu-cheng Yu
2021-02-10 19:35 ` Kees Cook [this message]
2021-02-10 17:56 ` [PATCH v20 08/25] x86/mm: Introduce _PAGE_COW Yu-cheng Yu
2021-02-10 19:42 ` Kees Cook
2021-02-10 20:28 ` Yu, Yu-cheng
2021-02-15 16:49 ` Yu, Yu-cheng
2021-02-10 17:56 ` [PATCH v20 09/25] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 10/25] x86/mm: Update pte_modify for _PAGE_COW Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 11/25] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW Yu-cheng Yu
2021-02-10 19:43 ` Kees Cook
2021-02-10 17:56 ` [PATCH v20 12/25] mm: Introduce VM_SHSTK for shadow stack memory Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 13/25] x86/mm: Shadow Stack page fault error checking Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 14/25] x86/mm: Update maybe_mkwrite() for shadow stack Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 15/25] mm: Fixup places that call pte_mkwrite() directly Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 16/25] mm: Add guard pages around a shadow stack Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 17/25] mm/mmap: Add shadow stack pages to memory accounting Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 18/25] mm: Update can_follow_write_pte() for shadow stack Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 19/25] mm: Re-introduce vm_flags to do_mmap() Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 20/25] x86/cet/shstk: User-mode shadow stack support Yu-cheng Yu
2021-02-10 17:56 ` [PATCH v20 21/25] x86/cet/shstk: Handle signals for shadow stack Yu-cheng Yu
2021-02-10 19:58 ` Kees Cook
2021-02-10 21:38 ` Yu, Yu-cheng
2021-02-11 2:05 ` Kees Cook
2021-02-10 17:57 ` [PATCH v20 22/25] ELF: Introduce arch_setup_elf_property() Yu-cheng Yu
2021-02-10 17:57 ` [PATCH v20 23/25] x86/cet/shstk: Handle thread shadow stack Yu-cheng Yu
2021-02-10 17:57 ` [PATCH v20 24/25] x86/cet/shstk: Add arch_prctl functions for " Yu-cheng Yu
2021-02-10 17:57 ` [PATCH v20 25/25] mm: Introduce PROT_SHSTK " Yu-cheng Yu
2021-02-10 19:46 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101134.72F7495@keescook \
--to=keescook@chromium.org \
--cc=Dave.Martin@arm.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=bsingharora@gmail.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=esyr@redhat.com \
--cc=fweimer@redhat.com \
--cc=gorcunov@gmail.com \
--cc=haitao.huang@intel.com \
--cc=hch@lst.de \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=oleg@redhat.com \
--cc=pavel@ucw.cz \
--cc=pengfei.xu@intel.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=vedvyas.shanbhogue@intel.com \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.