* [PATCH] iotests/210: Fix reference output
@ 2021-02-09 18:19 Max Reitz
2021-02-09 18:38 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Max Reitz @ 2021-02-09 18:19 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, Vladimir Sementsov-Ogievskiy, qemu-devel, Max Reitz
Commit 69b55e03f has changed an error message, adjust the reference
output to account for it.
Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
("block: refactor bdrv_check_request: add errp")
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
Fun fact: The branch name "fix-210-v1" was already taken for
8ba9c4d9b088d66aebfcb019f61ddc36fba2db88, which was only two months
ago. Ah, well. :)
---
tests/qemu-iotests/210.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/210.out b/tests/qemu-iotests/210.out
index dc1a3c9786..2e9fc596eb 100644
--- a/tests/qemu-iotests/210.out
+++ b/tests/qemu-iotests/210.out
@@ -182,7 +182,7 @@ Job failed: The requested file size is too large
=== Resize image with invalid sizes ===
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775296}}
-{"error": {"class": "GenericError", "desc": "Required too big image size, it must be not greater than 9223372035781033984"}}
+{"error": {"class": "GenericError", "desc": "offset(9223372036854775296) exceeds maximum(9223372035781033984)"}}
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775808}}
{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'size', expected: integer"}}
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 18446744073709551104}}
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] iotests/210: Fix reference output
2021-02-09 18:19 [PATCH] iotests/210: Fix reference output Max Reitz
@ 2021-02-09 18:38 ` Eric Blake
2021-02-09 18:42 ` Vladimir Sementsov-Ogievskiy
2021-02-10 13:59 ` Kevin Wolf
2 siblings, 0 replies; 7+ messages in thread
From: Eric Blake @ 2021-02-09 18:38 UTC (permalink / raw)
To: Max Reitz, qemu-block
Cc: Kevin Wolf, Vladimir Sementsov-Ogievskiy, qemu-devel
On 2/9/21 12:19 PM, Max Reitz wrote:
> Commit 69b55e03f has changed an error message, adjust the reference
> output to account for it.
>
> Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
> ("block: refactor bdrv_check_request: add errp")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
I'm happy to queue this through my tree (since that's where the original
came through) if you don't beat me to it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iotests/210: Fix reference output
2021-02-09 18:19 [PATCH] iotests/210: Fix reference output Max Reitz
2021-02-09 18:38 ` Eric Blake
@ 2021-02-09 18:42 ` Vladimir Sementsov-Ogievskiy
2021-02-10 13:59 ` Kevin Wolf
2 siblings, 0 replies; 7+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-02-09 18:42 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: qemu-devel, Kevin Wolf, Eric Blake
09.02.2021 21:19, Max Reitz wrote:
> Commit 69b55e03f has changed an error message, adjust the reference
> output to account for it.
>
> Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
> ("block: refactor bdrv_check_request: add errp")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> Fun fact: The branch name "fix-210-v1" was already taken for
> 8ba9c4d9b088d66aebfcb019f61ddc36fba2db88, which was only two months
> ago. Ah, well. :)
Me again :( Hmm. I should definitely start running iotests with -luks, not only my favorite -raw, -qcow2, -nbd. Sorry.
> ---
> tests/qemu-iotests/210.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/210.out b/tests/qemu-iotests/210.out
> index dc1a3c9786..2e9fc596eb 100644
> --- a/tests/qemu-iotests/210.out
> +++ b/tests/qemu-iotests/210.out
> @@ -182,7 +182,7 @@ Job failed: The requested file size is too large
> === Resize image with invalid sizes ===
>
> {"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775296}}
> -{"error": {"class": "GenericError", "desc": "Required too big image size, it must be not greater than 9223372035781033984"}}
> +{"error": {"class": "GenericError", "desc": "offset(9223372036854775296) exceeds maximum(9223372035781033984)"}}
> {"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775808}}
> {"error": {"class": "GenericError", "desc": "Invalid parameter type for 'size', expected: integer"}}
> {"execute": "block_resize", "arguments": {"node-name": "node1", "size": 18446744073709551104}}
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iotests/210: Fix reference output
2021-02-09 18:19 [PATCH] iotests/210: Fix reference output Max Reitz
2021-02-09 18:38 ` Eric Blake
2021-02-09 18:42 ` Vladimir Sementsov-Ogievskiy
@ 2021-02-10 13:59 ` Kevin Wolf
2 siblings, 0 replies; 7+ messages in thread
From: Kevin Wolf @ 2021-02-10 13:59 UTC (permalink / raw)
To: Max Reitz; +Cc: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Am 09.02.2021 um 19:19 hat Max Reitz geschrieben:
> Commit 69b55e03f has changed an error message, adjust the reference
> output to account for it.
>
> Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
> ("block: refactor bdrv_check_request: add errp")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> diff --git a/tests/qemu-iotests/210.out b/tests/qemu-iotests/210.out
> index dc1a3c9786..2e9fc596eb 100644
> --- a/tests/qemu-iotests/210.out
> +++ b/tests/qemu-iotests/210.out
> @@ -182,7 +182,7 @@ Job failed: The requested file size is too large
> === Resize image with invalid sizes ===
>
> {"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775296}}
> -{"error": {"class": "GenericError", "desc": "Required too big image size, it must be not greater than 9223372035781033984"}}
> +{"error": {"class": "GenericError", "desc": "offset(9223372036854775296) exceeds maximum(9223372035781033984)"}}
This doesn't exactly feel like an improved error message...
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iotests/210: Fix reference output
2020-12-14 17:51 Max Reitz
2020-12-15 9:00 ` Vladimir Sementsov-Ogievskiy
@ 2020-12-15 11:11 ` Kevin Wolf
1 sibling, 0 replies; 7+ messages in thread
From: Kevin Wolf @ 2020-12-15 11:11 UTC (permalink / raw)
To: Max Reitz; +Cc: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Am 14.12.2020 um 18:51 hat Max Reitz geschrieben:
> Commit 8b1170012b1 has added a global maximum disk length for the block
> layer, so the error message when creating an overly large disk has
> changed.
>
> Fixes: 8b1170012b1de6649c66ac1887f4df7e312abf3b
> ("block: introduce BDRV_MAX_LENGTH")
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iotests/210: Fix reference output
2020-12-14 17:51 Max Reitz
@ 2020-12-15 9:00 ` Vladimir Sementsov-Ogievskiy
2020-12-15 11:11 ` Kevin Wolf
1 sibling, 0 replies; 7+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2020-12-15 9:00 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
14.12.2020 20:51, Max Reitz wrote:
> Commit 8b1170012b1 has added a global maximum disk length for the block
> layer, so the error message when creating an overly large disk has
> changed.
>
> Fixes: 8b1170012b1de6649c66ac1887f4df7e312abf3b
> ("block: introduce BDRV_MAX_LENGTH")
> Signed-off-by: Max Reitz<mreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] iotests/210: Fix reference output
@ 2020-12-14 17:51 Max Reitz
2020-12-15 9:00 ` Vladimir Sementsov-Ogievskiy
2020-12-15 11:11 ` Kevin Wolf
0 siblings, 2 replies; 7+ messages in thread
From: Max Reitz @ 2020-12-14 17:51 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, Vladimir Sementsov-Ogievskiy, qemu-devel, Max Reitz
Commit 8b1170012b1 has added a global maximum disk length for the block
layer, so the error message when creating an overly large disk has
changed.
Fixes: 8b1170012b1de6649c66ac1887f4df7e312abf3b
("block: introduce BDRV_MAX_LENGTH")
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/210.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/210.out b/tests/qemu-iotests/210.out
index a5e88e2a82..dc1a3c9786 100644
--- a/tests/qemu-iotests/210.out
+++ b/tests/qemu-iotests/210.out
@@ -182,7 +182,7 @@ Job failed: The requested file size is too large
=== Resize image with invalid sizes ===
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775296}}
-{"error": {"class": "GenericError", "desc": "The requested file size is too large"}}
+{"error": {"class": "GenericError", "desc": "Required too big image size, it must be not greater than 9223372035781033984"}}
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 9223372036854775808}}
{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'size', expected: integer"}}
{"execute": "block_resize", "arguments": {"node-name": "node1", "size": 18446744073709551104}}
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-10 14:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 18:19 [PATCH] iotests/210: Fix reference output Max Reitz
2021-02-09 18:38 ` Eric Blake
2021-02-09 18:42 ` Vladimir Sementsov-Ogievskiy
2021-02-10 13:59 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2020-12-14 17:51 Max Reitz
2020-12-15 9:00 ` Vladimir Sementsov-Ogievskiy
2020-12-15 11:11 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.