From: Geert Uytterhoeven <geert+renesas@glider.be> To: Russell King <linux@armlinux.org.uk>, Michal Simek <monstr@monstr.eu>, Arnd Bergmann <arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 1/4] ARM: div64: Remove always-true __div64_const32_is_OK() duplicate Date: Wed, 10 Feb 2021 15:11:37 +0100 [thread overview] Message-ID: <20210210141140.1506212-2-geert+renesas@glider.be> (raw) In-Reply-To: <20210210141140.1506212-1-geert+renesas@glider.be> Since commit cafa0010cd51fb71 ("Raise the minimum required gcc version to 4.6"), the kernel can no longer be compiled using gcc-3. Hence __div64_const32_is_OK() is always true. Moreover, __div64_const32_is_OK() is defined in the same way in include/asm-generic/div64.h, so the ARM-specific definition can be removed regardless. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/include/asm/div64.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/arch/arm/include/asm/div64.h b/arch/arm/include/asm/div64.h index 595e538f5bfb5055..4b69cf850451b076 100644 --- a/arch/arm/include/asm/div64.h +++ b/arch/arm/include/asm/div64.h @@ -52,17 +52,6 @@ static inline uint32_t __div64_32(uint64_t *n, uint32_t base) #else -/* - * gcc versions earlier than 4.0 are simply too problematic for the - * __div64_const32() code in asm-generic/div64.h. First there is - * gcc PR 15089 that tend to trig on more complex constructs, spurious - * .global __udivsi3 are inserted even if none of those symbols are - * referenced in the generated code, and those gcc versions are not able - * to do constant propagation on long long values anyway. - */ - -#define __div64_const32_is_OK (__GNUC__ >= 4) - static inline uint64_t __arch_xprod_64(uint64_t m, uint64_t n, bool bias) { unsigned long long res; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be> To: Russell King <linux@armlinux.org.uk>, Michal Simek <monstr@monstr.eu>, Arnd Bergmann <arnd@arndb.de> Cc: linux-arch@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] ARM: div64: Remove always-true __div64_const32_is_OK() duplicate Date: Wed, 10 Feb 2021 15:11:37 +0100 [thread overview] Message-ID: <20210210141140.1506212-2-geert+renesas@glider.be> (raw) In-Reply-To: <20210210141140.1506212-1-geert+renesas@glider.be> Since commit cafa0010cd51fb71 ("Raise the minimum required gcc version to 4.6"), the kernel can no longer be compiled using gcc-3. Hence __div64_const32_is_OK() is always true. Moreover, __div64_const32_is_OK() is defined in the same way in include/asm-generic/div64.h, so the ARM-specific definition can be removed regardless. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/include/asm/div64.h | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/arch/arm/include/asm/div64.h b/arch/arm/include/asm/div64.h index 595e538f5bfb5055..4b69cf850451b076 100644 --- a/arch/arm/include/asm/div64.h +++ b/arch/arm/include/asm/div64.h @@ -52,17 +52,6 @@ static inline uint32_t __div64_32(uint64_t *n, uint32_t base) #else -/* - * gcc versions earlier than 4.0 are simply too problematic for the - * __div64_const32() code in asm-generic/div64.h. First there is - * gcc PR 15089 that tend to trig on more complex constructs, spurious - * .global __udivsi3 are inserted even if none of those symbols are - * referenced in the generated code, and those gcc versions are not able - * to do constant propagation on long long values anyway. - */ - -#define __div64_const32_is_OK (__GNUC__ >= 4) - static inline uint64_t __arch_xprod_64(uint64_t m, uint64_t n, bool bias) { unsigned long long res; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-10 14:14 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-10 14:11 [PATCH 0/4] Remove checks for gcc < 4 Geert Uytterhoeven 2021-02-10 14:11 ` Geert Uytterhoeven 2021-02-10 14:11 ` Geert Uytterhoeven [this message] 2021-02-10 14:11 ` [PATCH 1/4] ARM: div64: Remove always-true __div64_const32_is_OK() duplicate Geert Uytterhoeven 2021-02-10 14:11 ` [PATCH 2/4] ARM: unified: Remove check for gcc < 4 Geert Uytterhoeven 2021-02-10 14:11 ` Geert Uytterhoeven 2021-02-10 14:11 ` [PATCH 3/4] asm-generic: div64: Remove always-true __div64_const32_is_OK() Geert Uytterhoeven 2021-02-10 14:11 ` Geert Uytterhoeven 2021-02-10 15:11 ` Arnd Bergmann 2021-02-10 15:11 ` Arnd Bergmann 2021-02-10 14:11 ` [PATCH 4/4] microblaze: Remove support for gcc < 4 Geert Uytterhoeven 2021-02-10 14:11 ` Geert Uytterhoeven 2021-02-11 17:55 ` Michal Simek 2021-02-11 17:55 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210210141140.1506212-2-geert+renesas@glider.be \ --to=geert+renesas@glider.be \ --cc=arnd@arndb.de \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=monstr@monstr.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.