* [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
@ 2021-02-10 12:24 mwilck
2021-02-10 14:18 ` Martin Wilck
2021-02-10 16:46 ` Benjamin Marzinski
0 siblings, 2 replies; 4+ messages in thread
From: mwilck @ 2021-02-10 12:24 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
gcc-11 throws an error compiling alias.c and dmevents.c:
In file included from ../libmultipath/checkers.h:4,
from ../libmultipath/prio.h:7,
from ../libmultipath/structs.h:8,
from dmevents.c:29:
../multipathd/dmevents.c: In function 'dmevent_loop':
../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200 bytes in a region of size 72 [-Werror=stringop-overflow=]
357 | pthread_cleanup_push(cleanup_lock, &waiter->vecs->lock);
| ^~~~~~~~~~~~~~~~~~~~
../multipathd/dmevents.c:357:17: note: referencing argument 1 of type 'struct __jmp_buf_tag *'
/usr/include/pthread.h:734:12: note: in a call to function '__sigsetjmp'
734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int __savemask) __THROWNL;
| ^~~~~~~~~~~
The reason seems to be a mismatch between the __sigsetjmp() prototype
in <setjmp.h> and <pthread.h>. Until this is fixed in the toolchain,
work around it by including <pthread.h> first.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
tests/alias.c | 1 +
tests/dmevents.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/alias.c b/tests/alias.c
index 0311faa..5e0bfea 100644
--- a/tests/alias.c
+++ b/tests/alias.c
@@ -1,3 +1,4 @@
+#include <pthread.h>
#include <stdint.h>
#include <setjmp.h>
#include <stdio.h>
diff --git a/tests/dmevents.c b/tests/dmevents.c
index b7c5122..29eaa6d 100644
--- a/tests/dmevents.c
+++ b/tests/dmevents.c
@@ -16,6 +16,7 @@
*
*/
+#include <pthread.h>
#include <stdint.h>
#include <stdbool.h>
#include <stdarg.h>
--
2.29.2
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
2021-02-10 12:24 [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11 mwilck
@ 2021-02-10 14:18 ` Martin Wilck
2021-02-10 14:21 ` Martin Wilck
2021-02-10 16:46 ` Benjamin Marzinski
1 sibling, 1 reply; 4+ messages in thread
From: Martin Wilck @ 2021-02-10 14:18 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel
On Wed, 2021-02-10 at 13:24 +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> gcc-11 throws an error compiling alias.c and dmevents.c:
>
> In file included from ../libmultipath/checkers.h:4,
> from ../libmultipath/prio.h:7,
> from ../libmultipath/structs.h:8,
> from dmevents.c:29:
> ../multipathd/dmevents.c: In function 'dmevent_loop':
> ../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200
> bytes in a region of size 72 [-Werror=stringop-overflow=]
> 357 | pthread_cleanup_push(cleanup_lock, &waiter-
> >vecs->lock);
> | ^~~~~~~~~~~~~~~~~~~~
> ../multipathd/dmevents.c:357:17: note: referencing argument 1 of type
> 'struct __jmp_buf_tag *'
> /usr/include/pthread.h:734:12: note: in a call to function
> '__sigsetjmp'
> 734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int
> __savemask) __THROWNL;
> | ^~~~~~~~~~~
>
> The reason seems to be a mismatch between the __sigsetjmp() prototype
> in <setjmp.h> and <pthread.h>. Until this is fixed in the toolchain,
> work around it by including <pthread.h> first.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
I'm told that this issue is related to this glibc bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=26647
and should be fixed in glibc 2.33. Yet adding this patch doesn't hurt
us and can serve as a workaround for environments with gcc 11.
Regards
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
2021-02-10 12:24 [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11 mwilck
2021-02-10 14:18 ` Martin Wilck
@ 2021-02-10 16:46 ` Benjamin Marzinski
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Marzinski @ 2021-02-10 16:46 UTC (permalink / raw)
To: mwilck; +Cc: dm-devel
On Wed, Feb 10, 2021 at 01:24:57PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> gcc-11 throws an error compiling alias.c and dmevents.c:
>
> In file included from ../libmultipath/checkers.h:4,
> from ../libmultipath/prio.h:7,
> from ../libmultipath/structs.h:8,
> from dmevents.c:29:
> ../multipathd/dmevents.c: In function 'dmevent_loop':
> ../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200 bytes in a region of size 72 [-Werror=stringop-overflow=]
> 357 | pthread_cleanup_push(cleanup_lock, &waiter->vecs->lock);
> | ^~~~~~~~~~~~~~~~~~~~
> ../multipathd/dmevents.c:357:17: note: referencing argument 1 of type 'struct __jmp_buf_tag *'
> /usr/include/pthread.h:734:12: note: in a call to function '__sigsetjmp'
> 734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int __savemask) __THROWNL;
> | ^~~~~~~~~~~
>
> The reason seems to be a mismatch between the __sigsetjmp() prototype
> in <setjmp.h> and <pthread.h>. Until this is fixed in the toolchain,
> work around it by including <pthread.h> first.
>
Reviewed-by: Benjamin Marzinski <bmazins@redhat.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> tests/alias.c | 1 +
> tests/dmevents.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/tests/alias.c b/tests/alias.c
> index 0311faa..5e0bfea 100644
> --- a/tests/alias.c
> +++ b/tests/alias.c
> @@ -1,3 +1,4 @@
> +#include <pthread.h>
> #include <stdint.h>
> #include <setjmp.h>
> #include <stdio.h>
> diff --git a/tests/dmevents.c b/tests/dmevents.c
> index b7c5122..29eaa6d 100644
> --- a/tests/dmevents.c
> +++ b/tests/dmevents.c
> @@ -16,6 +16,7 @@
> *
> */
>
> +#include <pthread.h>
> #include <stdint.h>
> #include <stdbool.h>
> #include <stdarg.h>
> --
> 2.29.2
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-10 16:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 12:24 [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11 mwilck
2021-02-10 14:18 ` Martin Wilck
2021-02-10 14:21 ` Martin Wilck
2021-02-10 16:46 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.