All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: stmmac: dwmac-intel-plat: remove unnecessary initialization
@ 2021-02-10 17:59 Nobuhiro Iwamatsu
  2021-02-11 22:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2021-02-10 17:59 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski, Rusaimi Amira Ruslan,
	Vineetha G . Jaya Kumaran
  Cc: netdev, Nobuhiro Iwamatsu

plat_dat is initialized by stmmac_probe_config_dt().
So, initialization is not required by priv->plat.
This removes unnecessary initialization and variables.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
index ba0e4d2b256a..6c19fcc76c6f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c
@@ -74,8 +74,6 @@ MODULE_DEVICE_TABLE(of, intel_eth_plat_match);
 
 static int intel_eth_plat_probe(struct platform_device *pdev)
 {
-	struct net_device *ndev = platform_get_drvdata(pdev);
-	struct stmmac_priv *priv = netdev_priv(ndev);
 	struct plat_stmmacenet_data *plat_dat;
 	struct stmmac_resources stmmac_res;
 	const struct of_device_id *match;
@@ -83,7 +81,6 @@ static int intel_eth_plat_probe(struct platform_device *pdev)
 	unsigned long rate;
 	int ret;
 
-	plat_dat = priv->plat;
 	ret = stmmac_get_platform_resources(pdev, &stmmac_res);
 	if (ret)
 		return ret;
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: stmmac: dwmac-intel-plat: remove unnecessary initialization
  2021-02-10 17:59 [PATCH] net: stmmac: dwmac-intel-plat: remove unnecessary initialization Nobuhiro Iwamatsu
@ 2021-02-11 22:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-11 22:30 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: davem, kuba, rusaimi.amira.rusaimi, vineetha.g.jaya.kumaran, netdev

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 11 Feb 2021 02:59:35 +0900 you wrote:
> plat_dat is initialized by stmmac_probe_config_dt().
> So, initialization is not required by priv->plat.
> This removes unnecessary initialization and variables.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 3 ---
>  1 file changed, 3 deletions(-)

Here is the summary with links:
  - net: stmmac: dwmac-intel-plat: remove unnecessary initialization
    https://git.kernel.org/netdev/net-next/c/0d645232ddbf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-11 22:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 17:59 [PATCH] net: stmmac: dwmac-intel-plat: remove unnecessary initialization Nobuhiro Iwamatsu
2021-02-11 22:30 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.