* [djwong-xfs:xfs-5.12-merge 25/36] fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
@ 2021-02-10 20:09 kernel test robot
2021-02-10 20:09 ` kernel test robot
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-02-10 20:09 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
config: x86_64-randconfig-c002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"coccinelle warnings: (new ones prefixed by >>)"
>> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37064 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xfs: fix boolreturn.cocci warnings
2021-02-10 20:09 [djwong-xfs:xfs-5.12-merge 25/36] fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool kernel test robot
@ 2021-02-10 20:09 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-10 20:09 UTC (permalink / raw)
To: Brian Foster
Cc: kbuild-all, Darrick J. Wong, Darrick J. Wong, Allison Henderson,
Christoph Hellwig, linux-xfs, linux-kernel
From: kernel test robot <lkp@intel.com>
fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
CC: Brian Foster <bfoster@redhat.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1059,7 +1059,7 @@ xfs_log_need_covered(
bool needed = false;
if (!xlog_cil_empty(log))
- return 0;
+ return false;
spin_lock(&log->l_icloglock);
switch (log->l_covered_state) {
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xfs: fix boolreturn.cocci warnings
@ 2021-02-10 20:09 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-10 20:09 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
From: kernel test robot <lkp@intel.com>
fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
CC: Brian Foster <bfoster@redhat.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1059,7 +1059,7 @@ xfs_log_need_covered(
bool needed = false;
if (!xlog_cil_empty(log))
- return 0;
+ return false;
spin_lock(&log->l_icloglock);
switch (log->l_covered_state) {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix boolreturn.cocci warnings
2021-02-10 20:09 ` kernel test robot
@ 2021-02-10 21:02 ` Brian Foster
-1 siblings, 0 replies; 6+ messages in thread
From: Brian Foster @ 2021-02-10 21:02 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Darrick J. Wong, Darrick J. Wong, Allison Henderson,
Christoph Hellwig, linux-xfs, linux-kernel
On Thu, Feb 11, 2021 at 04:09:16AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
> CC: Brian Foster <bfoster@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
> head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1059,7 +1059,7 @@ xfs_log_need_covered(
> bool needed = false;
>
> if (!xlog_cil_empty(log))
> - return 0;
> + return false;
>
> spin_lock(&log->l_icloglock);
> switch (log->l_covered_state) {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix boolreturn.cocci warnings
@ 2021-02-10 21:02 ` Brian Foster
0 siblings, 0 replies; 6+ messages in thread
From: Brian Foster @ 2021-02-10 21:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]
On Thu, Feb 11, 2021 at 04:09:16AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
> CC: Brian Foster <bfoster@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
> head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1059,7 +1059,7 @@ xfs_log_need_covered(
> bool needed = false;
>
> if (!xlog_cil_empty(log))
> - return 0;
> + return false;
>
> spin_lock(&log->l_icloglock);
> switch (log->l_covered_state) {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfs: fix boolreturn.cocci warnings
2021-02-10 20:09 ` kernel test robot
(?)
(?)
@ 2021-02-10 22:25 ` Chaitanya Kulkarni
-1 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-10 22:25 UTC (permalink / raw)
To: kernel test robot, Brian Foster
Cc: kbuild-all, Darrick J. Wong, Darrick J. Wong, Allison Henderson,
Christoph Hellwig, linux-xfs, linux-kernel
On 2/10/21 12:11 PM, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
> CC: Brian Foster <bfoster@redhat.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
> head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-10 22:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 20:09 [djwong-xfs:xfs-5.12-merge 25/36] fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool kernel test robot
2021-02-10 20:09 ` [PATCH] xfs: fix boolreturn.cocci warnings kernel test robot
2021-02-10 20:09 ` kernel test robot
2021-02-10 21:02 ` Brian Foster
2021-02-10 21:02 ` Brian Foster
2021-02-10 22:25 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.