From: kernel test robot <lkp@intel.com> To: Ben Gardon <bgardon@google.com> Cc: kbuild-all@lists.01.org, Linux Memory Management List <linux-mm@kvack.org>, Paolo Bonzini <pbonzini@redhat.com> Subject: [linux-next:master 7895/10581] arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' Date: Thu, 11 Feb 2021 23:09:56 +0800 [thread overview] Message-ID: <202102112351.Wahnhdlq-lkp@intel.com> (raw) [-- Attachment #1: Type: text/plain, Size: 14862 bytes --] tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 671176b0016c80b3943cb5387312c886aba3308d commit: 26128cb6c7e6731fe644c687af97733adfdb5ee9 [7895/10581] locking/rwlocks: Add contention detection for rwlocks config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=26128cb6c7e6731fe644c687af97733adfdb5ee9 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 26128cb6c7e6731fe644c687af97733adfdb5ee9 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ -- In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/mips/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1206: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/mips/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1206: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/queued_spin_unlock +17 arch/mips/include/asm/spinlock.h 346e91ee090b07 Will Deacon 2019-02-22 16 346e91ee090b07 Will Deacon 2019-02-22 @17 #define queued_spin_unlock queued_spin_unlock 346e91ee090b07 Will Deacon 2019-02-22 18 /** 346e91ee090b07 Will Deacon 2019-02-22 19 * queued_spin_unlock - release a queued spinlock 346e91ee090b07 Will Deacon 2019-02-22 20 * @lock : Pointer to queued spinlock structure 346e91ee090b07 Will Deacon 2019-02-22 21 */ 346e91ee090b07 Will Deacon 2019-02-22 22 static inline void queued_spin_unlock(struct qspinlock *lock) 346e91ee090b07 Will Deacon 2019-02-22 23 { 346e91ee090b07 Will Deacon 2019-02-22 24 /* This could be optimised with ARCH_HAS_MMIOWB */ 346e91ee090b07 Will Deacon 2019-02-22 25 mmiowb(); 346e91ee090b07 Will Deacon 2019-02-22 26 smp_store_release(&lock->locked, 0); 346e91ee090b07 Will Deacon 2019-02-22 27 } 346e91ee090b07 Will Deacon 2019-02-22 28 :::::: The code at line 17 was first introduced by commit :::::: 346e91ee090b07da8d15e36bc3169ddea6968713 mips/mmiowb: Add unconditional mmiowb() to arch_spin_unlock() :::::: TO: Will Deacon <will.deacon@arm.com> :::::: CC: Will Deacon <will.deacon@arm.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 70079 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: [linux-next:master 7895/10581] arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' Date: Thu, 11 Feb 2021 23:09:56 +0800 [thread overview] Message-ID: <202102112351.Wahnhdlq-lkp@intel.com> (raw) [-- Attachment #1: Type: text/plain, Size: 15105 bytes --] tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 671176b0016c80b3943cb5387312c886aba3308d commit: 26128cb6c7e6731fe644c687af97733adfdb5ee9 [7895/10581] locking/rwlocks: Add contention detection for rwlocks config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=26128cb6c7e6731fe644c687af97733adfdb5ee9 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 26128cb6c7e6731fe644c687af97733adfdb5ee9 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ -- In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/mips/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1206: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: >> arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' 17 | #define queued_spin_unlock queued_spin_unlock | ^~~~~~~~~~~~~~~~~~ arch/mips/include/asm/spinlock.h:22:20: note: in expansion of macro 'queued_spin_unlock' 22 | static inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/qrwlock.h:17, from ./arch/mips/include/generated/asm/qrwlock.h:1, from arch/mips/include/asm/spinlock.h:13, from include/linux/spinlock.h:90, from include/linux/ipc.h:5, from include/uapi/linux/sem.h:5, from include/linux/sem.h:5, from include/linux/compat.h:14, from arch/mips/kernel/asm-offsets.c:12: include/asm-generic/qspinlock.h:94:29: note: previous definition of 'queued_spin_unlock' was here 94 | static __always_inline void queued_spin_unlock(struct qspinlock *lock) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes] 26 | void output_ptreg_defines(void) | ^~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes] 78 | void output_task_defines(void) | ^~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes] 93 | void output_thread_info_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes] 110 | void output_thread_defines(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes] 138 | void output_thread_fpu_defines(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes] 181 | void output_mm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes] 220 | void output_sc_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes] 255 | void output_signal_defined(void) | ^~~~~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:322:6: warning: no previous prototype for 'output_pbe_defines' [-Wmissing-prototypes] 322 | void output_pbe_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:334:6: warning: no previous prototype for 'output_pm_defines' [-Wmissing-prototypes] 334 | void output_pm_defines(void) | ^~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines' [-Wmissing-prototypes] 348 | void output_kvm_defines(void) | ^~~~~~~~~~~~~~~~~~ arch/mips/kernel/asm-offsets.c:392:6: warning: no previous prototype for 'output_cps_defines' [-Wmissing-prototypes] 392 | void output_cps_defines(void) | ^~~~~~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/mips/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1206: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/queued_spin_unlock +17 arch/mips/include/asm/spinlock.h 346e91ee090b07 Will Deacon 2019-02-22 16 346e91ee090b07 Will Deacon 2019-02-22 @17 #define queued_spin_unlock queued_spin_unlock 346e91ee090b07 Will Deacon 2019-02-22 18 /** 346e91ee090b07 Will Deacon 2019-02-22 19 * queued_spin_unlock - release a queued spinlock 346e91ee090b07 Will Deacon 2019-02-22 20 * @lock : Pointer to queued spinlock structure 346e91ee090b07 Will Deacon 2019-02-22 21 */ 346e91ee090b07 Will Deacon 2019-02-22 22 static inline void queued_spin_unlock(struct qspinlock *lock) 346e91ee090b07 Will Deacon 2019-02-22 23 { 346e91ee090b07 Will Deacon 2019-02-22 24 /* This could be optimised with ARCH_HAS_MMIOWB */ 346e91ee090b07 Will Deacon 2019-02-22 25 mmiowb(); 346e91ee090b07 Will Deacon 2019-02-22 26 smp_store_release(&lock->locked, 0); 346e91ee090b07 Will Deacon 2019-02-22 27 } 346e91ee090b07 Will Deacon 2019-02-22 28 :::::: The code at line 17 was first introduced by commit :::::: 346e91ee090b07da8d15e36bc3169ddea6968713 mips/mmiowb: Add unconditional mmiowb() to arch_spin_unlock() :::::: TO: Will Deacon <will.deacon@arm.com> :::::: CC: Will Deacon <will.deacon@arm.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 70079 bytes --]
next reply other threads:[~2021-02-11 15:11 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-11 15:09 kernel test robot [this message] 2021-02-11 15:09 ` [linux-next:master 7895/10581] arch/mips/include/asm/spinlock.h:17:28: error: redefinition of 'queued_spin_unlock' kernel test robot 2021-02-11 15:44 ` Paolo Bonzini 2021-02-11 15:44 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202102112351.Wahnhdlq-lkp@intel.com \ --to=lkp@intel.com \ --cc=bgardon@google.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-mm@kvack.org \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.