All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
@ 2021-02-11 23:04 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-11 23:04 UTC (permalink / raw)
  To: Linus Walleij; +Cc: kbuild-all, linux-kernel, Pavel Machek, Sakari Ailus

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

Hi Linus,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   291009f656e8eaebbdfd3a8d99f6b190a9ce9deb
commit: e1c6edcbea13de025c3406645b4cce4ac3baf973 leds: rt8515: Add Richtek RT8515 LED driver
date:   12 days ago
config: i386-randconfig-a005-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e1c6edcbea13de025c3406645b4cce4ac3baf973
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout e1c6edcbea13de025c3406645b4cce4ac3baf973
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
>> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
   ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
   drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'


vim +216 drivers/leds/flash/leds-rt8515.c

   213	
   214	static void rt8515_v4l2_flash_release(struct rt8515 *rt)
   215	{
 > 216		v4l2_flash_release(rt->v4l2_flash);
   217	}
   218	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34040 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
@ 2021-02-11 23:04 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-02-11 23:04 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Hi Linus,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   291009f656e8eaebbdfd3a8d99f6b190a9ce9deb
commit: e1c6edcbea13de025c3406645b4cce4ac3baf973 leds: rt8515: Add Richtek RT8515 LED driver
date:   12 days ago
config: i386-randconfig-a005-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e1c6edcbea13de025c3406645b4cce4ac3baf973
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout e1c6edcbea13de025c3406645b4cce4ac3baf973
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
>> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
   ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
   drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'


vim +216 drivers/leds/flash/leds-rt8515.c

   213	
   214	static void rt8515_v4l2_flash_release(struct rt8515 *rt)
   215	{
 > 216		v4l2_flash_release(rt->v4l2_flash);
   217	}
   218	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34040 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
  2021-02-11 23:04 ` kernel test robot
@ 2021-02-12 12:38   ` Linus Walleij
  -1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-02-12 12:38 UTC (permalink / raw)
  To: kernel test robot, Arnd Bergmann
  Cc: kbuild-all, linux-kernel, Pavel Machek, Sakari Ailus

I need Arnds help with this...

On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@intel.com> wrote:

>    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
>    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
>    drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'

So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
(it is tristate so can also be a module)
but it depends on symbols from a module:
CONFIG_V4L2_FLASH_LED_CLASS=m.

In the code I try to only support the V4L2 interface when using V4L2:
#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
(... V4L2 code...)

Is there a way to define in Kconfig that if and only if you enable
this other module it has to follow the y or m that we use for this
driver?

Or do I simply have to bite the bullet, make it bool and
depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
@ 2021-02-12 12:38   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-02-12 12:38 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

I need Arnds help with this...

On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@intel.com> wrote:

>    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
>    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
>    drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'

So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
(it is tristate so can also be a module)
but it depends on symbols from a module:
CONFIG_V4L2_FLASH_LED_CLASS=m.

In the code I try to only support the V4L2 interface when using V4L2:
#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
(... V4L2 code...)

Is there a way to define in Kconfig that if and only if you enable
this other module it has to follow the y or m that we use for this
driver?

Or do I simply have to bite the bullet, make it bool and
depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
  2021-02-12 12:38   ` Linus Walleij
@ 2021-02-12 13:32     ` Pavel Machek
  -1 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2021-02-12 13:32 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kernel test robot, Arnd Bergmann, kbuild-all, linux-kernel, Sakari Ailus

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Fri 2021-02-12 13:38:58, Linus Walleij wrote:
> I need Arnds help with this...
> 
> On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> > >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
> >    drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'
> 
> So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
> (it is tristate so can also be a module)
> but it depends on symbols from a module:
> CONFIG_V4L2_FLASH_LED_CLASS=m.
> 
> In the code I try to only support the V4L2 interface when using V4L2:
> #if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
> (... V4L2 code...)
> 
> Is there a way to define in Kconfig that if and only if you enable
> this other module it has to follow the y or m that we use for this
> driver?
> 
> Or do I simply have to bite the bullet, make it bool and
> depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
> ?

Arnd already submitted patch for this one... depends is right, no need
to make it bool, I believe.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
@ 2021-02-12 13:32     ` Pavel Machek
  0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2021-02-12 13:32 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Fri 2021-02-12 13:38:58, Linus Walleij wrote:
> I need Arnds help with this...
> 
> On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> > >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
> >    drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'
> 
> So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
> (it is tristate so can also be a module)
> but it depends on symbols from a module:
> CONFIG_V4L2_FLASH_LED_CLASS=m.
> 
> In the code I try to only support the V4L2 interface when using V4L2:
> #if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
> (... V4L2 code...)
> 
> Is there a way to define in Kconfig that if and only if you enable
> this other module it has to follow the y or m that we use for this
> driver?
> 
> Or do I simply have to bite the bullet, make it bool and
> depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
> ?

Arnd already submitted patch for this one... depends is right, no need
to make it bool, I believe.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-12 13:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 23:04 drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release' kernel test robot
2021-02-11 23:04 ` kernel test robot
2021-02-12 12:38 ` Linus Walleij
2021-02-12 12:38   ` Linus Walleij
2021-02-12 13:32   ` Pavel Machek
2021-02-12 13:32     ` Pavel Machek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.