All of lore.kernel.org
 help / color / mirror / Atom feed
* [hwmon:hwmon-next 28/31] drivers/hwmon/npcm750-pwm-fan.c:494:51: error: 'flags' undeclared; did you mean
@ 2021-02-12 14:51 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-02-12 14:51 UTC (permalink / raw)
  To: Tian Tao; +Cc: kbuild-all, linux-hwmon, Guenter Roeck

[-- Attachment #1: Type: text/plain, Size: 3964 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head:   de3a46504a58426f1c91117be601ae270180bc93
commit: 3ee265f75ce831f66bce6c7facdb0499264cc5bb [28/31] hwmon: (npcm750-pwm-fan) replace spin_lock_irqsave by spin_lock in hard IRQ
config: nios2-randconfig-s031-20210209 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=3ee265f75ce831f66bce6c7facdb0499264cc5bb
        git remote add hwmon https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags hwmon hwmon-next
        git checkout 3ee265f75ce831f66bce6c7facdb0499264cc5bb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/npcm750-pwm-fan.c: In function 'npcm7xx_fan_isr':
>> drivers/hwmon/npcm750-pwm-fan.c:494:51: error: 'flags' undeclared (first use in this function); did you mean 'flag'?
     494 |   spin_unlock_irqrestore(&data->fan_lock[module], flags);
         |                                                   ^~~~~
         |                                                   flag
   drivers/hwmon/npcm750-pwm-fan.c:494:51: note: each undeclared identifier is reported only once for each function it appears in

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
   Depends on TTY && HAS_IOMEM
   Selected by
   - EARLY_PRINTK


vim +494 drivers/hwmon/npcm750-pwm-fan.c

f1fd4a4db77703 Tomer Maimon 2018-07-04  480  
f1fd4a4db77703 Tomer Maimon 2018-07-04  481  static irqreturn_t npcm7xx_fan_isr(int irq, void *dev_id)
f1fd4a4db77703 Tomer Maimon 2018-07-04  482  {
f1fd4a4db77703 Tomer Maimon 2018-07-04  483  	struct npcm7xx_pwm_fan_data *data = dev_id;
f1fd4a4db77703 Tomer Maimon 2018-07-04  484  	int module;
f1fd4a4db77703 Tomer Maimon 2018-07-04  485  	u8 flag;
f1fd4a4db77703 Tomer Maimon 2018-07-04  486  
f1fd4a4db77703 Tomer Maimon 2018-07-04  487  	module = irq - data->fan_irq[0];
3ee265f75ce831 Tian Tao     2021-02-07  488  	spin_lock(&data->fan_lock[module]);
f1fd4a4db77703 Tomer Maimon 2018-07-04  489  
f1fd4a4db77703 Tomer Maimon 2018-07-04  490  	flag = ioread8(NPCM7XX_FAN_REG_TICTRL(data->fan_base, module));
f1fd4a4db77703 Tomer Maimon 2018-07-04  491  	if (flag > 0) {
f1fd4a4db77703 Tomer Maimon 2018-07-04  492  		npcm7xx_check_cmp(data, module, NPCM7XX_FAN_CMPA, flag);
f1fd4a4db77703 Tomer Maimon 2018-07-04  493  		npcm7xx_check_cmp(data, module, NPCM7XX_FAN_CMPB, flag);
f1fd4a4db77703 Tomer Maimon 2018-07-04 @494  		spin_unlock_irqrestore(&data->fan_lock[module], flags);
f1fd4a4db77703 Tomer Maimon 2018-07-04  495  		return IRQ_HANDLED;
f1fd4a4db77703 Tomer Maimon 2018-07-04  496  	}
f1fd4a4db77703 Tomer Maimon 2018-07-04  497  
3ee265f75ce831 Tian Tao     2021-02-07  498  	spin_unlock(&data->fan_lock[module]);
f1fd4a4db77703 Tomer Maimon 2018-07-04  499  
f1fd4a4db77703 Tomer Maimon 2018-07-04  500  	return IRQ_NONE;
f1fd4a4db77703 Tomer Maimon 2018-07-04  501  }
f1fd4a4db77703 Tomer Maimon 2018-07-04  502  

:::::: The code at line 494 was first introduced by commit
:::::: f1fd4a4db777030a2542701fb0d3a261d4472d6d hwmon: Add NPCM7xx PWM and Fan driver

:::::: TO: Tomer Maimon <tmaimon77@gmail.com>
:::::: CC: Guenter Roeck <linux@roeck-us.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24363 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [hwmon:hwmon-next 28/31] drivers/hwmon/npcm750-pwm-fan.c:494:51: error: 'flags' undeclared; did you mean
@ 2021-02-12 14:51 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-02-12 14:51 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4037 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
head:   de3a46504a58426f1c91117be601ae270180bc93
commit: 3ee265f75ce831f66bce6c7facdb0499264cc5bb [28/31] hwmon: (npcm750-pwm-fan) replace spin_lock_irqsave by spin_lock in hard IRQ
config: nios2-randconfig-s031-20210209 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=3ee265f75ce831f66bce6c7facdb0499264cc5bb
        git remote add hwmon https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags hwmon hwmon-next
        git checkout 3ee265f75ce831f66bce6c7facdb0499264cc5bb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/npcm750-pwm-fan.c: In function 'npcm7xx_fan_isr':
>> drivers/hwmon/npcm750-pwm-fan.c:494:51: error: 'flags' undeclared (first use in this function); did you mean 'flag'?
     494 |   spin_unlock_irqrestore(&data->fan_lock[module], flags);
         |                                                   ^~~~~
         |                                                   flag
   drivers/hwmon/npcm750-pwm-fan.c:494:51: note: each undeclared identifier is reported only once for each function it appears in

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
   Depends on TTY && HAS_IOMEM
   Selected by
   - EARLY_PRINTK


vim +494 drivers/hwmon/npcm750-pwm-fan.c

f1fd4a4db77703 Tomer Maimon 2018-07-04  480  
f1fd4a4db77703 Tomer Maimon 2018-07-04  481  static irqreturn_t npcm7xx_fan_isr(int irq, void *dev_id)
f1fd4a4db77703 Tomer Maimon 2018-07-04  482  {
f1fd4a4db77703 Tomer Maimon 2018-07-04  483  	struct npcm7xx_pwm_fan_data *data = dev_id;
f1fd4a4db77703 Tomer Maimon 2018-07-04  484  	int module;
f1fd4a4db77703 Tomer Maimon 2018-07-04  485  	u8 flag;
f1fd4a4db77703 Tomer Maimon 2018-07-04  486  
f1fd4a4db77703 Tomer Maimon 2018-07-04  487  	module = irq - data->fan_irq[0];
3ee265f75ce831 Tian Tao     2021-02-07  488  	spin_lock(&data->fan_lock[module]);
f1fd4a4db77703 Tomer Maimon 2018-07-04  489  
f1fd4a4db77703 Tomer Maimon 2018-07-04  490  	flag = ioread8(NPCM7XX_FAN_REG_TICTRL(data->fan_base, module));
f1fd4a4db77703 Tomer Maimon 2018-07-04  491  	if (flag > 0) {
f1fd4a4db77703 Tomer Maimon 2018-07-04  492  		npcm7xx_check_cmp(data, module, NPCM7XX_FAN_CMPA, flag);
f1fd4a4db77703 Tomer Maimon 2018-07-04  493  		npcm7xx_check_cmp(data, module, NPCM7XX_FAN_CMPB, flag);
f1fd4a4db77703 Tomer Maimon 2018-07-04 @494  		spin_unlock_irqrestore(&data->fan_lock[module], flags);
f1fd4a4db77703 Tomer Maimon 2018-07-04  495  		return IRQ_HANDLED;
f1fd4a4db77703 Tomer Maimon 2018-07-04  496  	}
f1fd4a4db77703 Tomer Maimon 2018-07-04  497  
3ee265f75ce831 Tian Tao     2021-02-07  498  	spin_unlock(&data->fan_lock[module]);
f1fd4a4db77703 Tomer Maimon 2018-07-04  499  
f1fd4a4db77703 Tomer Maimon 2018-07-04  500  	return IRQ_NONE;
f1fd4a4db77703 Tomer Maimon 2018-07-04  501  }
f1fd4a4db77703 Tomer Maimon 2018-07-04  502  

:::::: The code at line 494 was first introduced by commit
:::::: f1fd4a4db777030a2542701fb0d3a261d4472d6d hwmon: Add NPCM7xx PWM and Fan driver

:::::: TO: Tomer Maimon <tmaimon77@gmail.com>
:::::: CC: Guenter Roeck <linux@roeck-us.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24363 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-12 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 14:51 [hwmon:hwmon-next 28/31] drivers/hwmon/npcm750-pwm-fan.c:494:51: error: 'flags' undeclared; did you mean kernel test robot
2021-02-12 14:51 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.