From: kernel test robot <lkp@intel.com>
To: Don Bollinger <don@thebollingers.org>,
arndb@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, brandon_chuang@edge-core.com,
wally_wang@accton.com, aken_liu@edge-core.com,
gulv@microsoft.com, jolevequ@microsoft.com,
xinxliu@microsoft.com, Don Bollinger <don@thebollingers.org>
Subject: Re: [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS
Date: Mon, 15 Feb 2021 10:56:43 +0800 [thread overview]
Message-ID: <202102151045.M1uYWT2U-lkp@intel.com> (raw)
In-Reply-To: <20210215002532.2850-1-don@thebollingers.org>
[-- Attachment #1: Type: text/plain, Size: 2745 bytes --]
Hi Don,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c]
url: https://github.com/0day-ci/linux/commits/Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
base: a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c
config: sparc64-randconfig-p002-20210215 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9089aa757bfb70c473ca54face762582908bdd28
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
git checkout 9089aa757bfb70c473ca54face762582908bdd28
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/eeprom/optoe.c:615:16: warning: no previous prototype for 'optoe_make_regmap' [-Wmissing-prototypes]
615 | struct regmap *optoe_make_regmap(struct i2c_client *client)
| ^~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
Depends on COMPAT && BINFMT_ELF
Selected by
- COMPAT && SPARC64
vim +/optoe_make_regmap +615 drivers/misc/eeprom/optoe.c
605
606
607 /*
608 * optoe_make_regmap creates the regmap for the client.
609 * IMPORTANT: Don't call the regmap read/write calls directly
610 * for these devices. These devices are paged, and you have to
611 * set the page register before accessing the data in that page.
612 * Use the nvmem interfaces, those read/write calls use this
613 * driver to manage pages correctly.
614 */
> 615 struct regmap *optoe_make_regmap(struct i2c_client *client)
616 {
617 struct regmap_config regmap_config = { };
618 struct regmap *regmap;
619
620 /* setup a minimal regmap - 8 bits, 8 bit addresses */
621 regmap_config.val_bits = 8;
622 regmap_config.reg_bits = 8;
623
624 /* I'll handle the locking */
625 regmap_config.disable_locking = true;
626 regmap = devm_regmap_init_i2c(client, ®map_config);
627 return regmap;
628 }
629
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30773 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS
Date: Mon, 15 Feb 2021 10:56:43 +0800 [thread overview]
Message-ID: <202102151045.M1uYWT2U-lkp@intel.com> (raw)
In-Reply-To: <20210215002532.2850-1-don@thebollingers.org>
[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]
Hi Don,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c]
url: https://github.com/0day-ci/linux/commits/Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
base: a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c
config: sparc64-randconfig-p002-20210215 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9089aa757bfb70c473ca54face762582908bdd28
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Don-Bollinger/eeprom-optoe-driver-to-read-write-SFP-QSFP-CMIS-EEPROMS/20210215-083817
git checkout 9089aa757bfb70c473ca54face762582908bdd28
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/eeprom/optoe.c:615:16: warning: no previous prototype for 'optoe_make_regmap' [-Wmissing-prototypes]
615 | struct regmap *optoe_make_regmap(struct i2c_client *client)
| ^~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
Depends on COMPAT && BINFMT_ELF
Selected by
- COMPAT && SPARC64
vim +/optoe_make_regmap +615 drivers/misc/eeprom/optoe.c
605
606
607 /*
608 * optoe_make_regmap creates the regmap for the client.
609 * IMPORTANT: Don't call the regmap read/write calls directly
610 * for these devices. These devices are paged, and you have to
611 * set the page register before accessing the data in that page.
612 * Use the nvmem interfaces, those read/write calls use this
613 * driver to manage pages correctly.
614 */
> 615 struct regmap *optoe_make_regmap(struct i2c_client *client)
616 {
617 struct regmap_config regmap_config = { };
618 struct regmap *regmap;
619
620 /* setup a minimal regmap - 8 bits, 8 bit addresses */
621 regmap_config.val_bits = 8;
622 regmap_config.reg_bits = 8;
623
624 /* I'll handle the locking */
625 regmap_config.disable_locking = true;
626 regmap = devm_regmap_init_i2c(client, ®map_config);
627 return regmap;
628 }
629
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30773 bytes --]
next prev parent reply other threads:[~2021-02-15 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 0:25 [PATCH] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS Don Bollinger
2021-02-15 2:22 ` kernel test robot
2021-02-15 2:22 ` kernel test robot
2021-02-15 2:56 ` kernel test robot [this message]
2021-02-15 2:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102151045.M1uYWT2U-lkp@intel.com \
--to=lkp@intel.com \
--cc=aken_liu@edge-core.com \
--cc=arndb@arndb.de \
--cc=brandon_chuang@edge-core.com \
--cc=don@thebollingers.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulv@microsoft.com \
--cc=jolevequ@microsoft.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wally_wang@accton.com \
--cc=xinxliu@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.