From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Stefan Chulski <stefanc@marvell.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Marcin Wojtas (mw@semihalf.com)" <mw@semihalf.com>,
Nadav Haklai <nadavh@marvell.com>,
Yan Markman <ymarkman@marvell.com>
Subject: Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation
Date: Mon, 15 Feb 2021 16:24:02 +0000 [thread overview]
Message-ID: <20210215162402.GZ1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <CO6PR18MB38732FD9F40B8956B019F719B0889@CO6PR18MB3873.namprd18.prod.outlook.com>
On Mon, Feb 15, 2021 at 04:19:19PM +0000, Stefan Chulski wrote:
> > > > I discussed it with Andrew earlier last year, and his response was:
> > > >
> > > > DT configuration of pause for fixed link probably is sufficient. I
> > > > don't remember it ever been really discussed for DSA. It was a
> > > > Melanox discussion about limiting pause for the CPU. So I think it
> > > > is safe to not implement ethtool -A, at least until somebody has a
> > > > real use case for it.
> > > >
> > > > So I chose not to support it - no point supporting features that
> > > > people aren't using. If you have a "real use case" then it can be added.
> > >
> > > This patch may be sufficient - I haven't fully considered all the
> > > implications of changing this though.
> >
> > Did you try this patch? What's the outcome?
>
> For me patch worked as expected.
Great, thanks. Andrew, do you have any further opinions on this
subject, or shall I sent a proper patch for net-next?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-02-15 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 10:12 Phylink flow control support on ports with MLO_AN_FIXED auto negotiation Stefan Chulski
[not found] ` <20210131103549.GA1463@shell.armlinux.org.uk>
2021-01-31 10:51 ` [EXT] " Stefan Chulski
[not found] ` <20210131111214.GB1463@shell.armlinux.org.uk>
2021-01-31 12:19 ` Russell King - ARM Linux admin
2021-02-13 11:39 ` Russell King - ARM Linux admin
2021-02-14 9:33 ` Stefan Chulski
2021-02-15 16:19 ` Stefan Chulski
2021-02-15 16:24 ` Russell King - ARM Linux admin [this message]
2021-02-15 18:18 ` Andrew Lunn
2021-02-15 20:33 ` Stefan Chulski
2021-02-16 13:08 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215162402.GZ1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.