All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Chulski <stefanc@marvell.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Marcin Wojtas (mw@semihalf.com)" <mw@semihalf.com>,
	Nadav Haklai <nadavh@marvell.com>,
	"Yan Markman" <ymarkman@marvell.com>
Subject: RE: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation
Date: Sun, 31 Jan 2021 10:51:46 +0000	[thread overview]
Message-ID: <CO6PR18MB3873D6F519D1B4112AA77671B0B79@CO6PR18MB3873.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210131103549.GA1463@shell.armlinux.org.uk>


> > Hi,
> >
> > Armada has options for 1G/10G ports without PHY's(for example
> community board Macchiato single shot).
> > This port doesn't have PHY's and cannot negotiate Flow Control support,
> but we can for example connect two ports without PHY's and manually(by
> ethtool) configure FC.
> 
> On the Macchiatobin single shot, you use the existing SFP support rather
> than forcing them to fixed link.
> 
> > Current phylink return error if I do this on ports with
> MLO_AN_FIXED(callback phylink_ethtool_set_pauseparam):
> > if (pl->cur_link_an_mode == MLO_AN_FIXED)
> >                 return -EOPNOTSUPP;
> >
> > How can we enable FC configurations for these ports? Do you have any
> suggestions or should I post my proposal as an RFC patch?
> 
> If you really must use fixed-link, you specify the pause modes via firmware,
> just as you specify the speed and duplex - you specify the link partner's flow
> control abilities.

In this case we cannot change this by ethtool during runtime?

Regards,
Stefan.

  parent reply	other threads:[~2021-01-31 15:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31 10:12 Phylink flow control support on ports with MLO_AN_FIXED auto negotiation Stefan Chulski
     [not found] ` <20210131103549.GA1463@shell.armlinux.org.uk>
2021-01-31 10:51   ` Stefan Chulski [this message]
     [not found]     ` <20210131111214.GB1463@shell.armlinux.org.uk>
2021-01-31 12:19       ` [EXT] " Russell King - ARM Linux admin
2021-02-13 11:39         ` Russell King - ARM Linux admin
2021-02-14  9:33           ` Stefan Chulski
2021-02-15 16:19           ` Stefan Chulski
2021-02-15 16:24             ` Russell King - ARM Linux admin
2021-02-15 18:18             ` Andrew Lunn
2021-02-15 20:33               ` Stefan Chulski
2021-02-16 13:08                 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB3873D6F519D1B4112AA77671B0B79@CO6PR18MB3873.namprd18.prod.outlook.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.