From: Ben Widawsky <ben.widawsky@intel.com> To: linux-cxl@vger.kernel.org Cc: Ben Widawsky <ben.widawsky@intel.com>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>, Chris Browy <cbrowy@avery-design.com>, Christoph Hellwig <hch@infradead.org>, David Hildenbrand <david@redhat.com>, David Rientjes <rientjes@google.com>, Jon Masters <jcm@jonmasters.org>, Jonathan Cameron <Jonathan.Cameron@Huawei.com>, Rafael Wysocki <rafael.j.wysocki@intel.com>, Randy Dunlap <rdunlap@infradead.org>, "John Groves (jgroves)" <jgroves@micron.com>, "Kelley, Sean V" <sean.v.kelley@intel.com> Subject: [PATCH v4 9/9] cxl/mem: Add payload dumping for debug Date: Mon, 15 Feb 2021 17:45:38 -0800 [thread overview] Message-ID: <20210216014538.268106-10-ben.widawsky@intel.com> (raw) In-Reply-To: <20210216014538.268106-1-ben.widawsky@intel.com> It's often useful in debug scenarios to see what the hardware has dumped out. As it stands today, any device error will result in the payload not being copied out, so there is no way to triage commands which weren't expected to fail (and sometimes the payload may have that information). The functionality is protected by normal kernel security mechanisms as well as a CONFIG option in the CXL driver. This was extracted from the original version of the CXL enabling patch series. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- drivers/cxl/Kconfig | 13 +++++++++++++ drivers/cxl/mem.c | 8 ++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig index 97dc4d751651..3eec9276e586 100644 --- a/drivers/cxl/Kconfig +++ b/drivers/cxl/Kconfig @@ -50,4 +50,17 @@ config CXL_MEM_RAW_COMMANDS potential impact to memory currently in use by the kernel. If developing CXL hardware or the driver say Y, otherwise say N. + +config CXL_MEM_INSECURE_DEBUG + bool "CXL.mem debugging" + depends on CXL_MEM + help + Enable debug of all CXL command payloads. + + Some CXL devices and controllers support encryption and other + security features. The payloads for the commands that enable + those features may contain sensitive clear-text security + material. Disable debug of those command payloads by default. + If you are a kernel developer actively working on CXL + security enabling say Y, otherwise say N. endif diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index dc608bb20a31..237b956f0be0 100644 --- a/drivers/cxl/mem.c +++ b/drivers/cxl/mem.c @@ -342,6 +342,14 @@ static int __cxl_mem_mbox_send_cmd(struct cxl_mem *cxlm, /* #5 */ rc = cxl_mem_wait_for_doorbell(cxlm); + + if (!cxl_is_security_command(mbox_cmd->opcode) || + IS_ENABLED(CONFIG_CXL_MEM_INSECURE_DEBUG)) { + print_hex_dump_debug("Payload ", DUMP_PREFIX_OFFSET, 16, 1, + mbox_cmd->payload_in, mbox_cmd->size_in, + true); + } + if (rc == -ETIMEDOUT) { cxl_mem_mbox_timeout(cxlm, mbox_cmd); return rc; -- 2.30.1 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Ben Widawsky <ben.widawsky@intel.com> To: linux-cxl@vger.kernel.org Cc: Ben Widawsky <ben.widawsky@intel.com>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>, Chris Browy <cbrowy@avery-design.com>, Christoph Hellwig <hch@infradead.org>, Dan Williams <dan.j.williams@intel.com>, David Hildenbrand <david@redhat.com>, David Rientjes <rientjes@google.com>, Ira Weiny <ira.weiny@intel.com>, Jon Masters <jcm@jonmasters.org>, Jonathan Cameron <Jonathan.Cameron@Huawei.com>, Rafael Wysocki <rafael.j.wysocki@intel.com>, Randy Dunlap <rdunlap@infradead.org>, Vishal Verma <vishal.l.verma@intel.com>, "John Groves (jgroves)" <jgroves@micron.com>, "Kelley, Sean V" <sean.v.kelley@intel.com> Subject: [PATCH v4 9/9] cxl/mem: Add payload dumping for debug Date: Mon, 15 Feb 2021 17:45:38 -0800 [thread overview] Message-ID: <20210216014538.268106-10-ben.widawsky@intel.com> (raw) In-Reply-To: <20210216014538.268106-1-ben.widawsky@intel.com> It's often useful in debug scenarios to see what the hardware has dumped out. As it stands today, any device error will result in the payload not being copied out, so there is no way to triage commands which weren't expected to fail (and sometimes the payload may have that information). The functionality is protected by normal kernel security mechanisms as well as a CONFIG option in the CXL driver. This was extracted from the original version of the CXL enabling patch series. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- drivers/cxl/Kconfig | 13 +++++++++++++ drivers/cxl/mem.c | 8 ++++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig index 97dc4d751651..3eec9276e586 100644 --- a/drivers/cxl/Kconfig +++ b/drivers/cxl/Kconfig @@ -50,4 +50,17 @@ config CXL_MEM_RAW_COMMANDS potential impact to memory currently in use by the kernel. If developing CXL hardware or the driver say Y, otherwise say N. + +config CXL_MEM_INSECURE_DEBUG + bool "CXL.mem debugging" + depends on CXL_MEM + help + Enable debug of all CXL command payloads. + + Some CXL devices and controllers support encryption and other + security features. The payloads for the commands that enable + those features may contain sensitive clear-text security + material. Disable debug of those command payloads by default. + If you are a kernel developer actively working on CXL + security enabling say Y, otherwise say N. endif diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c index dc608bb20a31..237b956f0be0 100644 --- a/drivers/cxl/mem.c +++ b/drivers/cxl/mem.c @@ -342,6 +342,14 @@ static int __cxl_mem_mbox_send_cmd(struct cxl_mem *cxlm, /* #5 */ rc = cxl_mem_wait_for_doorbell(cxlm); + + if (!cxl_is_security_command(mbox_cmd->opcode) || + IS_ENABLED(CONFIG_CXL_MEM_INSECURE_DEBUG)) { + print_hex_dump_debug("Payload ", DUMP_PREFIX_OFFSET, 16, 1, + mbox_cmd->payload_in, mbox_cmd->size_in, + true); + } + if (rc == -ETIMEDOUT) { cxl_mem_mbox_timeout(cxlm, mbox_cmd); return rc; -- 2.30.1
next prev parent reply other threads:[~2021-02-16 1:46 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 1:45 [PATCH v4 0/9] CXL 2.0 Support Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 1/9] cxl/mem: Introduce a driver for CXL-2.0-Type-3 endpoints Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 2/9] cxl/mem: Find device capabilities Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 14:51 ` Jonathan Cameron 2021-02-16 14:51 ` Jonathan Cameron 2021-02-16 16:43 ` Ben Widawsky 2021-02-16 16:43 ` Ben Widawsky 2021-02-16 17:20 ` Jonathan Cameron 2021-02-16 17:20 ` Jonathan Cameron 2021-02-16 17:56 ` Ben Widawsky 2021-02-16 17:56 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 3/9] cxl/mem: Register CXL memX devices Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 4/9] cxl/mem: Add basic IOCTL interface Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 15:22 ` Jonathan Cameron 2021-02-16 15:22 ` Jonathan Cameron 2021-02-16 17:53 ` Ben Widawsky 2021-02-16 17:53 ` Ben Widawsky 2021-02-16 18:28 ` Jonathan Cameron 2021-02-16 18:28 ` Jonathan Cameron 2021-02-16 18:34 ` Ben Widawsky 2021-02-16 18:34 ` Ben Widawsky 2021-02-17 9:55 ` Jonathan Cameron 2021-02-17 9:55 ` Jonathan Cameron 2021-02-16 18:12 ` Al Viro 2021-02-16 18:12 ` Al Viro 2021-02-16 18:22 ` Ben Widawsky 2021-02-16 18:22 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 5/9] cxl/mem: Add a "RAW" send command Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 15:30 ` Jonathan Cameron 2021-02-16 15:30 ` Jonathan Cameron 2021-02-16 18:03 ` Ben Widawsky 2021-02-16 18:03 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 6/9] cxl/mem: Enable commands via CEL Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 15:43 ` Jonathan Cameron 2021-02-16 15:43 ` Jonathan Cameron 2021-02-16 1:45 ` [PATCH v4 7/9] cxl/mem: Add set of informational commands Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 1:45 ` [PATCH v4 8/9] MAINTAINERS: Add maintainers of the CXL driver Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky 2021-02-16 1:45 ` Ben Widawsky [this message] 2021-02-16 1:45 ` [PATCH v4 9/9] cxl/mem: Add payload dumping for debug Ben Widawsky 2021-02-16 15:48 ` Jonathan Cameron 2021-02-16 15:48 ` Jonathan Cameron 2021-02-16 16:48 ` Dan Williams 2021-02-16 16:48 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210216014538.268106-10-ben.widawsky@intel.com \ --to=ben.widawsky@intel.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=cbrowy@avery-design.com \ --cc=david@redhat.com \ --cc=hch@infradead.org \ --cc=helgaas@kernel.org \ --cc=jcm@jonmasters.org \ --cc=jgroves@micron.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-cxl@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-pci@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=rdunlap@infradead.org \ --cc=rientjes@google.com \ --cc=sean.v.kelley@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.