[Buildroot] [PATCH/next v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained

[Buildroot] [PATCH/next v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained

[Peter Seiderer]

- Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
  system dhcp configured interface. With this option ('-b: background if
  lease is not obtained') the udhcpc keeps running in case the initial
  dhcp requests are not answered immediately.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
index 5ef032142c..d3135b18b6 100644
--- a/package/ifupdown-scripts/ifupdown-scripts.mk
+++ b/package/ifupdown-scripts/ifupdown-scripts.mk
@@ -28,6 +28,7 @@ define IFUPDOWN_SCRIPTS_DHCP
 		echo "  pre-up /etc/network/nfs_check"; \
 		echo "  wait-delay 15"; \
 		echo "  hostname \$$(hostname)"; \
+		echo "  udhcpc_opts -b"; \
 	) >> $(TARGET_DIR)/etc/network/interfaces
 endef
 define IFUPDOWN_SCRIPTS_DHCP_OPENRC
-- 
2.30.0

[Buildroot] [PATCH/next v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > - Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
 >   system dhcp configured interface. With this option ('-b: background if
 >   lease is not obtained') the udhcpc keeps running in case the initial
 >   dhcp requests are not answered immediately.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 >  package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
 > index 5ef032142c..d3135b18b6 100644
 > --- a/package/ifupdown-scripts/ifupdown-scripts.mk
 > +++ b/package/ifupdown-scripts/ifupdown-scripts.mk
 > @@ -28,6 +28,7 @@ define IFUPDOWN_SCRIPTS_DHCP
 >  		echo "  pre-up /etc/network/nfs_check"; \
 >  		echo "  wait-delay 15"; \
 >  		echo "  hostname \$$(hostname)"; \
 > +		echo "  udhcpc_opts -b"; \

Wouldn't it make more sense to change the value of
CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS in our default busybox.config instead
of hardcoding it here?

Does this still do the right thing for the fallback to IPv4LL addressing
if avahi-autoipd is enabled?

-- 
Bye, Peter Korsgaard

Re: [Buildroot] [PATCH/next v1] package/ifupdown-scripts: send udhcpc to background in case lease is not obtained

[Thomas Petazzoni]

Hello Peter,

On Tue, 16 Feb 2021 21:20:22 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> - Add the 'udhcpc_opts -b' option to /etc/network/interfaces for the
>   system dhcp configured interface. With this option ('-b: background if
>   lease is not obtained') the udhcpc keeps running in case the initial
>   dhcp requests are not answered immediately.
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/ifupdown-scripts/ifupdown-scripts.mk | 1 +
>  1 file changed, 1 insertion(+)

There has been some feedback from Peter Korsgaard on your patch, but
you didn't reply to it. Could you follow-up so that we can move forward?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot