From: Christoph Hellwig <hch@infradead.org> To: Nadav Amit <nadav.amit@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Dave Hansen <dave.hansen@linux.intel.com>, Nadav Amit <namit@vmware.com>, "K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger <sthemmin@microsoft.com>, Sasha Levin <sashal@kernel.org>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, x86@kernel.org, Juergen Gross <jgross@suse.com>, Paolo Bonzini <pbonzini@redhat.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Michael Kelley <mikelley@microsoft.com> Subject: Re: [PATCH v5 4/8] x86/mm/tlb: Flush remote and local TLBs concurrently Date: Thu, 18 Feb 2021 08:14:08 +0000 [thread overview] Message-ID: <20210218081408.GB335524@infradead.org> (raw) In-Reply-To: <20210209221653.614098-5-namit@vmware.com> Given that the last patch killed the last previously existing user of on_each_cpu_cond_mask there are now the only users. > if (info->freed_tables) { > - smp_call_function_many(cpumask, flush_tlb_func, > - (void *)info, 1); > + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true, > + cpumask); .. > + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true, > + cpumask); Which means the cond_func is unused, and thus on_each_cpu_cond_mask can go away entirely in favor of on_each_cpu_cond.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org> To: Nadav Amit <nadav.amit@gmail.com> Cc: Sasha Levin <sashal@kernel.org>, Juergen Gross <jgross@suse.com>, linux-hyperv@vger.kernel.org, x86@kernel.org, Stephen Hemminger <sthemmin@microsoft.com>, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Haiyang Zhang <haiyangz@microsoft.com>, Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar <mingo@redhat.com>, Nadav Amit <namit@vmware.com>, Andy Lutomirski <luto@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>, Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Michael Kelley <mikelley@microsoft.com> Subject: Re: [PATCH v5 4/8] x86/mm/tlb: Flush remote and local TLBs concurrently Date: Thu, 18 Feb 2021 08:14:08 +0000 [thread overview] Message-ID: <20210218081408.GB335524@infradead.org> (raw) In-Reply-To: <20210209221653.614098-5-namit@vmware.com> Given that the last patch killed the last previously existing user of on_each_cpu_cond_mask there are now the only users. > if (info->freed_tables) { > - smp_call_function_many(cpumask, flush_tlb_func, > - (void *)info, 1); > + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true, > + cpumask); .. > + on_each_cpu_cond_mask(NULL, flush_tlb_func, (void *)info, true, > + cpumask); Which means the cond_func is unused, and thus on_each_cpu_cond_mask can go away entirely in favor of on_each_cpu_cond. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-02-18 9:39 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 22:16 [PATCH v5 0/8] x86/tlb: Concurrent TLB flushes Nadav Amit 2021-02-09 22:16 ` Nadav Amit 2021-02-09 22:16 ` [PATCH v5 1/8] smp: Run functions concurrently in smp_call_function_many_cond() Nadav Amit 2021-02-16 12:04 ` Peter Zijlstra 2021-02-16 18:49 ` Nadav Amit 2021-02-16 12:06 ` Peter Zijlstra 2021-02-16 16:32 ` Peter Zijlstra 2021-02-16 18:53 ` Nadav Amit 2021-02-16 18:59 ` Peter Zijlstra 2021-02-16 19:04 ` Nadav Amit 2021-02-17 1:02 ` Nadav Amit 2021-02-18 12:55 ` Peter Zijlstra 2021-02-18 8:09 ` Christoph Hellwig 2021-02-18 9:36 ` Nadav Amit 2021-02-18 11:12 ` Peter Zijlstra 2021-02-09 22:16 ` [PATCH v5 2/8] x86/mm/tlb: Unify flush_tlb_func_local() and flush_tlb_func_remote() Nadav Amit 2021-02-09 22:16 ` [PATCH v5 3/8] x86/mm/tlb: Open-code on_each_cpu_cond_mask() for tlb_is_not_lazy() Nadav Amit 2021-02-18 8:16 ` Christoph Hellwig 2021-02-18 8:24 ` Nadav Amit 2021-02-18 8:28 ` Christoph Hellwig 2021-02-09 22:16 ` [PATCH v5 4/8] x86/mm/tlb: Flush remote and local TLBs concurrently Nadav Amit 2021-02-09 22:16 ` Nadav Amit 2021-02-16 12:10 ` Peter Zijlstra 2021-02-16 12:10 ` Peter Zijlstra 2021-02-16 19:17 ` Nadav Amit 2021-02-16 19:17 ` Nadav Amit 2021-02-18 8:14 ` Christoph Hellwig [this message] 2021-02-18 8:14 ` Christoph Hellwig 2021-02-09 22:16 ` [PATCH v5 5/8] x86/mm/tlb: Privatize cpu_tlbstate Nadav Amit 2021-02-09 22:16 ` [PATCH v5 6/8] x86/mm/tlb: Do not make is_lazy dirty for no reason Nadav Amit 2021-02-09 22:16 ` [PATCH v5 7/8] cpumask: Mark functions as pure Nadav Amit 2021-02-16 12:14 ` Peter Zijlstra 2021-02-09 22:16 ` [PATCH v5 8/8] x86/mm/tlb: Remove unnecessary uses of the inline keyword Nadav Amit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210218081408.GB335524@infradead.org \ --to=hch@infradead.org \ --cc=boris.ostrovsky@oracle.com \ --cc=bp@alien8.de \ --cc=dave.hansen@linux.intel.com \ --cc=haiyangz@microsoft.com \ --cc=jgross@suse.com \ --cc=kvm@vger.kernel.org \ --cc=kys@microsoft.com \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mikelley@microsoft.com \ --cc=mingo@redhat.com \ --cc=nadav.amit@gmail.com \ --cc=namit@vmware.com \ --cc=pbonzini@redhat.com \ --cc=peterz@infradead.org \ --cc=sashal@kernel.org \ --cc=sthemmin@microsoft.com \ --cc=tglx@linutronix.de \ --cc=virtualization@lists.linux-foundation.org \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.