From: Atul Gopinathan <atulgopinathan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Atul Gopinathan <atulgopinathan@gmail.com>
Subject: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type
Date: Thu, 18 Feb 2021 14:14:03 +0530 [thread overview]
Message-ID: <20210218084404.16591-1-atulgopinathan@gmail.com> (raw)
Fix the following warning generated by sparse:
drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces)
drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist
drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] <asn:1> *
compat_ptr() has a return type of "void __user *"
as defined in "include/linux/compat.h"
cmd->chanlist is of type "unsigned int *" as defined
in drivers/staging/comedi/comedi.h" in struct
comedi_cmd.
Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e85a99b68f31..fc4ec38012b4 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
cmd->scan_end_arg = v32.scan_end_arg;
cmd->stop_src = v32.stop_src;
cmd->stop_arg = v32.stop_arg;
- cmd->chanlist = compat_ptr(v32.chanlist);
+ cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist);
cmd->chanlist_len = v32.chanlist_len;
cmd->data = compat_ptr(v32.data);
cmd->data_len = v32.data_len;
--
2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Atul Gopinathan <atulgopinathan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org,
Atul Gopinathan <atulgopinathan@gmail.com>
Subject: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type
Date: Thu, 18 Feb 2021 14:14:03 +0530 [thread overview]
Message-ID: <20210218084404.16591-1-atulgopinathan@gmail.com> (raw)
Fix the following warning generated by sparse:
drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces)
drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist
drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] <asn:1> *
compat_ptr() has a return type of "void __user *"
as defined in "include/linux/compat.h"
cmd->chanlist is of type "unsigned int *" as defined
in drivers/staging/comedi/comedi.h" in struct
comedi_cmd.
Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e85a99b68f31..fc4ec38012b4 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
cmd->scan_end_arg = v32.scan_end_arg;
cmd->stop_src = v32.stop_src;
cmd->stop_arg = v32.stop_arg;
- cmd->chanlist = compat_ptr(v32.chanlist);
+ cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist);
cmd->chanlist_len = v32.chanlist_len;
cmd->data = compat_ptr(v32.data);
cmd->data_len = v32.data_len;
--
2.27.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2021-02-18 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 8:44 Atul Gopinathan [this message]
2021-02-18 8:44 ` [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Atul Gopinathan
2021-02-18 8:44 ` [PATCH v2 2/2] staging: comedi: cast function argument to expected type (void __user *) Atul Gopinathan
2021-02-18 8:44 ` Atul Gopinathan
2021-02-18 10:31 ` [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Ian Abbott
2021-02-18 10:31 ` Ian Abbott
2021-02-18 10:47 ` Atul Gopinathan
2021-02-18 10:47 ` Atul Gopinathan
2021-02-18 12:21 ` Greg KH
2021-02-18 12:21 ` Greg KH
2021-02-18 12:52 ` Atul Gopinathan
2021-02-18 12:52 ` Atul Gopinathan
2021-02-18 13:46 ` Greg KH
2021-02-18 13:46 ` Greg KH
2021-02-18 14:12 ` Atul Gopinathan
2021-02-18 14:12 ` Atul Gopinathan
2021-02-18 15:51 ` Dan Carpenter
2021-02-18 15:51 ` Dan Carpenter
2021-02-18 16:41 ` Atul Gopinathan
2021-02-18 16:41 ` Atul Gopinathan
2021-02-19 6:55 ` Dan Carpenter
2021-02-19 6:55 ` Dan Carpenter
2021-02-19 7:42 ` Atul Gopinathan
2021-02-19 7:42 ` Atul Gopinathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218084404.16591-1-atulgopinathan@gmail.com \
--to=atulgopinathan@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.