All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: u-boot@lists.denx.de
Subject: [PATCH] button: add udevice forward declaration
Date: Fri, 19 Feb 2021 08:41:24 +0100	[thread overview]
Message-ID: <20210219074124.1571269-1-narmstrong@baylibre.com> (raw)

After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
build fails with :

drivers/button/button-uclass.c:13:5: error: conflicting types for 'button_get_by_label'
int button_get_by_label(const char *label, struct udevice **devp)
    ^~~~~~~~~~~~~~~~~~~

Adding struct udevice forward declaration in button.h solves the build error.

Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
Hi,

This is needed to fix build on vim3/vim3l after [1] is applied.

[1] https://patchwork.ozlabs.org/project/uboot/cover/20210218103318.18915-1-m.szyprowski at samsung.com/

 include/button.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/button.h b/include/button.h
index 688b63b082..ee14fadf0c 100644
--- a/include/button.h
+++ b/include/button.h
@@ -6,6 +6,8 @@
 #ifndef __BUTTON_H
 #define __BUTTON_H
 
+struct udevice;
+
 /**
  * struct button_uc_plat - Platform data the uclass stores about each device
  *
-- 
2.25.1

WARNING: multiple messages have this Message-ID (diff)
From: "Neil Armstrong" <narmstrong@baylibre.com>
To: Simon Glass <sjg@chromium.org>, xypron.glpk@gmx.de
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	m.szyprowski@samsung.com, u-boot@lists.denx.de,
	u-boot-amlogic@groups.io, philippe.reynes@softathome.com
Subject: [PATCH] button: add udevice forward declaration
Date: Fri, 19 Feb 2021 08:41:24 +0100	[thread overview]
Message-ID: <20210219074124.1571269-1-narmstrong@baylibre.com> (raw)

After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
build fails with :

drivers/button/button-uclass.c:13:5: error: conflicting types for 'button_get_by_label'
int button_get_by_label(const char *label, struct udevice **devp)
    ^~~~~~~~~~~~~~~~~~~

Adding struct udevice forward declaration in button.h solves the build error.

Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
Hi,

This is needed to fix build on vim3/vim3l after [1] is applied.

[1] https://patchwork.ozlabs.org/project/uboot/cover/20210218103318.18915-1-m.szyprowski@samsung.com/

 include/button.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/button.h b/include/button.h
index 688b63b082..ee14fadf0c 100644
--- a/include/button.h
+++ b/include/button.h
@@ -6,6 +6,8 @@
 #ifndef __BUTTON_H
 #define __BUTTON_H
 
+struct udevice;
+
 /**
  * struct button_uc_plat - Platform data the uclass stores about each device
  *
-- 
2.25.1


             reply	other threads:[~2021-02-19  7:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  7:41 Neil Armstrong [this message]
2021-02-19  7:41 ` [PATCH] button: add udevice forward declaration Neil Armstrong
2021-02-20 11:55 ` Simon Glass
2021-02-22 17:39   ` Neil Armstrong
2021-02-22 17:39     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219074124.1571269-1-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.