* [PATCH] media: atomisp: do not free kmalloc memory by vfree
@ 2021-02-19 10:12 Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2021-02-19 10:12 UTC (permalink / raw)
To: mchehab+huawei; +Cc: linux-media, sakari.ailus, linux-kernel, Jiri Slaby
fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
and by vmalloc in setup_binary. So use kvfree to decide which of those
allocators to use for freeing.
Also remove the useless cast.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index db25e39bea88..f4ce8ace9d50 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -366,7 +366,7 @@ void sh_css_unload_firmware(void)
if (fw_minibuffer[i].name)
kfree((void *)fw_minibuffer[i].name);
if (fw_minibuffer[i].buffer)
- vfree((void *)fw_minibuffer[i].buffer);
+ kvfree(fw_minibuffer[i].buffer);
}
kfree(fw_minibuffer);
fw_minibuffer = NULL;
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: atomisp: do not free kmalloc memory by vfree
2020-07-17 8:05 ` [PATCH] media: atomisp: do not free kmalloc memory by vfree Jiri Slaby
@ 2020-07-17 8:40 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2020-07-17 8:40 UTC (permalink / raw)
To: corbet; +Cc: linux-kernel, Mauro Carvalho Chehab
Sorry Jon, wrong To: field, this was supposed to be addressed to Mauro
(who is CCed).
On 17. 07. 20, 10:05, Jiri Slaby wrote:
> fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
> and by vmalloc in setup_binary. So use kvfree to decide which of those
> allocators to use for freeing.
>
> Also remove the useless cast.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/staging/media/atomisp/pci/sh_css_firmware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index d4ab15b6d1ac..d0011b1d97ed 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -358,7 +358,7 @@ void sh_css_unload_firmware(void)
> if (fw_minibuffer[i].name)
> kfree((void *)fw_minibuffer[i].name);
> if (fw_minibuffer[i].buffer)
> - vfree((void *)fw_minibuffer[i].buffer);
> + kvfree(fw_minibuffer[i].buffer);
> }
> kfree(fw_minibuffer);
> fw_minibuffer = NULL;
>
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] media: atomisp: do not free kmalloc memory by vfree
2020-06-23 6:32 [PATCH] MAINTAINERS: use my kernel.org address Joe Perches
@ 2020-07-17 8:05 ` Jiri Slaby
2020-07-17 8:40 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2020-07-17 8:05 UTC (permalink / raw)
To: corbet; +Cc: linux-kernel, Jiri Slaby, Mauro Carvalho Chehab
fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
and by vmalloc in setup_binary. So use kvfree to decide which of those
allocators to use for freeing.
Also remove the useless cast.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index d4ab15b6d1ac..d0011b1d97ed 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -358,7 +358,7 @@ void sh_css_unload_firmware(void)
if (fw_minibuffer[i].name)
kfree((void *)fw_minibuffer[i].name);
if (fw_minibuffer[i].buffer)
- vfree((void *)fw_minibuffer[i].buffer);
+ kvfree(fw_minibuffer[i].buffer);
}
kfree(fw_minibuffer);
fw_minibuffer = NULL;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-19 10:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 10:12 [PATCH] media: atomisp: do not free kmalloc memory by vfree Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2020-06-23 6:32 [PATCH] MAINTAINERS: use my kernel.org address Joe Perches
2020-07-17 8:05 ` [PATCH] media: atomisp: do not free kmalloc memory by vfree Jiri Slaby
2020-07-17 8:40 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.