* [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property
@ 2021-02-19 11:51 Philippe Mathieu-Daudé
2021-02-19 11:58 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-19 11:51 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Thomas Huth, Alistair Francis,
Philippe Mathieu-Daudé,
qemu-arm, Edgar E. Iglesias
We hint the 'has_rpu' property is no longer required since commit
6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
option") which was released in QEMU v2.11.0.
3 years later we feel safe enough to remove it without using the
usual deprecation policy.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/arm/xlnx-zynqmp.h | 2 --
hw/arm/xlnx-zynqmp.c | 6 ------
2 files changed, 8 deletions(-)
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
index 6f45387a173..0678b419a23 100644
--- a/include/hw/arm/xlnx-zynqmp.h
+++ b/include/hw/arm/xlnx-zynqmp.h
@@ -115,8 +115,6 @@ struct XlnxZynqMPState {
bool secure;
/* Has the ARM Virtualization extensions? */
bool virt;
- /* Has the RPU subsystem? */
- bool has_rpu;
/* CAN bus. */
CanBusState *canbus[XLNX_ZYNQMP_NUM_CAN];
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 881847255b4..46030c1ef81 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw/arm/xlnx-zynqmp.c
@@ -443,11 +443,6 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
}
}
- if (s->has_rpu) {
- info_report("The 'has_rpu' property is no longer required, to use the "
- "RPUs just use -smp 6.");
- }
-
xlnx_zynqmp_create_rpu(ms, s, boot_cpu, &err);
if (err) {
error_propagate(errp, err);
@@ -646,7 +641,6 @@ static Property xlnx_zynqmp_props[] = {
DEFINE_PROP_STRING("boot-cpu", XlnxZynqMPState, boot_cpu),
DEFINE_PROP_BOOL("secure", XlnxZynqMPState, secure, false),
DEFINE_PROP_BOOL("virtualization", XlnxZynqMPState, virt, false),
- DEFINE_PROP_BOOL("has_rpu", XlnxZynqMPState, has_rpu, false),
DEFINE_PROP_LINK("ddr-ram", XlnxZynqMPState, ddr_ram, TYPE_MEMORY_REGION,
MemoryRegion *),
DEFINE_PROP_LINK("canbus0", XlnxZynqMPState, canbus[0], TYPE_CAN_BUS,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property
2021-02-19 11:51 [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property Philippe Mathieu-Daudé
@ 2021-02-19 11:58 ` Peter Maydell
2021-02-19 14:40 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2021-02-19 11:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Edgar E. Iglesias, Thomas Huth, qemu-arm, QEMU Developers,
Alistair Francis
On Fri, 19 Feb 2021 at 11:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> We hint the 'has_rpu' property is no longer required since commit
> 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
> option") which was released in QEMU v2.11.0.
>
> 3 years later we feel safe enough to remove it without using the
> usual deprecation policy.
This device is marked user_creatable = false, so the only thing
that could be setting the property is the board code that creates
the device. So the property is not user-facing and we can remove it
without going through the deprecation process.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(maybe noting the above in the commit message).
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property
2021-02-19 11:58 ` Peter Maydell
@ 2021-02-19 14:40 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-19 14:40 UTC (permalink / raw)
To: Peter Maydell; +Cc: Thomas Huth, qemu-arm, QEMU Developers, Alistair Francis
On 2/19/21 12:58 PM, Peter Maydell wrote:
> On Fri, 19 Feb 2021 at 11:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> We hint the 'has_rpu' property is no longer required since commit
>> 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
>> option") which was released in QEMU v2.11.0.
>>
>> 3 years later we feel safe enough to remove it without using the
>> usual deprecation policy.
>
> This device is marked user_creatable = false, so the only thing
> that could be setting the property is the board code that creates
> the device. So the property is not user-facing and we can remove it
> without going through the deprecation process.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> (maybe noting the above in the commit message).
OK I'll update, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-19 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 11:51 [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property Philippe Mathieu-Daudé
2021-02-19 11:58 ` Peter Maydell
2021-02-19 14:40 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.