From: Joey Gouly <joey.gouly@arm.com> To: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, marcan@marcan.st, james.morse@arm.com, maz@kernel.org, tglx@linutronix.de, will@kernel.org, nd@arm.com Subject: Re: [PATCH 8/8] arm64: irq: allow FIQs to be handled Date: Fri, 19 Feb 2021 15:37:25 +0000 [thread overview] Message-ID: <20210219153725.GA43917@e124191.cambridge.arm.com> (raw) In-Reply-To: <20210219113904.41736-9-mark.rutland@arm.com> Hi Mark, On Fri, Feb 19, 2021 at 11:39:04AM +0000, Mark Rutland wrote: > On contemporary platforms we don't use FIQ, and treat any stray FIQ as a > fatal event. However, some platforms have an interrupt controller wired > to FIQ, and need to handle FIQ as part of regular operation. > [...] > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index 0474cca9f1a9..a8290bd87a49 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -586,23 +586,23 @@ SYM_CODE_START(vectors) > > kernel_ventry 1, sync // Synchronous EL1h > kernel_ventry 1, irq // IRQ EL1h > - kernel_ventry 1, fiq_invalid // FIQ EL1h > + kernel_ventry 1, fiq // FIQ EL1h > kernel_ventry 1, error // Error EL1h > > kernel_ventry 0, sync // Synchronous 64-bit EL0 > kernel_ventry 0, irq // IRQ 64-bit EL0 > - kernel_ventry 0, fiq_invalid // FIQ 64-bit EL0 > + kernel_ventry 0, fiq // FIQ 64-bit EL0 > kernel_ventry 0, error // Error 64-bit EL0 > > #ifdef CONFIG_COMPAT > kernel_ventry 0, sync_compat, 32 // Synchronous 32-bit EL0 > kernel_ventry 0, irq_compat, 32 // IRQ 32-bit EL0 > - kernel_ventry 0, fiq_invalid_compat, 32 // FIQ 32-bit EL0 > + kernel_ventry 0, fiq_compat, 32 // FIQ 32-bit EL0 > kernel_ventry 0, error_compat, 32 // Error 32-bit EL0 > #else > kernel_ventry 0, sync_invalid, 32 // Synchronous 32-bit EL0 > kernel_ventry 0, irq_invalid, 32 // IRQ 32-bit EL0 > - kernel_ventry 0, fiq_invalid, 32 // FIQ 32-bit EL0 > + kernel_ventry 0, fiq, 32 // FIQ 32-bit EL0 > kernel_ventry 0, error_invalid, 32 // Error 32-bit EL0 > #endif > SYM_CODE_END(vectors) I believe you can now remove functions `el0_fiq_invalid` and `el0_fiq_invalid_compat`. `el1_fiq_invalid` is still used by Synchronous EL1t, so can't be removed. Thanks, Joey
WARNING: multiple messages have this Message-ID (diff)
From: Joey Gouly <joey.gouly@arm.com> To: Mark Rutland <mark.rutland@arm.com> Cc: catalin.marinas@arm.com, marcan@marcan.st, linux-kernel@vger.kernel.org, james.morse@arm.com, maz@kernel.org, tglx@linutronix.de, nd@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] arm64: irq: allow FIQs to be handled Date: Fri, 19 Feb 2021 15:37:25 +0000 [thread overview] Message-ID: <20210219153725.GA43917@e124191.cambridge.arm.com> (raw) In-Reply-To: <20210219113904.41736-9-mark.rutland@arm.com> Hi Mark, On Fri, Feb 19, 2021 at 11:39:04AM +0000, Mark Rutland wrote: > On contemporary platforms we don't use FIQ, and treat any stray FIQ as a > fatal event. However, some platforms have an interrupt controller wired > to FIQ, and need to handle FIQ as part of regular operation. > [...] > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index 0474cca9f1a9..a8290bd87a49 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -586,23 +586,23 @@ SYM_CODE_START(vectors) > > kernel_ventry 1, sync // Synchronous EL1h > kernel_ventry 1, irq // IRQ EL1h > - kernel_ventry 1, fiq_invalid // FIQ EL1h > + kernel_ventry 1, fiq // FIQ EL1h > kernel_ventry 1, error // Error EL1h > > kernel_ventry 0, sync // Synchronous 64-bit EL0 > kernel_ventry 0, irq // IRQ 64-bit EL0 > - kernel_ventry 0, fiq_invalid // FIQ 64-bit EL0 > + kernel_ventry 0, fiq // FIQ 64-bit EL0 > kernel_ventry 0, error // Error 64-bit EL0 > > #ifdef CONFIG_COMPAT > kernel_ventry 0, sync_compat, 32 // Synchronous 32-bit EL0 > kernel_ventry 0, irq_compat, 32 // IRQ 32-bit EL0 > - kernel_ventry 0, fiq_invalid_compat, 32 // FIQ 32-bit EL0 > + kernel_ventry 0, fiq_compat, 32 // FIQ 32-bit EL0 > kernel_ventry 0, error_compat, 32 // Error 32-bit EL0 > #else > kernel_ventry 0, sync_invalid, 32 // Synchronous 32-bit EL0 > kernel_ventry 0, irq_invalid, 32 // IRQ 32-bit EL0 > - kernel_ventry 0, fiq_invalid, 32 // FIQ 32-bit EL0 > + kernel_ventry 0, fiq, 32 // FIQ 32-bit EL0 > kernel_ventry 0, error_invalid, 32 // Error 32-bit EL0 > #endif > SYM_CODE_END(vectors) I believe you can now remove functions `el0_fiq_invalid` and `el0_fiq_invalid_compat`. `el1_fiq_invalid` is still used by Synchronous EL1t, so can't be removed. Thanks, Joey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-19 15:38 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-19 11:38 [PATCH 0/8] arm64: Support FIQ controller registration Mark Rutland 2021-02-19 11:38 ` Mark Rutland 2021-02-19 11:38 ` [PATCH 1/8] ARM: ep93xx: Select GENERIC_IRQ_MULTI_HANDLER directly Mark Rutland 2021-02-19 11:38 ` Mark Rutland 2021-02-19 11:38 ` [PATCH 2/8] irqchip: Do not blindly select CONFIG_GENERIC_IRQ_MULTI_HANDLER Mark Rutland 2021-02-19 11:38 ` Mark Rutland 2021-02-19 11:38 ` [PATCH 3/8] genirq: Allow architectures to override set_handle_irq() fallback Mark Rutland 2021-02-19 11:38 ` Mark Rutland 2021-02-19 11:39 ` [PATCH 4/8] arm64: don't use GENERIC_IRQ_MULTI_HANDLER Mark Rutland 2021-02-19 11:39 ` Mark Rutland 2021-02-19 11:39 ` [PATCH 5/8] arm64: irq: add a default handle_irq panic function Mark Rutland 2021-02-19 11:39 ` Mark Rutland 2021-02-22 9:59 ` Mark Rutland 2021-02-22 9:59 ` Mark Rutland 2021-02-22 10:48 ` Marc Zyngier 2021-02-22 10:48 ` Marc Zyngier 2021-02-22 11:25 ` Mark Rutland 2021-02-22 11:25 ` Mark Rutland 2021-02-22 11:43 ` Marc Zyngier 2021-02-22 11:43 ` Marc Zyngier 2021-02-22 12:06 ` Mark Rutland 2021-02-22 12:06 ` Mark Rutland 2021-02-22 12:23 ` Marc Zyngier 2021-02-22 12:23 ` Marc Zyngier 2021-02-19 11:39 ` [PATCH 6/8] arm64: entry: factor irq triage logic into macros Mark Rutland 2021-02-19 11:39 ` Mark Rutland 2021-02-19 11:39 ` [PATCH 7/8] arm64: Always keep DAIF.[IF] in sync Mark Rutland 2021-02-19 11:39 ` Mark Rutland 2021-02-19 17:25 ` [PATCH 7/8 v1.5] " Hector Martin 2021-02-19 17:25 ` Hector Martin 2021-02-19 18:26 ` Mark Rutland 2021-02-19 18:26 ` Mark Rutland 2021-02-22 17:39 ` Hector Martin 2021-02-22 17:39 ` Hector Martin 2021-02-22 18:43 ` Mark Rutland 2021-02-22 18:43 ` Mark Rutland 2021-02-19 11:39 ` [PATCH 8/8] arm64: irq: allow FIQs to be handled Mark Rutland 2021-02-19 11:39 ` Mark Rutland 2021-02-19 15:37 ` Joey Gouly [this message] 2021-02-19 15:37 ` Joey Gouly 2021-02-19 18:18 ` Mark Rutland 2021-02-19 18:18 ` Mark Rutland 2021-02-19 15:41 ` [PATCH 0/8] arm64: Support FIQ controller registration Hector Martin 2021-02-19 15:41 ` Hector Martin 2021-02-19 16:13 ` Mark Rutland 2021-02-19 16:13 ` Mark Rutland 2021-02-19 18:10 ` Marc Zyngier 2021-02-19 18:10 ` Marc Zyngier 2021-02-24 14:06 ` Mark Rutland 2021-02-24 14:06 ` Mark Rutland 2021-02-24 14:32 ` Marc Zyngier 2021-02-24 14:32 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210219153725.GA43917@e124191.cambridge.arm.com \ --to=joey.gouly@arm.com \ --cc=catalin.marinas@arm.com \ --cc=james.morse@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=nd@arm.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.