* [PATCH v3] staging: rtl8723bs: fix code style comparison warning
@ 2021-02-19 18:23 ` Kurt Manucredo
0 siblings, 0 replies; 4+ messages in thread
From: Kurt Manucredo @ 2021-02-19 18:23 UTC (permalink / raw)
To: gregkh, ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai
Cc: Kurt Manucredo, devel, linux-kernel
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
---
changes since previous version:
- put version chatter below the --- cut off line.
thank you very much for your help Mr. Dan Carpenter.
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = &padapter->securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v3] staging: rtl8723bs: fix code style comparison warning
@ 2021-02-19 18:23 ` Kurt Manucredo
0 siblings, 0 replies; 4+ messages in thread
From: Kurt Manucredo @ 2021-02-19 18:23 UTC (permalink / raw)
To: gregkh, ross.schm.dev, straube.linux, dan.carpenter, d.straghkov, tiwai
Cc: devel, linux-kernel, Kurt Manucredo
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
---
changes since previous version:
- put version chatter below the --- cut off line.
thank you very much for your help Mr. Dan Carpenter.
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = &padapter->securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] staging: rtl8723bs: fix code style comparison warning
2021-02-19 18:23 ` Kurt Manucredo
@ 2021-02-22 5:08 ` Dan Carpenter
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-22 5:08 UTC (permalink / raw)
To: Kurt Manucredo
Cc: gregkh, ross.schm.dev, straube.linux, d.straghkov, tiwai, devel,
linux-kernel
On Fri, Feb 19, 2021 at 06:23:54PM +0000, Kurt Manucredo wrote:
>
>
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
Looks okay to me. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] staging: rtl8723bs: fix code style comparison warning
@ 2021-02-22 5:08 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-22 5:08 UTC (permalink / raw)
To: Kurt Manucredo; +Cc: devel, tiwai, gregkh, d.straghkov, linux-kernel
On Fri, Feb 19, 2021 at 06:23:54PM +0000, Kurt Manucredo wrote:
>
>
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
Looks okay to me. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 5:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 18:23 [PATCH v3] staging: rtl8723bs: fix code style comparison warning Kurt Manucredo
2021-02-19 18:23 ` Kurt Manucredo
2021-02-22 5:08 ` Dan Carpenter
2021-02-22 5:08 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.