All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] printk: fix returnvar.cocci warnings
Date: Sat, 20 Feb 2021 03:08:58 +0800	[thread overview]
Message-ID: <20210219190858.GA74127@4de4ecc959fc> (raw)
In-Reply-To: <202102200308.Gy4VOnMO-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

CC: kbuild-all(a)lists.01.org
TO: John Ogness <john.ogness@linutronix.de>
CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
CC: Petr Mladek <pmladek@suse.com>
CC: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 2af6fa626087 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.11.y-rt-rebase
head:   87401fa51512cc03c8a42bdc6e5940be76051ec5
commit: 2af6fa6260871a5adb4faf062241651587f62e30 [36/199] printk: move console printing to kthreads
:::::: branch date: 25 hours ago
:::::: commit date: 25 hours ago

Please take the patch only if it's a positive warning. Thanks!

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2142,7 +2142,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	u64 printk_seq;
@@ -2241,7 +2240,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

  reply	other threads:[~2021-02-19 19:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 19:08 [linux-rt-devel:linux-5.11.y-rt-rebase 36/199] kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244 kernel test robot
2021-02-19 19:08 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-07-08 15:16 [linux-rt-devel:linux-5.13.y-rt-rebase 11/222] kernel/printk/printk.c:2189:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2294 kernel test robot
2021-07-08 15:17 ` [PATCH] printk: fix returnvar.cocci warnings kernel test robot
2021-07-08 15:17   ` kernel test robot
2021-03-20  5:22 [linux-rt-devel:linux-5.12.y-rt-rebase 32/193] kernel/printk/printk.c:2195:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2300 kernel test robot
2021-03-20  5:22 ` [PATCH] printk: fix returnvar.cocci warnings kernel test robot
2021-01-22  9:03 [linux-rt-devel:linux-5.11.y-rt-rebase 34/184] kernel/printk/printk.c:2127:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2226 kernel test robot
2021-01-22  9:03 ` [PATCH] printk: fix returnvar.cocci warnings kernel test robot
2020-11-01 13:05 [linux-rt-devel:linux-5.10.y-rt-rebase 57/209] kernel/printk/printk.c:2808:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2819 kernel test robot
2020-11-01 13:05 ` [PATCH] printk: fix returnvar.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219190858.GA74127@4de4ecc959fc \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.