[linux-rt-devel:linux-5.11.y-rt-rebase 36/199] kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244

[linux-rt-devel:linux-5.11.y-rt-rebase 36/199] kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

CC: kbuild-all(a)lists.01.org
TO: John Ogness <john.ogness@linutronix.de>
CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.11.y-rt-rebase
head:   87401fa51512cc03c8a42bdc6e5940be76051ec5
commit: 2af6fa6260871a5adb4faf062241651587f62e30 [36/199] printk: move console printing to kthreads
:::::: branch date: 25 hours ago
:::::: commit date: 25 hours ago
config: i386-randconfig-c001-20210219 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35716 bytes --]

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

CC: kbuild-all(a)lists.01.org
TO: John Ogness <john.ogness@linutronix.de>
CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
CC: Petr Mladek <pmladek@suse.com>
CC: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2145:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2244


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 2af6fa626087 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.11.y-rt-rebase
head:   87401fa51512cc03c8a42bdc6e5940be76051ec5
commit: 2af6fa6260871a5adb4faf062241651587f62e30 [36/199] printk: move console printing to kthreads
:::::: branch date: 25 hours ago
:::::: commit date: 25 hours ago

Please take the patch only if it's a positive warning. Thanks!

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2142,7 +2142,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	u64 printk_seq;
@@ -2241,7 +2240,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2189:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2294


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: c4049cfc8a03 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.13.y-rt-rebase
head:   7e175e6b59975c8901ad370f7818937f68de45c1
commit: c4049cfc8a0327c22d56855882d8e2cffd6d20fa [11/222] printk: move console printing to kthreads
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2186,7 +2186,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	size_t len;
@@ -2291,7 +2290,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2189:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2294


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: c4049cfc8a03 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.13.y-rt-rebase
head:   7e175e6b59975c8901ad370f7818937f68de45c1
commit: c4049cfc8a0327c22d56855882d8e2cffd6d20fa [11/222] printk: move console printing to kthreads
:::::: branch date: 19 hours ago
:::::: commit date: 19 hours ago

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2186,7 +2186,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	size_t len;
@@ -2291,7 +2290,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2195:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2300


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 44b90e30fdd3 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.12.y-rt-rebase
head:   2664a7f5d3d24da4b2657a1e933181d376b77616
commit: 44b90e30fdd3fbb4997b8d75679816678214efb5 [32/193] printk: move console printing to kthreads

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2192,7 +2192,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	size_t len;
@@ -2297,7 +2296,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

CC: kbuild-all(a)lists.01.org
TO: John Ogness <john.ogness@linutronix.de>
CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
CC: Petr Mladek <pmladek@suse.com>
CC: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2127:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2226


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 42afcbce7b62 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.11.y-rt-rebase
head:   4a7805e223e04660df86d5ca0d16f1acdd3c91eb
commit: 42afcbce7b62cd3e1bb00468ff150281d68dd8ee [34/184] printk: move console printing to kthreads
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago

Please take the patch only if it's a positive warning. Thanks!

 printk.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2124,7 +2124,6 @@ static int printk_kthread_func(void *dat
 	struct printk_record r;
 	char *ext_text = NULL;
 	size_t dropped_len;
-	int ret = -ENOMEM;
 	char *text = NULL;
 	char *write_text;
 	u64 printk_seq;
@@ -2223,7 +2222,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "",
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 /* Must be called within console_lock(). */

[PATCH] printk: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

CC: kbuild-all(a)lists.01.org
TO: John Ogness <john.ogness@linutronix.de>
CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

From: kernel test robot <lkp@intel.com>

kernel/printk/printk.c:2808:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2819


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: ca4fcaa60de9 ("printk: move console printing to kthreads")
CC: John Ogness <john.ogness@linutronix.de>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.10.y-rt-rebase
head:   87b7b3d2cb296950a0e3005406899ccfbbc9da7c
commit: ca4fcaa60de914c0ef6864983a8488bf5ab6cafb [57/209] printk: move console printing to kthreads
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 printk.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2805,7 +2805,6 @@ static int printk_kthread_func(void *dat
 	char *ext_text = NULL;
 	size_t dropped_len;
 	char *dropped_text;
-	int ret = -ENOMEM;
 	char *write_text;
 	u64 printk_seq;
 	size_t len;
@@ -2816,7 +2815,7 @@ static int printk_kthread_func(void *dat
 	if (con->flags & CON_EXTENDED) {
 		ext_text = kmalloc(CONSOLE_EXT_LOG_MAX, GFP_KERNEL);
 		if (!ext_text)
-			return ret;
+			return -ENOMEM;
 	}
 	text = kmalloc(LOG_LINE_MAX + PREFIX_MAX, GFP_KERNEL);
 	dropped_text = kmalloc(64, GFP_KERNEL);
@@ -2904,7 +2903,7 @@ out:
 	pr_info("%sconsole [%s%d]: printing thread stopped\n",
 		(con->flags & CON_BOOT) ? "boot" : "" ,
 		con->name, con->index);
-	return ret;
+	return -ENOMEM;
 }
 
 static void start_printk_kthread(struct console *con)