[Buildroot] buildroot packages from svn repo fail

[Buildroot] buildroot packages from svn repo fail

[Yann E. MORIN]

Henri, All,

Thanks for the reporton this svn issue.

On 2021-02-18 12:19 +0000, Roosen Henri spake thusly:
> Hi Yann,

Please do not write to individual contributors directly. Write to the
mailing list, so that everyon has a chance to learn about the issue,
provide feedback, suggest ways to resolve the issue, and so that
everyone can benefit from this.

By writing to the list, you also stand better chance that someone spots
the mail, in case the contributor is not available (like me this week, I
was unable to work on Buldroot dur to familly concerns).

> We use a custom kernel which is available using our internal svn-repo.
> The download now fails with the following:
> 
> tar: Time stamp is out of allowed range
> tar: Exiting with failure status due to previous errors
> 
> Reverting commit c043ecb20ce6ac316fe31da6d2db5b13a34dc414 fixes the problem.

As has been discovered by Vincent in the rest of this private thread,
the root cause seems to be the svn client you are using, that reports
sub-second timestamps, which are not supported by the PAX format we are
now using.

I'll be waiting for the patch from Vincent (or anyone else) to fix the
issue.

Also, as Arnout suggested, it would be nice to have a runtime test, like
we have for git;
    support/testing/tests/download/test_git.py

I don't think we need somethign totally exhaustive, but even just a
basic test would be enough (e.g. tests with svn:external are not a
requirement).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] buildroot packages from svn repo fail

[Yann E. MORIN]

Vincent, All,

(sorry for the duplicate, IO forgot to re-add the list in this reply)

On 2021-02-18 21:04 -0600, Vincent Fazio spake thusly:
> The fix may be as simple as:
> 
> diff --git a/support/download/svn b/support/download/svn
> index 839dccaf62..386507ecb5 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -52,6 +52,9 @@ _svn export ${verbose} "${@}" "'${uri}@${rev}'" "'${basename}'"
>  # last line (svn outputs everything on stdout)
>  date="$( _svn info --show-item last-changed-date "'${uri}@${rev}'" |tail -n 1 )"
> 
> +# Drop sub-second precision to play nice with tar's valid_timespec check
> +date="$(date -d "${date}" -uIseconds)"

This looks nice, but do you know how long 'date' has supported
sub-second precision in the input timestamp?

I think a more robust solution would be to sed-out the sub-second part,
and do that as a single command:

    date="$( _svn info --show-item last-changed-date "'${uri}@${rev}'" \
             |tail -n 1 \
             |sed -r -e 's/\.[[:digit:]]+//'
           )" 

Also, while testing this, I noticed that not all svn version support the
--show-item option. For example, the version I have on my autobuilder
does not support it:

    $ svn --version
    svn, version 1.8.8 (r1568071)
    [...]

    $ svn info --show-item last-changed-date svn://localhost:3690/foo
    svn: invalid option: --show-item

Maybe we should drop it, and revert to sed-ing the required field out
from the whole 'info output... Thoughts?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'