* [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
@ 2021-02-21 16:37 ` Amrit Khera
0 siblings, 0 replies; 6+ messages in thread
From: Amrit Khera @ 2021-02-21 16:37 UTC (permalink / raw)
To: gregkh, lee.jones, arnd, johannes, kuba, mail, memxor, rdunlap
Cc: devel, linux-kernel, Amrit Khera
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
---
Changes in v2:
- Removed the comment entirely, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/wimax/stack.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..345a022810ef 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
/*
* Authoritative source for the RE_STATE_CHANGE attribute policy
- *
- * We don't really use it here, but /me likes to keep the definition
- * close to where the data is generated.
*/
-/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
-
/*
* Allocate a Report State Change message
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
@ 2021-02-21 16:37 ` Amrit Khera
0 siblings, 0 replies; 6+ messages in thread
From: Amrit Khera @ 2021-02-21 16:37 UTC (permalink / raw)
To: gregkh, lee.jones, arnd, johannes, kuba, mail, memxor, rdunlap
Cc: devel, Amrit Khera, linux-kernel
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
---
Changes in v2:
- Removed the comment entirely, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/wimax/stack.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..345a022810ef 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
/*
* Authoritative source for the RE_STATE_CHANGE attribute policy
- *
- * We don't really use it here, but /me likes to keep the definition
- * close to where the data is generated.
*/
-/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
-
/*
* Allocate a Report State Change message
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
2021-02-21 16:37 ` Amrit Khera
@ 2021-02-21 18:09 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-02-21 18:09 UTC (permalink / raw)
To: Amrit Khera
Cc: lee.jones, arnd, johannes, kuba, mail, memxor, rdunlap, devel,
linux-kernel
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
That's not all this patch does, please be descriptive of what you really
do and why you are doing it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
@ 2021-02-21 18:09 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-02-21 18:09 UTC (permalink / raw)
To: Amrit Khera
Cc: devel, arnd, linux-kernel, mail, memxor, kuba, johannes, lee.jones
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "Block comments
> use * on subsequent lines".
That's not all this patch does, please be descriptive of what you really
do and why you are doing it.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
2021-02-21 16:37 ` Amrit Khera
@ 2021-02-22 6:15 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-02-22 6:15 UTC (permalink / raw)
To: Amrit Khera
Cc: gregkh, lee.jones, arnd, johannes, kuba, mail, memxor, rdunlap,
devel, linux-kernel
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..345a022810ef 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
>
> /*
> * Authoritative source for the RE_STATE_CHANGE attribute policy
Delete the whole comment. This sentence doesn't make any sense by
itself once we have removed the rest.
> - *
> - * We don't really use it here, but /me likes to keep the definition
> - * close to where the data is generated.
> */
> -/*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> - [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> - [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
@ 2021-02-22 6:15 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2021-02-22 6:15 UTC (permalink / raw)
To: Amrit Khera
Cc: devel, arnd, gregkh, linux-kernel, mail, memxor, kuba, johannes,
lee.jones
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..345a022810ef 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
>
> /*
> * Authoritative source for the RE_STATE_CHANGE attribute policy
Delete the whole comment. This sentence doesn't make any sense by
itself once we have removed the rest.
> - *
> - * We don't really use it here, but /me likes to keep the definition
> - * close to where the data is generated.
> */
> -/*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> - [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> - [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-22 6:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 16:37 [PATCH v2] staging: wimax: Fix block comment style issue in stack.c Amrit Khera
2021-02-21 16:37 ` Amrit Khera
2021-02-21 18:09 ` Greg KH
2021-02-21 18:09 ` Greg KH
2021-02-22 6:15 ` Dan Carpenter
2021-02-22 6:15 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.