All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: stefan@datenfreihafen.org
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey
Date: Sun, 21 Feb 2021 12:43:21 -0500	[thread overview]
Message-ID: <20210221174321.14210-4-aahringo@redhat.com> (raw)
In-Reply-To: <20210221174321.14210-1-aahringo@redhat.com>

This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is
not set by the user. If this is the case nl802154 will return -EINVAL.

Reported-by: syzbot+368672e0da240db53b5f@syzkaller.appspotmail.com
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 net/ieee802154/nl802154.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 3f6d86d63923..e9e4652cd592 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1916,7 +1916,8 @@ static int nl802154_del_llsec_devkey(struct sk_buff *skb, struct genl_info *info
 	struct ieee802154_llsec_device_key key;
 	__le64 extended_addr;
 
-	if (nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack))
+	if (!info->attrs[NL802154_ATTR_SEC_DEVKEY] ||
+	    nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack))
 		return -EINVAL;
 
 	if (!attrs[NL802154_DEVKEY_ATTR_EXTENDED_ADDR])
-- 
2.26.2


  parent reply	other threads:[~2021-02-21 17:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21 17:43 [PATCH wpan 1/4] net: ieee802154: fix nl802154 del llsec key Alexander Aring
2021-02-21 17:43 ` [PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev Alexander Aring
2021-02-24 13:37   ` Stefan Schmidt
2021-02-21 17:43 ` [PATCH wpan 3/4] net: ieee802154: fix nl802154 add llsec key Alexander Aring
2021-02-24 13:38   ` Stefan Schmidt
2021-02-21 17:43 ` Alexander Aring [this message]
2021-02-24 13:39   ` [PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey Stefan Schmidt
2021-02-24 13:39   ` Stefan Schmidt
2021-02-23 22:04 ` [PATCH wpan 1/4] net: ieee802154: fix nl802154 del llsec key Jakub Kicinski
2021-02-24 13:37 ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210221174321.14210-4-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.