Re: [PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev

From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Alexander Aring <aahringo@redhat.com>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev
Date: Wed, 24 Feb 2021 14:37:47 +0100	[thread overview]
Message-ID: <fc4b9036-6b68-24d0-13ed-ffd0b24ce79a@datenfreihafen.org> (raw)
In-Reply-To: <20210221174321.14210-2-aahringo@redhat.com>

Hello.

On 21.02.21 18:43, Alexander Aring wrote:
> This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is
> not set by the user. If this is the case nl802154 will return -EINVAL.
> 
> Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>   net/ieee802154/nl802154.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> index 2f0a138bd5eb..063b12cba71f 100644
> --- a/net/ieee802154/nl802154.c
> +++ b/net/ieee802154/nl802154.c
> @@ -1758,7 +1758,8 @@ static int nl802154_del_llsec_dev(struct sk_buff *skb, struct genl_info *info)
>   	struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1];
>   	__le64 extended_addr;
>   
> -	if (nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack))
> +	if (!info->attrs[NL802154_ATTR_SEC_DEVICE] ||
> +	    nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack))
>   		return -EINVAL;
>   
>   	if (!attrs[NL802154_DEV_ATTR_EXTENDED_ADDR])
> 

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt