* [PATCH v2] configure: fix --enable-fuzzing linker failures
@ 2021-02-21 17:45 Alexander Bulekov
2021-02-22 5:44 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexander Bulekov @ 2021-02-21 17:45 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, thuth, Li Qiang, f4bug, Alexander Bulekov, pbonzini
With --enable-fuzzing, QEMU_CFLAGS include -fsanitize=fuzzer-no-link.
This should allow us to build non-fuzzer binaries using objects
instrumented for fuzzing. However, to do that, we also need to link with
-fsanitize=fuzzer-no-link. We were not doing that.
Reported-by: Li Qiang <liq3ea@163.com>,
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
v2: Fix a mistake in the added QEMU_LDFLAGS line
configure | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/configure b/configure
index a79b3746d4..19f2b88589 100755
--- a/configure
+++ b/configure
@@ -6096,7 +6096,17 @@ if test "$fuzzing" = "yes" ; then
# If LIB_FUZZING_ENGINE is set, assume we are running on OSS-Fuzz, and the
# needed CFLAGS have already been provided
if test -z "${LIB_FUZZING_ENGINE+xxx}" ; then
+ # Add CFLAGS to tell clang to add fuzzer-related instrumentation to all the
+ # compiled code.
QEMU_CFLAGS="$QEMU_CFLAGS -fsanitize=fuzzer-no-link"
+ # To build non-fuzzer binaries with --enable-fuzzing, link everything with
+ # fsanitize=fuzzer-no-link. Otherwise, the linker will be unable to bind
+ # the fuzzer-related callbacks added by instrumentation.
+ QEMU_LDFLAGS="$QEMU_LDFLAGS -fsanitize=fuzzer-no-link"
+ # For the actual fuzzer binaries, we need to link against the libfuzzer
+ # library. Provide the flags for doing this in FUZZ_EXE_LDFLAGS. The meson
+ # rule for the fuzzer adds these to the link_args. They need to be
+ # configurable, to support OSS-Fuzz
FUZZ_EXE_LDFLAGS="-fsanitize=fuzzer"
else
FUZZ_EXE_LDFLAGS="$LIB_FUZZING_ENGINE"
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] configure: fix --enable-fuzzing linker failures
2021-02-21 17:45 [PATCH v2] configure: fix --enable-fuzzing linker failures Alexander Bulekov
@ 2021-02-22 5:44 ` Thomas Huth
2021-02-22 13:52 ` Li Qiang
2021-02-22 14:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-02-22 5:44 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel; +Cc: pbonzini, Li Qiang, f4bug, peter.maydell
On 21/02/2021 18.45, Alexander Bulekov wrote:
> With --enable-fuzzing, QEMU_CFLAGS include -fsanitize=fuzzer-no-link.
> This should allow us to build non-fuzzer binaries using objects
> instrumented for fuzzing. However, to do that, we also need to link with
> -fsanitize=fuzzer-no-link. We were not doing that.
>
> Reported-by: Li Qiang <liq3ea@163.com>,
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> v2: Fix a mistake in the added QEMU_LDFLAGS line
>
> configure | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index a79b3746d4..19f2b88589 100755
> --- a/configure
> +++ b/configure
> @@ -6096,7 +6096,17 @@ if test "$fuzzing" = "yes" ; then
> # If LIB_FUZZING_ENGINE is set, assume we are running on OSS-Fuzz, and the
> # needed CFLAGS have already been provided
> if test -z "${LIB_FUZZING_ENGINE+xxx}" ; then
> + # Add CFLAGS to tell clang to add fuzzer-related instrumentation to all the
> + # compiled code.
> QEMU_CFLAGS="$QEMU_CFLAGS -fsanitize=fuzzer-no-link"
> + # To build non-fuzzer binaries with --enable-fuzzing, link everything with
> + # fsanitize=fuzzer-no-link. Otherwise, the linker will be unable to bind
> + # the fuzzer-related callbacks added by instrumentation.
> + QEMU_LDFLAGS="$QEMU_LDFLAGS -fsanitize=fuzzer-no-link"
> + # For the actual fuzzer binaries, we need to link against the libfuzzer
> + # library. Provide the flags for doing this in FUZZ_EXE_LDFLAGS. The meson
> + # rule for the fuzzer adds these to the link_args. They need to be
> + # configurable, to support OSS-Fuzz
> FUZZ_EXE_LDFLAGS="-fsanitize=fuzzer"
> else
> FUZZ_EXE_LDFLAGS="$LIB_FUZZING_ENGINE"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] configure: fix --enable-fuzzing linker failures
2021-02-21 17:45 [PATCH v2] configure: fix --enable-fuzzing linker failures Alexander Bulekov
2021-02-22 5:44 ` Thomas Huth
@ 2021-02-22 13:52 ` Li Qiang
2021-02-22 14:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Li Qiang @ 2021-02-22 13:52 UTC (permalink / raw)
To: Alexander Bulekov
Cc: Peter Maydell, Thomas Huth, Li Qiang, Qemu Developers,
Philippe Mathieu-Daudé,
Paolo Bonzini
Alexander Bulekov <alxndr@bu.edu> 于2021年2月22日周一 上午1:48写道：
>
> With --enable-fuzzing, QEMU_CFLAGS include -fsanitize=fuzzer-no-link.
> This should allow us to build non-fuzzer binaries using objects
> instrumented for fuzzing. However, to do that, we also need to link with
> -fsanitize=fuzzer-no-link. We were not doing that.
>
> Reported-by: Li Qiang <liq3ea@163.com>,
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Tested-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> v2: Fix a mistake in the added QEMU_LDFLAGS line
>
> configure | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index a79b3746d4..19f2b88589 100755
> --- a/configure
> +++ b/configure
> @@ -6096,7 +6096,17 @@ if test "$fuzzing" = "yes" ; then
> # If LIB_FUZZING_ENGINE is set, assume we are running on OSS-Fuzz, and the
> # needed CFLAGS have already been provided
> if test -z "${LIB_FUZZING_ENGINE+xxx}" ; then
> + # Add CFLAGS to tell clang to add fuzzer-related instrumentation to all the
> + # compiled code.
> QEMU_CFLAGS="$QEMU_CFLAGS -fsanitize=fuzzer-no-link"
> + # To build non-fuzzer binaries with --enable-fuzzing, link everything with
> + # fsanitize=fuzzer-no-link. Otherwise, the linker will be unable to bind
> + # the fuzzer-related callbacks added by instrumentation.
> + QEMU_LDFLAGS="$QEMU_LDFLAGS -fsanitize=fuzzer-no-link"
> + # For the actual fuzzer binaries, we need to link against the libfuzzer
> + # library. Provide the flags for doing this in FUZZ_EXE_LDFLAGS. The meson
> + # rule for the fuzzer adds these to the link_args. They need to be
> + # configurable, to support OSS-Fuzz
> FUZZ_EXE_LDFLAGS="-fsanitize=fuzzer"
> else
> FUZZ_EXE_LDFLAGS="$LIB_FUZZING_ENGINE"
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] configure: fix --enable-fuzzing linker failures
2021-02-21 17:45 [PATCH v2] configure: fix --enable-fuzzing linker failures Alexander Bulekov
2021-02-22 5:44 ` Thomas Huth
2021-02-22 13:52 ` Li Qiang
@ 2021-02-22 14:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-02-22 14:10 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel; +Cc: peter.maydell, thuth, Li Qiang, f4bug
On 21/02/21 18:45, Alexander Bulekov wrote:
> With --enable-fuzzing, QEMU_CFLAGS include -fsanitize=fuzzer-no-link.
> This should allow us to build non-fuzzer binaries using objects
> instrumented for fuzzing. However, to do that, we also need to link with
> -fsanitize=fuzzer-no-link. We were not doing that.
>
> Reported-by: Li Qiang <liq3ea@163.com>,
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> v2: Fix a mistake in the added QEMU_LDFLAGS line
>
> configure | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/configure b/configure
> index a79b3746d4..19f2b88589 100755
> --- a/configure
> +++ b/configure
> @@ -6096,7 +6096,17 @@ if test "$fuzzing" = "yes" ; then
> # If LIB_FUZZING_ENGINE is set, assume we are running on OSS-Fuzz, and the
> # needed CFLAGS have already been provided
> if test -z "${LIB_FUZZING_ENGINE+xxx}" ; then
> + # Add CFLAGS to tell clang to add fuzzer-related instrumentation to all the
> + # compiled code.
> QEMU_CFLAGS="$QEMU_CFLAGS -fsanitize=fuzzer-no-link"
> + # To build non-fuzzer binaries with --enable-fuzzing, link everything with
> + # fsanitize=fuzzer-no-link. Otherwise, the linker will be unable to bind
> + # the fuzzer-related callbacks added by instrumentation.
> + QEMU_LDFLAGS="$QEMU_LDFLAGS -fsanitize=fuzzer-no-link"
> + # For the actual fuzzer binaries, we need to link against the libfuzzer
> + # library. Provide the flags for doing this in FUZZ_EXE_LDFLAGS. The meson
> + # rule for the fuzzer adds these to the link_args. They need to be
> + # configurable, to support OSS-Fuzz
> FUZZ_EXE_LDFLAGS="-fsanitize=fuzzer"
> else
> FUZZ_EXE_LDFLAGS="$LIB_FUZZING_ENGINE"
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 14:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 17:45 [PATCH v2] configure: fix --enable-fuzzing linker failures Alexander Bulekov
2021-02-22 5:44 ` Thomas Huth
2021-02-22 13:52 ` Li Qiang
2021-02-22 14:10 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.