All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Huang Pei <huangpei@loongson.cn>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	ambrosehua@gmail.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Bibo Mao <maobibo@loongson.cn>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-mips@vger.kernel.org, linux-arch@vger.kernel.org,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Paul Burton <paulburton@kernel.org>,
	Li Xuefeng <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: clean up CONFIG_MIPS_PGD_CONTEXT handling
Date: Sun, 21 Feb 2021 19:19:26 +0800	[thread overview]
Message-ID: <202102211947.zSMGb1s3-lkp@intel.com> (raw)
In-Reply-To: <20210221022659.24146-1-huangpei@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 5714 bytes --]

Hi Huang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11 next-20210219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huang-Pei/MIPS-clean-up-CONFIG_MIPS_PGD_CONTEXT-handling/20210221-102942
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f40ddce88593482919761f74910f42f4b84c004b
config: mips-randconfig-r021-20210221 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/e9601358443c6579f0fb63deee9a172d2bd03c57
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huang-Pei/MIPS-clean-up-CONFIG_MIPS_PGD_CONTEXT-handling/20210221-102942
        git checkout e9601358443c6579f0fb63deee9a172d2bd03c57
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/mips/mm/tlbex.c:1168:37: warning: shift count >= width of type [-Wshift-count-overflow]
                   uasm_i_ori(p, ptr, ptr, (CAC_BASE >> 53));
                                                     ^  ~~
   arch/mips/mm/tlbex.c:2605:6: warning: no previous prototype for function 'build_tlb_refill_handler' [-Wmissing-prototypes]
   void build_tlb_refill_handler(void)
        ^
   arch/mips/mm/tlbex.c:2605:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void build_tlb_refill_handler(void)
   ^
   static 
   arch/mips/mm/tlbex.c:185:1: warning: unused function 'uasm_l_second_part' [-Wunused-function]
   UASM_L_LA(_second_part)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:46:1: note: expanded from here
   uasm_l_second_part
   ^
   arch/mips/mm/tlbex.c:192:1: warning: unused function 'uasm_l_tlbl_goaround2' [-Wunused-function]
   UASM_L_LA(_tlbl_goaround2)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:58:1: note: expanded from here
   uasm_l_tlbl_goaround2
   ^
   arch/mips/mm/tlbex.c:196:1: warning: unused function 'uasm_l_smp_pgtable_change' [-Wunused-function]
   UASM_L_LA(_smp_pgtable_change)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:66:1: note: expanded from here
   uasm_l_smp_pgtable_change
   ^
   5 warnings generated.


vim +1168 arch/mips/mm/tlbex.c

  1108	
  1109	static struct mips_huge_tlb_info
  1110	build_fast_tlb_refill_handler (u32 **p, struct uasm_label **l,
  1111				       struct uasm_reloc **r, unsigned int tmp,
  1112				       unsigned int ptr, int c0_scratch_reg)
  1113	{
  1114		struct mips_huge_tlb_info rv;
  1115		unsigned int even, odd;
  1116		int vmalloc_branch_delay_filled = 0;
  1117		const int scratch = 1; /* Our extra working register */
  1118	
  1119		rv.huge_pte = scratch;
  1120		rv.restore_scratch = 0;
  1121		rv.need_reload_pte = false;
  1122	
  1123		if (check_for_high_segbits) {
  1124			UASM_i_MFC0(p, tmp, C0_BADVADDR);
  1125	
  1126			if (pgd_reg != -1)
  1127				UASM_i_MFC0(p, ptr, c0_kscratch(), pgd_reg);
  1128			else
  1129				UASM_i_MFC0(p, ptr, C0_CONTEXT);
  1130	
  1131			if (c0_scratch_reg >= 0)
  1132				UASM_i_MTC0(p, scratch, c0_kscratch(), c0_scratch_reg);
  1133			else
  1134				UASM_i_SW(p, scratch, scratchpad_offset(0), 0);
  1135	
  1136			uasm_i_dsrl_safe(p, scratch, tmp,
  1137					 PGDIR_SHIFT + PGD_ORDER + PAGE_SHIFT - 3);
  1138			uasm_il_bnez(p, r, scratch, label_vmalloc);
  1139	
  1140			if (pgd_reg == -1) {
  1141				vmalloc_branch_delay_filled = 1;
  1142				/* Clear lower 23 bits of context. */
  1143				uasm_i_dins(p, ptr, 0, 0, 23);
  1144			}
  1145		} else {
  1146			if (pgd_reg != -1)
  1147				UASM_i_MFC0(p, ptr, c0_kscratch(), pgd_reg);
  1148			else
  1149				UASM_i_MFC0(p, ptr, C0_CONTEXT);
  1150	
  1151			UASM_i_MFC0(p, tmp, C0_BADVADDR);
  1152	
  1153			if (c0_scratch_reg >= 0)
  1154				UASM_i_MTC0(p, scratch, c0_kscratch(), c0_scratch_reg);
  1155			else
  1156				UASM_i_SW(p, scratch, scratchpad_offset(0), 0);
  1157	
  1158			if (pgd_reg == -1)
  1159				/* Clear lower 23 bits of context. */
  1160				uasm_i_dins(p, ptr, 0, 0, 23);
  1161	
  1162			uasm_il_bltz(p, r, tmp, label_vmalloc);
  1163		}
  1164	
  1165		if (pgd_reg == -1) {
  1166			vmalloc_branch_delay_filled = 1;
  1167			/* insert bit[63:59] of CAC_BASE into bit[11:6] of ptr */
> 1168			uasm_i_ori(p, ptr, ptr, (CAC_BASE >> 53));
  1169			uasm_i_drotr(p, ptr, ptr, 11);
  1170		}
  1171	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28710 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] MIPS: clean up CONFIG_MIPS_PGD_CONTEXT handling
Date: Sun, 21 Feb 2021 19:19:26 +0800	[thread overview]
Message-ID: <202102211947.zSMGb1s3-lkp@intel.com> (raw)
In-Reply-To: <20210221022659.24146-1-huangpei@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 5857 bytes --]

Hi Huang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11 next-20210219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huang-Pei/MIPS-clean-up-CONFIG_MIPS_PGD_CONTEXT-handling/20210221-102942
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f40ddce88593482919761f74910f42f4b84c004b
config: mips-randconfig-r021-20210221 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/e9601358443c6579f0fb63deee9a172d2bd03c57
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huang-Pei/MIPS-clean-up-CONFIG_MIPS_PGD_CONTEXT-handling/20210221-102942
        git checkout e9601358443c6579f0fb63deee9a172d2bd03c57
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/mips/mm/tlbex.c:1168:37: warning: shift count >= width of type [-Wshift-count-overflow]
                   uasm_i_ori(p, ptr, ptr, (CAC_BASE >> 53));
                                                     ^  ~~
   arch/mips/mm/tlbex.c:2605:6: warning: no previous prototype for function 'build_tlb_refill_handler' [-Wmissing-prototypes]
   void build_tlb_refill_handler(void)
        ^
   arch/mips/mm/tlbex.c:2605:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void build_tlb_refill_handler(void)
   ^
   static 
   arch/mips/mm/tlbex.c:185:1: warning: unused function 'uasm_l_second_part' [-Wunused-function]
   UASM_L_LA(_second_part)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:46:1: note: expanded from here
   uasm_l_second_part
   ^
   arch/mips/mm/tlbex.c:192:1: warning: unused function 'uasm_l_tlbl_goaround2' [-Wunused-function]
   UASM_L_LA(_tlbl_goaround2)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:58:1: note: expanded from here
   uasm_l_tlbl_goaround2
   ^
   arch/mips/mm/tlbex.c:196:1: warning: unused function 'uasm_l_smp_pgtable_change' [-Wunused-function]
   UASM_L_LA(_smp_pgtable_change)
   ^
   arch/mips/include/asm/uasm.h:204:20: note: expanded from macro 'UASM_L_LA'
   static inline void uasm_l##lb(struct uasm_label **lab, u32 *addr)       \
                      ^
   <scratch space>:66:1: note: expanded from here
   uasm_l_smp_pgtable_change
   ^
   5 warnings generated.


vim +1168 arch/mips/mm/tlbex.c

  1108	
  1109	static struct mips_huge_tlb_info
  1110	build_fast_tlb_refill_handler (u32 **p, struct uasm_label **l,
  1111				       struct uasm_reloc **r, unsigned int tmp,
  1112				       unsigned int ptr, int c0_scratch_reg)
  1113	{
  1114		struct mips_huge_tlb_info rv;
  1115		unsigned int even, odd;
  1116		int vmalloc_branch_delay_filled = 0;
  1117		const int scratch = 1; /* Our extra working register */
  1118	
  1119		rv.huge_pte = scratch;
  1120		rv.restore_scratch = 0;
  1121		rv.need_reload_pte = false;
  1122	
  1123		if (check_for_high_segbits) {
  1124			UASM_i_MFC0(p, tmp, C0_BADVADDR);
  1125	
  1126			if (pgd_reg != -1)
  1127				UASM_i_MFC0(p, ptr, c0_kscratch(), pgd_reg);
  1128			else
  1129				UASM_i_MFC0(p, ptr, C0_CONTEXT);
  1130	
  1131			if (c0_scratch_reg >= 0)
  1132				UASM_i_MTC0(p, scratch, c0_kscratch(), c0_scratch_reg);
  1133			else
  1134				UASM_i_SW(p, scratch, scratchpad_offset(0), 0);
  1135	
  1136			uasm_i_dsrl_safe(p, scratch, tmp,
  1137					 PGDIR_SHIFT + PGD_ORDER + PAGE_SHIFT - 3);
  1138			uasm_il_bnez(p, r, scratch, label_vmalloc);
  1139	
  1140			if (pgd_reg == -1) {
  1141				vmalloc_branch_delay_filled = 1;
  1142				/* Clear lower 23 bits of context. */
  1143				uasm_i_dins(p, ptr, 0, 0, 23);
  1144			}
  1145		} else {
  1146			if (pgd_reg != -1)
  1147				UASM_i_MFC0(p, ptr, c0_kscratch(), pgd_reg);
  1148			else
  1149				UASM_i_MFC0(p, ptr, C0_CONTEXT);
  1150	
  1151			UASM_i_MFC0(p, tmp, C0_BADVADDR);
  1152	
  1153			if (c0_scratch_reg >= 0)
  1154				UASM_i_MTC0(p, scratch, c0_kscratch(), c0_scratch_reg);
  1155			else
  1156				UASM_i_SW(p, scratch, scratchpad_offset(0), 0);
  1157	
  1158			if (pgd_reg == -1)
  1159				/* Clear lower 23 bits of context. */
  1160				uasm_i_dins(p, ptr, 0, 0, 23);
  1161	
  1162			uasm_il_bltz(p, r, tmp, label_vmalloc);
  1163		}
  1164	
  1165		if (pgd_reg == -1) {
  1166			vmalloc_branch_delay_filled = 1;
  1167			/* insert bit[63:59] of CAC_BASE into bit[11:6] of ptr */
> 1168			uasm_i_ori(p, ptr, ptr, (CAC_BASE >> 53));
  1169			uasm_i_drotr(p, ptr, ptr, 11);
  1170		}
  1171	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28710 bytes --]

  reply	other threads:[~2021-02-21 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21  2:26 [PATCH] MIPS: clean up CONFIG_MIPS_PGD_CONTEXT handling Huang Pei
2021-02-21 11:19 ` kernel test robot [this message]
2021-02-21 11:19   ` kernel test robot
2021-02-22  2:27   ` 黄沛
  -- strict thread matches above, loose matches on Subject: below --
2021-02-20  6:51 Huang Pei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102211947.zSMGb1s3-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ambrosehua@gmail.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=huangpei@loongson.cn \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lixuefeng@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=paulburton@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.