* [PATCH] i2c/busses:remove unneeded variable: "ret"
@ 2021-02-23 2:09 ` dingsenjie
0 siblings, 0 replies; 6+ messages in thread
From: dingsenjie @ 2021-02-23 2:09 UTC (permalink / raw)
To: brendanhiggins, benh, joel, andrew, openbmc, linux-arm-kernel,
linux-aspeed
Cc: linux-i2c, linux-kernel, dingsenjie
From: dingsenjie <dingsenjie@yulong.com>
remove unneeded variable: "ret".
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
drivers/i2c/busses/i2c-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 724bf30..efad900 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
{
unsigned long time_left, flags;
- int ret = 0;
u32 command;
spin_lock_irqsave(&bus->lock, flags);
@@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
out:
spin_unlock_irqrestore(&bus->lock, flags);
- return ret;
+ return 0;
reset_out:
spin_unlock_irqrestore(&bus->lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] i2c/busses:remove unneeded variable: "ret"
@ 2021-02-23 2:09 ` dingsenjie
0 siblings, 0 replies; 6+ messages in thread
From: dingsenjie @ 2021-02-23 2:09 UTC (permalink / raw)
To: brendanhiggins, benh, joel, andrew, openbmc, linux-arm-kernel,
linux-aspeed
Cc: dingsenjie, linux-i2c, linux-kernel
From: dingsenjie <dingsenjie@yulong.com>
remove unneeded variable: "ret".
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
drivers/i2c/busses/i2c-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 724bf30..efad900 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
{
unsigned long time_left, flags;
- int ret = 0;
u32 command;
spin_lock_irqsave(&bus->lock, flags);
@@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
out:
spin_unlock_irqrestore(&bus->lock, flags);
- return ret;
+ return 0;
reset_out:
spin_unlock_irqrestore(&bus->lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] i2c/busses:remove unneeded variable: "ret"
@ 2021-02-23 2:09 ` dingsenjie
0 siblings, 0 replies; 6+ messages in thread
From: dingsenjie @ 2021-02-23 2:09 UTC (permalink / raw)
To: brendanhiggins, benh, joel, andrew, openbmc, linux-arm-kernel,
linux-aspeed
Cc: dingsenjie, linux-i2c, linux-kernel
From: dingsenjie <dingsenjie@yulong.com>
remove unneeded variable: "ret".
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
drivers/i2c/busses/i2c-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 724bf30..efad900 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
{
unsigned long time_left, flags;
- int ret = 0;
u32 command;
spin_lock_irqsave(&bus->lock, flags);
@@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
out:
spin_unlock_irqrestore(&bus->lock, flags);
- return ret;
+ return 0;
reset_out:
spin_unlock_irqrestore(&bus->lock, flags);
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c/busses:remove unneeded variable: "ret"
2021-02-23 2:09 ` dingsenjie
(?)
@ 2021-02-23 11:18 ` Joel Stanley
-1 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2021-02-23 11:18 UTC (permalink / raw)
To: dingsenjie
Cc: Brendan Higgins, Benjamin Herrenschmidt, Andrew Jeffery,
OpenBMC Maillist, Linux ARM, linux-aspeed, linux-i2c,
Linux Kernel Mailing List, dingsenjie
On Tue, 23 Feb 2021 at 08:04, <dingsenjie@163.com> wrote:
>
> From: dingsenjie <dingsenjie@yulong.com>
>
> remove unneeded variable: "ret".
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
Thanks for the patch. Instead of removing the unused variable, I think
the code could be improved to return error codes when the recovery
fails.
Cheers,
Joel
> ---
> drivers/i2c/busses/i2c-aspeed.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 724bf30..efad900 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
> static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> {
> unsigned long time_left, flags;
> - int ret = 0;
> u32 command;
>
> spin_lock_irqsave(&bus->lock, flags);
> @@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> out:
> spin_unlock_irqrestore(&bus->lock, flags);
>
> - return ret;
> + return 0;
>
> reset_out:
> spin_unlock_irqrestore(&bus->lock, flags);
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c/busses:remove unneeded variable: "ret"
@ 2021-02-23 11:18 ` Joel Stanley
0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2021-02-23 11:18 UTC (permalink / raw)
To: dingsenjie
Cc: linux-aspeed, Andrew Jeffery, OpenBMC Maillist, Brendan Higgins,
Linux Kernel Mailing List, dingsenjie, linux-i2c, Linux ARM
On Tue, 23 Feb 2021 at 08:04, <dingsenjie@163.com> wrote:
>
> From: dingsenjie <dingsenjie@yulong.com>
>
> remove unneeded variable: "ret".
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
Thanks for the patch. Instead of removing the unused variable, I think
the code could be improved to return error codes when the recovery
fails.
Cheers,
Joel
> ---
> drivers/i2c/busses/i2c-aspeed.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 724bf30..efad900 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
> static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> {
> unsigned long time_left, flags;
> - int ret = 0;
> u32 command;
>
> spin_lock_irqsave(&bus->lock, flags);
> @@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> out:
> spin_unlock_irqrestore(&bus->lock, flags);
>
> - return ret;
> + return 0;
>
> reset_out:
> spin_unlock_irqrestore(&bus->lock, flags);
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c/busses:remove unneeded variable: "ret"
@ 2021-02-23 11:18 ` Joel Stanley
0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2021-02-23 11:18 UTC (permalink / raw)
To: dingsenjie
Cc: linux-aspeed, Andrew Jeffery, Benjamin Herrenschmidt,
OpenBMC Maillist, Brendan Higgins, Linux Kernel Mailing List,
dingsenjie, linux-i2c, Linux ARM
On Tue, 23 Feb 2021 at 08:04, <dingsenjie@163.com> wrote:
>
> From: dingsenjie <dingsenjie@yulong.com>
>
> remove unneeded variable: "ret".
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
Thanks for the patch. Instead of removing the unused variable, I think
the code could be improved to return error codes when the recovery
fails.
Cheers,
Joel
> ---
> drivers/i2c/busses/i2c-aspeed.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 724bf30..efad900 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -175,7 +175,6 @@ struct aspeed_i2c_bus {
> static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> {
> unsigned long time_left, flags;
> - int ret = 0;
> u32 command;
>
> spin_lock_irqsave(&bus->lock, flags);
> @@ -232,7 +231,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)
> out:
> spin_unlock_irqrestore(&bus->lock, flags);
>
> - return ret;
> + return 0;
>
> reset_out:
> spin_unlock_irqrestore(&bus->lock, flags);
> --
> 1.9.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-23 11:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 2:09 [PATCH] i2c/busses:remove unneeded variable: "ret" dingsenjie
2021-02-23 2:09 ` dingsenjie
2021-02-23 2:09 ` dingsenjie
2021-02-23 11:18 ` Joel Stanley
2021-02-23 11:18 ` Joel Stanley
2021-02-23 11:18 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.