* [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4
@ 2021-02-23 8:25 Andrej Valek
2021-02-23 15:29 ` akuster
0 siblings, 1 reply; 5+ messages in thread
From: Andrej Valek @ 2021-02-23 8:25 UTC (permalink / raw)
To: openembedded-devel; +Cc: Andrej Valek
- do not install obj files
Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
---
.../recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
rename meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} (82%)
diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
similarity index 82%
rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
index e41907de4..a02ff4a4d 100644
--- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
+++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
@@ -13,13 +13,13 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
PE = "1"
-SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
+SRCREV = "9059f5cad030ba11d37818847443a53918c327b1"
SRC_URI = "git://github.com/open-source-parsers/jsoncpp"
S = "${WORKDIR}/git"
inherit cmake
-EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DJSONCPP_WITH_TESTS=OFF"
+EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DBUILD_OBJECT_LIBS=OFF -DJSONCPP_WITH_TESTS=OFF"
BBCLASSEXTEND = "native"
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4
2021-02-23 8:25 [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4 Andrej Valek
@ 2021-02-23 15:29 ` akuster
2021-02-24 9:03 ` Andrej Valek
0 siblings, 1 reply; 5+ messages in thread
From: akuster @ 2021-02-23 15:29 UTC (permalink / raw)
To: openembedded-devel
On 2/23/21 12:25 AM, Andrej Valek wrote:
> - do not install obj files
What kind of update is this.
What problem is not install obj fixing?
These changes are not in Master.
-armin
>
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> ---
> .../recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> rename meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} (82%)
>
> diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
> similarity index 82%
> rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
> rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
> index e41907de4..a02ff4a4d 100644
> --- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
> +++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
> @@ -13,13 +13,13 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
>
> PE = "1"
>
> -SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
> +SRCREV = "9059f5cad030ba11d37818847443a53918c327b1"
> SRC_URI = "git://github.com/open-source-parsers/jsoncpp"
>
> S = "${WORKDIR}/git"
>
> inherit cmake
>
> -EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DJSONCPP_WITH_TESTS=OFF"
> +EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DBUILD_OBJECT_LIBS=OFF -DJSONCPP_WITH_TESTS=OFF"
>
> BBCLASSEXTEND = "native"
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4
2021-02-23 15:29 ` akuster
@ 2021-02-24 9:03 ` Andrej Valek
2021-03-03 9:35 ` Andrej Valek
2021-03-07 16:11 ` akuster
0 siblings, 2 replies; 5+ messages in thread
From: Andrej Valek @ 2021-02-24 9:03 UTC (permalink / raw)
To: akuster; +Cc: openembedded-devel
Hi Armin
Regarding to OBJS_LIBS, it was added here https://github.com/open-source-parsers/jsoncpp/pull/1197/ . But why to install it? Aren't the headers and libs enough? Previous versions don't have this "feature".
Regarding to adding into dunfell/master. I wanted to ask if it's possible to add it also into dunfel + master branch. If not, then I have to search for security fixes only for dunfell branch.
Regards,
Andrej
>> - do not install obj files
> What kind of update is this.
>
> What problem is not install obj fixing?
>
> These changes are not in Master.
>
> -armin
>>
>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>> ---
>> .../recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-) rename
>> meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb =>
>> jsoncpp_1.9.4.bb} (82%)
>>
>> diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>> b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>> similarity index 82%
>> rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>> rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>> index e41907de4..a02ff4a4d 100644
>> --- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>> +++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>> @@ -13,13 +13,13 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
>>
>> PE = "1"
>>
>> -SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
>> +SRCREV = "9059f5cad030ba11d37818847443a53918c327b1"
>> SRC_URI = "git://github.com/open-source-parsers/jsoncpp"
>>
>> S = "${WORKDIR}/git"
>>
>> inherit cmake
>>
>> -EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DJSONCPP_WITH_TESTS=OFF"
>> +EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DBUILD_OBJECT_LIBS=OFF -DJSONCPP_WITH_TESTS=OFF"
>>
>> BBCLASSEXTEND = "native"
>>
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4
2021-02-24 9:03 ` Andrej Valek
@ 2021-03-03 9:35 ` Andrej Valek
2021-03-07 16:11 ` akuster
1 sibling, 0 replies; 5+ messages in thread
From: Andrej Valek @ 2021-03-03 9:35 UTC (permalink / raw)
To: akuster; +Cc: openembedded-devel
Hi Armin,
Did you have some time to look at that?
Regards,
Andrej
> Hi Armin
>
> Regarding to OBJS_LIBS, it was added here https://github.com/open-source-parsers/jsoncpp/pull/1197/ . But why to install it? Aren't the headers and libs enough? Previous versions don't have this "feature".
>
>Regarding to adding into dunfell/master. I wanted to ask if it's possible to add it also into dunfel + master branch. If not, then I have to search for security fixes only for dunfell branch.
>
> Regards,
> Andrej
>
>>> - do not install obj files
>> What kind of update is this.
>>
>> What problem is not install obj fixing?
>>
>> These changes are not in Master.
>>
>> -armin
>>>
>>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>>> ---
>>> .../recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-) rename
>>> meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb =>
>>> jsoncpp_1.9.4.bb} (82%)
>>>
>>> diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> similarity index 82%
>>> rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> index e41907de4..a02ff4a4d 100644
>>> --- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> +++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> @@ -13,13 +13,13 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
>>>
>>> PE = "1"
>>>
>>> -SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
>>> +SRCREV = "9059f5cad030ba11d37818847443a53918c327b1"
>>> SRC_URI = "git://github.com/open-source-parsers/jsoncpp"
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> inherit cmake
>>>
>>> -EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DJSONCPP_WITH_TESTS=OFF"
>>> +EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DBUILD_OBJECT_LIBS=OFF -DJSONCPP_WITH_TESTS=OFF"
>>>
>>> BBCLASSEXTEND = "native"
>>>
>>>
>>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4
2021-02-24 9:03 ` Andrej Valek
2021-03-03 9:35 ` Andrej Valek
@ 2021-03-07 16:11 ` akuster
1 sibling, 0 replies; 5+ messages in thread
From: akuster @ 2021-03-07 16:11 UTC (permalink / raw)
To: Valek, Andrej; +Cc: openembedded-devel
Andrej,
On 2/24/21 1:03 AM, Valek, Andrej wrote:
> Hi Armin
>
> Regarding to OBJS_LIBS, it was added here https://github.com/open-source-parsers/jsoncpp/pull/1197/ . But why to install it? Aren't the headers and libs enough? Previous versions don't have this "feature".
>
> Regarding to adding into dunfell/master. I wanted to ask if it's possible to add it also into dunfel + master branch. If not, then I have to search for security fixes only for dunfell branch.
The upgrade to 1.9.3 was reverted back in July 2020 do to ABI changes so
will not be taking this update. See commit:
https://git.openembedded.org/meta-openembedded/commit/meta-oe?h=dunfell&id=0e0b4892f50808b87223a1e8dbcd13d4e16368cf
Master is @ 1.9.3 so this patch could apply to Master.
-armin
> Regards,
> Andrej
>
>>> - do not install obj files
>> What kind of update is this.
>>
>> What problem is not install obj fixing?
>>
>> These changes are not in Master.
>>
>> -armin
>>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>>> ---
>>> .../recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb => jsoncpp_1.9.4.bb} | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-) rename
>>> meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.3.bb =>
>>> jsoncpp_1.9.4.bb} (82%)
>>>
>>> diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> similarity index 82%
>>> rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> index e41907de4..a02ff4a4d 100644
>>> --- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>> +++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.4.bb
>>> @@ -13,13 +13,13 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
>>>
>>> PE = "1"
>>>
>>> -SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
>>> +SRCREV = "9059f5cad030ba11d37818847443a53918c327b1"
>>> SRC_URI = "git://github.com/open-source-parsers/jsoncpp"
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> inherit cmake
>>>
>>> -EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DJSONCPP_WITH_TESTS=OFF"
>>> +EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON -DBUILD_OBJECT_LIBS=OFF -DJSONCPP_WITH_TESTS=OFF"
>>>
>>> BBCLASSEXTEND = "native"
>>>
>>>
>>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-07 16:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 8:25 [oe][meta-oe][dunfell][PATCH] jsoncpp: Upgrade to 1.9.4 Andrej Valek
2021-02-23 15:29 ` akuster
2021-02-24 9:03 ` Andrej Valek
2021-03-03 9:35 ` Andrej Valek
2021-03-07 16:11 ` akuster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.