[PATCH v1] KVM: arm64: make the hyp vector table entries local

[PATCH v1] KVM: arm64: make the hyp vector table entries local

[Joey Gouly]

Make the hyp vector table entries local functions so they
are not accidentally referred to outside of this file.

Using SYM_CODE_START_LOCAL matches the other vector tables (in hyp-stub.S,
hibernate-asm.S and entry.S)

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
 arch/arm64/kvm/hyp/hyp-entry.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S
index d179056e1af8..5f49df4ffdd8 100644
--- a/arch/arm64/kvm/hyp/hyp-entry.S
+++ b/arch/arm64/kvm/hyp/hyp-entry.S
@@ -119,7 +119,7 @@ el2_error:
 
 .macro invalid_vector	label, target = __guest_exit_panic
 	.align	2
-SYM_CODE_START(\label)
+SYM_CODE_START_LOCAL(\label)
 	b \target
 SYM_CODE_END(\label)
 .endm
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1] KVM: arm64: make the hyp vector table entries local

[Will Deacon]

On Mon, Feb 22, 2021 at 04:49:56PM +0000, Joey Gouly wrote:
> Make the hyp vector table entries local functions so they
> are not accidentally referred to outside of this file.
> 
> Using SYM_CODE_START_LOCAL matches the other vector tables (in hyp-stub.S,
> hibernate-asm.S and entry.S)
> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>  arch/arm64/kvm/hyp/hyp-entry.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/hyp-entry.S b/arch/arm64/kvm/hyp/hyp-entry.S
> index d179056e1af8..5f49df4ffdd8 100644
> --- a/arch/arm64/kvm/hyp/hyp-entry.S
> +++ b/arch/arm64/kvm/hyp/hyp-entry.S
> @@ -119,7 +119,7 @@ el2_error:
>  
>  .macro invalid_vector	label, target = __guest_exit_panic
>  	.align	2
> -SYM_CODE_START(\label)
> +SYM_CODE_START_LOCAL(\label)
>  	b \target
>  SYM_CODE_END(\label)
>  .endm

Acked-by: Will Deacon <will@kernel.org>

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1] KVM: arm64: make the hyp vector table entries local

[Marc Zyngier]

On Mon, 22 Feb 2021 16:49:56 +0000,
Joey Gouly <joey.gouly@arm.com> wrote:
> 
> Make the hyp vector table entries local functions so they
> are not accidentally referred to outside of this file.
> 
> Using SYM_CODE_START_LOCAL matches the other vector tables (in hyp-stub.S,
> hibernate-asm.S and entry.S)
> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>

Acked-by: Marc Zyngier <maz@kernel.org>

Will, if you can queue this with some of the other arm64 fixes, that'd
be good (I don't have much to send yet).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v1] KVM: arm64: make the hyp vector table entries local

[Will Deacon]

On Mon, 22 Feb 2021 16:49:56 +0000, Joey Gouly wrote:
> Make the hyp vector table entries local functions so they
> are not accidentally referred to outside of this file.
> 
> Using SYM_CODE_START_LOCAL matches the other vector tables (in hyp-stub.S,
> hibernate-asm.S and entry.S)

Applied to arm64 (for-next/fixes), thanks!

[1/1] KVM: arm64: make the hyp vector table entries local
      https://git.kernel.org/arm64/c/610e4dc8ac46

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel