* [PATCH net] atl1c: switch to napi_gro_receive
@ 2021-02-22 1:40 Sieng Piaw Liew
2021-02-23 23:43 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Sieng Piaw Liew @ 2021-02-22 1:40 UTC (permalink / raw)
To: chris.snook; +Cc: davem, kuba, netdev, linux-kernel, Sieng Piaw Liew
Changing to napi_gro_receive() improves efficiency significantly. Tested
on Intel Core2-based motherboards and iperf3.
Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 3f65f2b370c5..3e440c2dc68a 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -1851,7 +1851,7 @@ static void atl1c_clean_rx_irq(struct atl1c_adapter *adapter,
vlan = le16_to_cpu(vlan);
__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan);
}
- netif_receive_skb(skb);
+ napi_gro_receive(&adapter->napi, skb);
(*work_done)++;
count++;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] atl1c: switch to napi_gro_receive
2021-02-22 1:40 [PATCH net] atl1c: switch to napi_gro_receive Sieng Piaw Liew
@ 2021-02-23 23:43 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-02-23 23:43 UTC (permalink / raw)
To: Sieng Piaw Liew; +Cc: chris.snook, davem, netdev, linux-kernel
On Mon, 22 Feb 2021 09:40:45 +0800 Sieng Piaw Liew wrote:
> Changing to napi_gro_receive() improves efficiency significantly. Tested
> on Intel Core2-based motherboards and iperf3.
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
net-next is currently closed (see the note below). Would you mind
resending this change in a week or two?
# Form letter - net-next is closed
We have already sent the networking pull request for 5.12 and therefore
net-next is closed for new drivers, features, code refactoring and
optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after 5.12-rc1 is cut.
Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html
RFC patches sent for review only are obviously welcome at any time.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-24 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 1:40 [PATCH net] atl1c: switch to napi_gro_receive Sieng Piaw Liew
2021-02-23 23:43 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.