From: Vivek Goyal <vgoyal@redhat.com> To: qemu-devel@nongnu.org, virtio-fs@redhat.com Cc: lhenriques@suse.de, stefanha@redhat.com, dgilbert@redhat.com, vgoyal@redhat.com, miklos@szeredi.hu Subject: [PATCH v4 0/3] virtiofsd: Add support to enable/disable posix acls Date: Wed, 24 Feb 2021 11:58:34 -0500 [thread overview] Message-ID: <20210224165837.21983-1-vgoyal@redhat.com> (raw) Hi, This is V4 of patches. In V3 I enabled posix_acl by default. Then I tested with cache=none and a simple "cat foo.txt" results in two extra GETXATTR(system.posix_acl) calls. (Note, this happens only if caller is not owner of file). And this happens on every call of "cat foo.txt" because cache=none does not cache anything in guest. So this make me rethink the idea of enabling posix_acl by default. I prefer not to have any performance regressions in any of the mode out of the box. Hence proposing this V4 where posix_acls are disabled by default and user needs to enable it explicitly if the want posix acls. This probably can change down the line once somebody can prove enabling it by deafult really does not impact us much. Change since V3. - Do not enable posix_acl by default. - Error out if user wants to enable it but xattr are disabled. - Modified help message and docs/tools/virtiofsd.rst to add documentation for this new knob (Luis Henriques). - Captured Reviewed-by tags from Stefan from V3. Thanks Vivek Vivek Goyal (3): virtiofsd: Add umask to seccom allow list virtiofsd: Add capability to change/restore umask virtiofsd: Add an option to enable/disable posix acls docs/tools/virtiofsd.rst | 3 + tools/virtiofsd/helper.c | 1 + tools/virtiofsd/passthrough_ll.c | 125 ++++++++++++++++++++++++-- tools/virtiofsd/passthrough_seccomp.c | 1 + 4 files changed, 123 insertions(+), 7 deletions(-) -- 2.25.4
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: qemu-devel@nongnu.org, virtio-fs@redhat.com Cc: vgoyal@redhat.com, miklos@szeredi.hu Subject: [Virtio-fs] [PATCH v4 0/3] virtiofsd: Add support to enable/disable posix acls Date: Wed, 24 Feb 2021 11:58:34 -0500 [thread overview] Message-ID: <20210224165837.21983-1-vgoyal@redhat.com> (raw) Hi, This is V4 of patches. In V3 I enabled posix_acl by default. Then I tested with cache=none and a simple "cat foo.txt" results in two extra GETXATTR(system.posix_acl) calls. (Note, this happens only if caller is not owner of file). And this happens on every call of "cat foo.txt" because cache=none does not cache anything in guest. So this make me rethink the idea of enabling posix_acl by default. I prefer not to have any performance regressions in any of the mode out of the box. Hence proposing this V4 where posix_acls are disabled by default and user needs to enable it explicitly if the want posix acls. This probably can change down the line once somebody can prove enabling it by deafult really does not impact us much. Change since V3. - Do not enable posix_acl by default. - Error out if user wants to enable it but xattr are disabled. - Modified help message and docs/tools/virtiofsd.rst to add documentation for this new knob (Luis Henriques). - Captured Reviewed-by tags from Stefan from V3. Thanks Vivek Vivek Goyal (3): virtiofsd: Add umask to seccom allow list virtiofsd: Add capability to change/restore umask virtiofsd: Add an option to enable/disable posix acls docs/tools/virtiofsd.rst | 3 + tools/virtiofsd/helper.c | 1 + tools/virtiofsd/passthrough_ll.c | 125 ++++++++++++++++++++++++-- tools/virtiofsd/passthrough_seccomp.c | 1 + 4 files changed, 123 insertions(+), 7 deletions(-) -- 2.25.4
next reply other threads:[~2021-02-24 17:10 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-24 16:58 Vivek Goyal [this message] 2021-02-24 16:58 ` [Virtio-fs] [PATCH v4 0/3] virtiofsd: Add support to enable/disable posix acls Vivek Goyal 2021-02-24 16:58 ` [PATCH v4 1/3] virtiofsd: Add umask to seccom allow list Vivek Goyal 2021-02-24 16:58 ` [Virtio-fs] " Vivek Goyal 2021-02-24 16:58 ` [PATCH v4 2/3] virtiofsd: Add capability to change/restore umask Vivek Goyal 2021-02-24 16:58 ` [Virtio-fs] " Vivek Goyal 2021-02-24 16:58 ` [PATCH v4 3/3] virtiofsd: Add an option to enable/disable posix acls Vivek Goyal 2021-02-24 16:58 ` [Virtio-fs] " Vivek Goyal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210224165837.21983-1-vgoyal@redhat.com \ --to=vgoyal@redhat.com \ --cc=dgilbert@redhat.com \ --cc=lhenriques@suse.de \ --cc=miklos@szeredi.hu \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.