* [PATCH] certs: select PKCS7_MESSAGE_PARSER if needed
@ 2021-02-25 12:56 Arnd Bergmann
2021-02-25 14:12 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2021-02-25 12:56 UTC (permalink / raw)
To: David Howells, David Woodhouse, Eric Snowberg, Jarkko Sakkinen
Cc: Arnd Bergmann, keyrings, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When CONFIG_SYSTEM_BLACKLIST_KEYRING and CONFIG_INTEGRITY_PLATFORM_KEYRING
are both enabled, the system blacklist tries calling the
pkcs7_validate_trust() function, causing a link failure if the driver
that defines it is disabled or a loadable module:
ld.lld: error: undefined symbol: pkcs7_validate_trust
>>> referenced by blacklist.c
>>> blacklist.o:(is_key_on_revocation_list) in archive certs/built-in.a
Add a Kconfig 'select' statement for this specific case that force-
enables the pkcs7 code as well.
Fixes: 30fdba3f40fd ("certs: Add EFI_CERT_X509_GUID support for dbx entries")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
certs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/certs/Kconfig b/certs/Kconfig
index 379a6e198459..21192bb25c79 100644
--- a/certs/Kconfig
+++ b/certs/Kconfig
@@ -68,6 +68,7 @@ config SECONDARY_TRUSTED_KEYRING
config SYSTEM_BLACKLIST_KEYRING
bool "Provide system-wide ring of blacklisted keys"
depends on KEYS
+ select PKCS7_MESSAGE_PARSER if INTEGRITY_PLATFORM_KEYRING
help
Provide a system keyring to which blacklisted keys can be added.
Keys in the keyring are considered entirely untrusted. Keys in this
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] certs: select PKCS7_MESSAGE_PARSER if needed
2021-02-25 12:56 [PATCH] certs: select PKCS7_MESSAGE_PARSER if needed Arnd Bergmann
@ 2021-02-25 14:12 ` David Howells
2021-02-25 14:32 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2021-02-25 14:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: dhowells, David Woodhouse, Eric Snowberg, Jarkko Sakkinen,
Arnd Bergmann, keyrings, linux-kernel
Arnd Bergmann <arnd@kernel.org> wrote:
> + select PKCS7_MESSAGE_PARSER if INTEGRITY_PLATFORM_KEYRING
I think a better way to do it is to add a separate config option for dealing
with revocation certs, which is part of what I suggested here:
https://lore.kernel.org/keyrings/3731128.1614163916@warthog.procyon.org.uk/
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] certs: select PKCS7_MESSAGE_PARSER if needed
2021-02-25 14:12 ` David Howells
@ 2021-02-25 14:32 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-02-25 14:32 UTC (permalink / raw)
To: David Howells
Cc: David Woodhouse, Eric Snowberg, Jarkko Sakkinen, Arnd Bergmann,
keyrings, linux-kernel
On Thu, Feb 25, 2021 at 3:12 PM David Howells <dhowells@redhat.com> wrote:
>
> Arnd Bergmann <arnd@kernel.org> wrote:
>
> > + select PKCS7_MESSAGE_PARSER if INTEGRITY_PLATFORM_KEYRING
>
> I think a better way to do it is to add a separate config option for dealing
> with revocation certs, which is part of what I suggested here:
>
> https://lore.kernel.org/keyrings/3731128.1614163916@warthog.procyon.org.uk/
Ok, sounds good. Can this make it into v5.12 though, or do we need an
intermediate
fix to avoid the build failure?
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 12:56 [PATCH] certs: select PKCS7_MESSAGE_PARSER if needed Arnd Bergmann
2021-02-25 14:12 ` David Howells
2021-02-25 14:32 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.