* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman @ 2021-02-25 20:50 Marek Vasut 2021-04-24 12:56 ` Marek Vasut 2021-05-02 11:43 ` stefano.babic at babic.homelinux.org 0 siblings, 2 replies; 8+ messages in thread From: Marek Vasut @ 2021-02-25 20:50 UTC (permalink / raw) To: u-boot In case binman is enabled, the u-boot.itb is generated using this tool and there is no direct u-boot.itb target, but instead the binman tool must be invoked. Add support for this case. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Peng Fan <peng.fan@nxp.com> Cc: Stefano Babic <sbabic@denx.de> --- Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 079881b62ab..a0456dd5859 100644 --- a/Makefile +++ b/Makefile @@ -1542,10 +1542,16 @@ u-boot.cnt: u-boot.bin FORCE flash.bin: spl/u-boot-spl.bin u-boot.cnt FORCE $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@ else +ifeq ($(CONFIG_BINMAN),y) +flash.bin: spl/u-boot-spl.bin $(INPUTS-y) FORCE + $(call if_changed,binman) + $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@ +else flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@ endif endif +endif u-boot-with-spl.imx u-boot-with-nand-spl.imx: SPL u-boot.bin FORCE $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@ -- 2.30.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-02-25 20:50 [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman Marek Vasut @ 2021-04-24 12:56 ` Marek Vasut 2021-04-29 23:11 ` Bin Meng 2021-05-02 11:43 ` stefano.babic at babic.homelinux.org 1 sibling, 1 reply; 8+ messages in thread From: Marek Vasut @ 2021-04-24 12:56 UTC (permalink / raw) To: u-boot On 2/25/21 9:50 PM, Marek Vasut wrote: > In case binman is enabled, the u-boot.itb is generated using this tool > and there is no direct u-boot.itb target, but instead the binman tool > must be invoked. Add support for this case. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> This bugfix is still missing from upstream. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-04-24 12:56 ` Marek Vasut @ 2021-04-29 23:11 ` Bin Meng 2021-04-30 18:13 ` Simon Glass 0 siblings, 1 reply; 8+ messages in thread From: Bin Meng @ 2021-04-29 23:11 UTC (permalink / raw) To: u-boot On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex@denx.de> wrote: > > On 2/25/21 9:50 PM, Marek Vasut wrote: > > In case binman is enabled, the u-boot.itb is generated using this tool > > and there is no direct u-boot.itb target, but instead the binman tool > > must be invoked. Add support for this case. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Peng Fan <peng.fan@nxp.com> > > Cc: Stefano Babic <sbabic@denx.de> > > This bugfix is still missing from upstream. + Simon ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-04-29 23:11 ` Bin Meng @ 2021-04-30 18:13 ` Simon Glass 2021-04-30 18:47 ` Marek Vasut 0 siblings, 1 reply; 8+ messages in thread From: Simon Glass @ 2021-04-30 18:13 UTC (permalink / raw) To: u-boot Hi, On Thu, 29 Apr 2021 at 17:11, Bin Meng <bmeng.cn@gmail.com> wrote: > > On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex@denx.de> wrote: > > > > On 2/25/21 9:50 PM, Marek Vasut wrote: > > > In case binman is enabled, the u-boot.itb is generated using this tool > > > and there is no direct u-boot.itb target, but instead the binman tool > > > must be invoked. Add support for this case. > > > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > > Cc: Peng Fan <peng.fan@nxp.com> > > > Cc: Stefano Babic <sbabic@denx.de> > > > > This bugfix is still missing from upstream. It seems to be missing a Fixes tag? I can't really comment on this particular patch as it is up to MX8 what is done here. But a much better solution is to move this generation stuff to binman, instead of all the arch-specific Makefile rules. Regards, Simon ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-04-30 18:13 ` Simon Glass @ 2021-04-30 18:47 ` Marek Vasut 2021-04-30 18:52 ` Simon Glass 0 siblings, 1 reply; 8+ messages in thread From: Marek Vasut @ 2021-04-30 18:47 UTC (permalink / raw) To: u-boot On 4/30/21 8:13 PM, Simon Glass wrote: > Hi, Hello Simon, > On Thu, 29 Apr 2021 at 17:11, Bin Meng <bmeng.cn@gmail.com> wrote: >> >> On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex@denx.de> wrote: >>> >>> On 2/25/21 9:50 PM, Marek Vasut wrote: >>>> In case binman is enabled, the u-boot.itb is generated using this tool >>>> and there is no direct u-boot.itb target, but instead the binman tool >>>> must be invoked. Add support for this case. >>>> >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> Cc: Peng Fan <peng.fan@nxp.com> >>>> Cc: Stefano Babic <sbabic@denx.de> >>> >>> This bugfix is still missing from upstream. > > It seems to be missing a Fixes tag? There are way too many commits related to this to identify specific one. > I can't really comment on this particular patch as it is up to MX8 > what is done here. In that case, deciding on this bugfix is up to the maintainer, Stefano. > But a much better solution is to move this generation stuff to binman, > instead of all the arch-specific Makefile rules. Feel free to submit subsequent patch, but this bug should be fixed first, improvements can go in later. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-04-30 18:47 ` Marek Vasut @ 2021-04-30 18:52 ` Simon Glass 2021-05-02 9:57 ` Stefano Babic 0 siblings, 1 reply; 8+ messages in thread From: Simon Glass @ 2021-04-30 18:52 UTC (permalink / raw) To: u-boot Hi Marek, On Fri, 30 Apr 2021 at 11:47, Marek Vasut <marex@denx.de> wrote: > > On 4/30/21 8:13 PM, Simon Glass wrote: > > Hi, > > Hello Simon, > > > On Thu, 29 Apr 2021 at 17:11, Bin Meng <bmeng.cn@gmail.com> wrote: > >> > >> On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex@denx.de> wrote: > >>> > >>> On 2/25/21 9:50 PM, Marek Vasut wrote: > >>>> In case binman is enabled, the u-boot.itb is generated using this tool > >>>> and there is no direct u-boot.itb target, but instead the binman tool > >>>> must be invoked. Add support for this case. > >>>> > >>>> Signed-off-by: Marek Vasut <marex@denx.de> > >>>> Cc: Peng Fan <peng.fan@nxp.com> > >>>> Cc: Stefano Babic <sbabic@denx.de> > >>> > >>> This bugfix is still missing from upstream. > > > > It seems to be missing a Fixes tag? > > There are way too many commits related to this to identify specific one. Sure, I was suggesting why it had not been picked up for the release. > > > I can't really comment on this particular patch as it is up to MX8 > > what is done here. > > In that case, deciding on this bugfix is up to the maintainer, Stefano. > > > But a much better solution is to move this generation stuff to binman, > > instead of all the arch-specific Makefile rules. > > Feel free to submit subsequent patch, but this bug should be fixed > first, improvements can go in later. Yes indeed. It looks like the maintainers are on this thread so they should be able to pick it up. Regards, Simon ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-04-30 18:52 ` Simon Glass @ 2021-05-02 9:57 ` Stefano Babic 0 siblings, 0 replies; 8+ messages in thread From: Stefano Babic @ 2021-05-02 9:57 UTC (permalink / raw) To: u-boot Hi Marek, On 30.04.21 20:52, Simon Glass wrote: > Hi Marek, > > On Fri, 30 Apr 2021 at 11:47, Marek Vasut <marex@denx.de> wrote: >> >> On 4/30/21 8:13 PM, Simon Glass wrote: >>> Hi, >> >> Hello Simon, >> >>> On Thu, 29 Apr 2021 at 17:11, Bin Meng <bmeng.cn@gmail.com> wrote: >>>> >>>> On Sat, Apr 24, 2021 at 8:57 PM Marek Vasut <marex@denx.de> wrote: >>>>> >>>>> On 2/25/21 9:50 PM, Marek Vasut wrote: >>>>>> In case binman is enabled, the u-boot.itb is generated using this tool >>>>>> and there is no direct u-boot.itb target, but instead the binman tool >>>>>> must be invoked. Add support for this case. >>>>>> >>>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>>> Cc: Peng Fan <peng.fan@nxp.com> >>>>>> Cc: Stefano Babic <sbabic@denx.de> >>>>> >>>>> This bugfix is still missing from upstream. >>> >>> It seems to be missing a Fixes tag? >> >> There are way too many commits related to this to identify specific one. > > Sure, I was suggesting why it had not been picked up for the release. > >> >>> I can't really comment on this particular patch as it is up to MX8 >>> what is done here. >> >> In that case, deciding on this bugfix is up to the maintainer, Stefano. >> >>> But a much better solution is to move this generation stuff to binman, >>> instead of all the arch-specific Makefile rules. >> >> Feel free to submit subsequent patch, but this bug should be fixed >> first, improvements can go in later. > > Yes indeed. It looks like the maintainers are on this thread so they > should be able to pick it up. Not sure if this was related to i.MX because it changes the main Makefile, but I admit I do not remember anymore if I have already merged and I found an issue or I have not seen and I ignored. I pick it up and I run CI. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman 2021-02-25 20:50 [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman Marek Vasut 2021-04-24 12:56 ` Marek Vasut @ 2021-05-02 11:43 ` stefano.babic at babic.homelinux.org 1 sibling, 0 replies; 8+ messages in thread From: stefano.babic at babic.homelinux.org @ 2021-05-02 11:43 UTC (permalink / raw) To: u-boot > In case binman is enabled, the u-boot.itb is generated using this tool > and there is no direct u-boot.itb target, but instead the binman tool > must be invoked. Add support for this case. > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-02 11:43 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-25 20:50 [PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman Marek Vasut 2021-04-24 12:56 ` Marek Vasut 2021-04-29 23:11 ` Bin Meng 2021-04-30 18:13 ` Simon Glass 2021-04-30 18:47 ` Marek Vasut 2021-04-30 18:52 ` Simon Glass 2021-05-02 9:57 ` Stefano Babic 2021-05-02 11:43 ` stefano.babic at babic.homelinux.org
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.