All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2] xfs: initialise attr fork on inode create
Date: Fri, 26 Feb 2021 16:01:58 +1100	[thread overview]
Message-ID: <20210226050158.GW4662@dread.disaster.area> (raw)
In-Reply-To: <20210225232153.GM7272@magnolia>

On Thu, Feb 25, 2021 at 03:21:53PM -0800, Darrick J. Wong wrote:
> On Tue, Feb 23, 2021 at 10:05:56AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >  STATIC int
> >  xfs_generic_create(
> >  	struct inode	*dir,
> > @@ -161,7 +192,9 @@ xfs_generic_create(
> >  		goto out_free_acl;
> >  
> >  	if (!tmpfile) {
> > -		error = xfs_create(XFS_I(dir), &name, mode, rdev, &ip);
> > +		error = xfs_create(XFS_I(dir), &name, mode, rdev,
> > +				xfs_create_need_xattr(dir, default_acl, acl),
> > +				&ip);
> >  	} else {
> >  		error = xfs_create_tmpfile(XFS_I(dir), mode, &ip);
> 
> Same question as last time: Do selinux or smack want to set xattr-based
> security labels on tempfiles too?

I think they do, but nobody has ever indicated that O_TMPFILE
creation to to be performance critical. Until someone comes to me
and says "concurrent O_TMPFILE creation at scale is really important
to our workload", I'm largely ignoring scalability issues for
tmpfile creation. Especially because AGI locks and the unlinked list
manipulations are the bottleneck here, not xattr creation....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

      reply	other threads:[~2021-02-26  5:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 23:05 [PATCH V2] xfs: initialise attr fork on inode create Dave Chinner
2021-02-23 18:22 ` Allison Henderson
2021-02-25  8:09 ` Christoph Hellwig
2021-02-25 20:32   ` Dave Chinner
2021-02-25 23:17     ` Darrick J. Wong
2021-02-25 23:21 ` Darrick J. Wong
2021-02-26  5:01   ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226050158.GW4662@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.