From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH v4 00/13] error: Do compile-time format string checking on grub_error
Date: Sat, 27 Feb 2021 13:19:17 +0100 [thread overview]
Message-ID: <20210227121917.wz7mxdb2znin4pt6@tomti.i.net-space.pl> (raw)
In-Reply-To: <cover.1613700218.git.development@efficientek.com>
On Thu, Feb 18, 2021 at 08:47:01PM -0600, Glenn Washburn wrote:
> This patch series fixes all compile errors due to format string issues on
> grub_error. This was tested against nearly all supported platforms
> successfully. This is important because earlier versions of these changes
> compiled successfully on x86 platforms, but had issues on other ones not
> tested.
Could you give examples what kind of errors you get when you build
non-x86 platforms?
> All patches except the last fix actual format string issues. The last patch
> turns format string issues into errors. This is a good idea because it will
> help to prevent introducing new format string issues into the code. Since, I
> presume, Daniel does not do not do a build test for all architectures before
> committing to master, this will not ensure that no format string issues get
> introduced into the code. However, it should flush out any format string
I am confused by these sentence. Anyway, I do build tests of all patches
before committing for all architectures which I am aware of. I think
difference between our results come from difference in build
environments, flags and options to do tests.
> issues when the CI build is done.
>
> Many of these changes are fairly obvious. I tried to use the PRI*GRUB_*_T
> macros as much as I could and to not cast arguments. There are some notable
> exceptions. There is some code that uses the same grub_error code in both
> 32 and 64 bit architectures (riscv), so casting was needed to force the larger
> storage type. The second to last patch for zfs is still confounding to me
> as to why the macro PRIuGRUB_UINT64_T was not expanding to llu, and yet the
> compiler was saying the argument was a long long unsigned.
For all the patches except #12 Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Though I will probably do not get #13 until #12 is updated and merged.
Daniel
next prev parent reply other threads:[~2021-02-27 12:19 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 2:47 [PATCH v4 00/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 01/13] misc: Format string for grub_error should be a literal Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 02/13] error: grub_error missing format string argument Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 03/13] error: grub_error format string add missing format code Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 04/13] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 06/13] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 07/13] efi: Format string error in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 08/13] error: Use %p format code for pointer types Glenn Washburn
2021-02-27 11:43 ` Daniel Kiper
2021-02-28 20:02 ` Glenn Washburn
2021-03-03 18:05 ` Daniel Kiper
2021-02-19 2:47 ` [PATCH v4 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-02-27 11:48 ` Daniel Kiper
2021-02-28 20:13 ` Glenn Washburn
2021-03-03 18:09 ` Daniel Kiper
2021-02-19 2:47 ` [PATCH v4 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-02-27 12:05 ` Daniel Kiper
2021-02-28 21:10 ` Glenn Washburn
2021-03-03 18:17 ` Daniel Kiper
2021-03-04 0:46 ` Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 13/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-02-27 12:19 ` Daniel Kiper [this message]
2021-02-28 20:31 ` [PATCH v4 00/13] " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 01/13] misc: Format string for grub_error should be a literal Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 02/13] error: grub_error missing format string argument Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 03/13] error: grub_error format string add missing format code Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 04/13] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 06/13] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 07/13] efi: Format string error in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 08/13] error: Use PRI* macros to get correct format string code across architectures Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 12/13] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-03-04 17:59 ` Daniel Kiper
2021-03-04 22:50 ` Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 13/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 00/14] error: Do compile-time format string checking on grub> Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 01/14] misc: Format string for grub_error should be a literal Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 02/14] error: grub_error missing format string argument Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 03/14] error: grub_error format string add missing format code Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 04/14] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 05/14] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 06/14] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 07/14] efi: Format string error in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 08/14] error: Use PRI* macros to get correct format string code across architectures Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 09/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 10/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 11/14] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 12/14] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 13/14] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 14/14] zfs: Use grub_uint64_t instead of 1ULL in BF64_*CODE macros Glenn Washburn
2021-03-05 16:27 ` [PATCH v6 00/14] error: Do compile-time format string checking on grub> Daniel Kiper
2021-03-05 23:15 ` Glenn Washburn
2021-03-06 6:59 ` Threading of patch series (was: [PATCH v6 00/14] error: Do compile-time format string checking on grub>) Paul Menzel
2021-03-07 21:00 ` Glenn Washburn
2021-03-09 21:04 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227121917.wz7mxdb2znin4pt6@tomti.i.net-space.pl \
--to=dkiper@net-space.pl \
--cc=development@efficientek.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.