From: Glenn Washburn <development@efficientek.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error
Date: Wed, 3 Mar 2021 18:46:26 -0600 [thread overview]
Message-ID: <20210303184626.1dc2768f@crass-HP-ZBook-15-G2> (raw)
In-Reply-To: <20210303181731.oqxbgiy7itr6b3hk@tomti.i.net-space.pl>
On Wed, 3 Mar 2021 19:17:31 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Sun, Feb 28, 2021 at 03:10:52PM -0600, Glenn Washburn wrote:
> > On Sat, 27 Feb 2021 13:05:09 +0100
> > Daniel Kiper <dkiper@net-space.pl> wrote:
> >
> > > On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote:
> > > > For some reason PRIuGRUB_UINT64_T is not expanding to llu, but
> > > > to lu, which causes the format string check to fail. Use
> > > > literal and force cast until this is debugged.
> > >
> > > I think the problem is that currently BF64_DECODE() uses "1ULL". I
> > > think it should look like this
> > >
> > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low),
> > > ((grub_uint64_t) 1) << (len))
> > >
> > > instead of
> > >
> > > #define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), 1ULL <<
> > > (len))
> > >
> > > Same or similar for other macros there.
> > >
> > > I would prefer if you fix macros in include/grub/zfs/spa.h first
> > > and then do proper fix here.
> >
> > Yep, completely agree, just hadn't figured out a proper solution.
> > And not being familiar with the code and not doing the zfs
> > functional tests (GitLab CI shared runners do not have zfs kernel
> > support), I'm hesitant to make such intrusive changes. However,
> > your suggestion is the better way to do it and I've confirmed that
> > it work on i386 and x86_64. I'll update the patch in the next patch
> > series.
>
> I am still afraid doing that before release until we are able to
> confirm that everything works for 32-bit and 64-bit architectures. If
> not I would not merge this patch and next one at this point.
Is there anyone here that can do this testing?
I does seem a little ridiculous that patch #13 would be blocked by zfs,
since its generally useful for the whole code base. My presumption
based on experience here is that if I'm not here to keep pushing for
#13, it will get forgotten about. This is why I'd like to get it in
now. Patch #12 may not be ideal, but its certainly an improvement. I
think it makes sense to include it for now, so that #13 can be
merged. Then at a later date when zfs testing can be done, the better
fix can be done.
Glenn
next prev parent reply other threads:[~2021-03-04 0:46 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 2:47 [PATCH v4 00/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 01/13] misc: Format string for grub_error should be a literal Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 02/13] error: grub_error missing format string argument Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 03/13] error: grub_error format string add missing format code Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 04/13] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 06/13] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 07/13] efi: Format string error in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 08/13] error: Use %p format code for pointer types Glenn Washburn
2021-02-27 11:43 ` Daniel Kiper
2021-02-28 20:02 ` Glenn Washburn
2021-03-03 18:05 ` Daniel Kiper
2021-02-19 2:47 ` [PATCH v4 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-02-27 11:48 ` Daniel Kiper
2021-02-28 20:13 ` Glenn Washburn
2021-03-03 18:09 ` Daniel Kiper
2021-02-19 2:47 ` [PATCH v4 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-02-19 2:47 ` [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-02-27 12:05 ` Daniel Kiper
2021-02-28 21:10 ` Glenn Washburn
2021-03-03 18:17 ` Daniel Kiper
2021-03-04 0:46 ` Glenn Washburn [this message]
2021-02-19 2:47 ` [PATCH v4 13/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-02-27 12:19 ` [PATCH v4 00/13] " Daniel Kiper
2021-02-28 20:31 ` Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 01/13] misc: Format string for grub_error should be a literal Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 02/13] error: grub_error missing format string argument Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 03/13] error: grub_error format string add missing format code Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 04/13] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 06/13] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 07/13] efi: Format string error in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 08/13] error: Use PRI* macros to get correct format string code across architectures Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 12/13] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-03-04 17:59 ` Daniel Kiper
2021-03-04 22:50 ` Glenn Washburn
2021-03-04 1:29 ` [PATCH v5 13/13] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 00/14] error: Do compile-time format string checking on grub> Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 01/14] misc: Format string for grub_error should be a literal Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 02/14] error: grub_error missing format string argument Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 03/14] error: grub_error format string add missing format code Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 04/14] dmraid_nvidia: Format string error in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 05/14] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 06/14] pgp: Format code for grub_error is incorrect Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 07/14] efi: Format string error in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 08/14] error: Use PRI* macros to get correct format string code across architectures Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 09/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 10/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 11/14] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 12/14] error: Use format code llu for 64-bit uint bp->blk_prop " Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 13/14] error: Do compile-time format string checking on grub_error Glenn Washburn
2021-03-05 0:22 ` [PATCH v6 14/14] zfs: Use grub_uint64_t instead of 1ULL in BF64_*CODE macros Glenn Washburn
2021-03-05 16:27 ` [PATCH v6 00/14] error: Do compile-time format string checking on grub> Daniel Kiper
2021-03-05 23:15 ` Glenn Washburn
2021-03-06 6:59 ` Threading of patch series (was: [PATCH v6 00/14] error: Do compile-time format string checking on grub>) Paul Menzel
2021-03-07 21:00 ` Glenn Washburn
2021-03-09 21:04 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303184626.1dc2768f@crass-HP-ZBook-15-G2 \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.