All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/leds/blink/leds-lgm-sso.c:845 intel_sso_led_probe() warn: 'priv->gclk' not released on lines: 803.
@ 2021-02-27 22:28 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-02-27 22:28 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7219 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
CC: Pavel Machek <pavel@ucw.cz>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
commit: c3987cd2bca34ddfec69027acedb2fae5ffcf7a0 leds: lgm: Add LED controller driver for LGM SoC
date:   9 days ago
:::::: branch date: 6 hours ago
:::::: commit date: 9 days ago
config: x86_64-randconfig-m001-20210228 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/leds/blink/leds-lgm-sso.c:845 intel_sso_led_probe() warn: 'priv->gclk' not released on lines: 803.

vim +845 drivers/leds/blink/leds-lgm-sso.c

c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  773  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  774  static int intel_sso_led_probe(struct platform_device *pdev)
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  775  {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  776  	struct device *dev = &pdev->dev;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  777  	struct sso_led_priv *priv;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  778  	int ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  779  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  780  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  781  	if (!priv)
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  782  		return -ENOMEM;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  783  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  784  	priv->pdev = pdev;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  785  	priv->dev = dev;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  786  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  787  	/* gate clock */
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  788  	priv->gclk = devm_clk_get(dev, "sso");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  789  	if (IS_ERR(priv->gclk)) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  790  		dev_err(dev, "get sso gate clock failed!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  791  		return PTR_ERR(priv->gclk);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  792  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  793  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  794  	ret = clk_prepare_enable(priv->gclk);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  795  	if (ret) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  796  		dev_err(dev, "Failed to prepate/enable sso gate clock!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  797  		return ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  798  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  799  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  800  	priv->fpid_clk = devm_clk_get(dev, "fpid");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  801  	if (IS_ERR(priv->fpid_clk)) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  802  		dev_err(dev, "Failed to get fpid clock!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  803  		return PTR_ERR(priv->fpid_clk);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  804  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  805  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  806  	ret = clk_prepare_enable(priv->fpid_clk);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  807  	if (ret) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  808  		dev_err(dev, "Failed to prepare/enable fpid clock!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  809  		return ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  810  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  811  	priv->fpid_clkrate = clk_get_rate(priv->fpid_clk);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  812  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  813  	ret = devm_add_action_or_reset(dev, sso_clk_disable, priv);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  814  	if (ret) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  815  		dev_err(dev, "Failed to devm_add_action_or_reset, %d\n", ret);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  816  		return ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  817  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  818  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  819  	priv->mmap = syscon_node_to_regmap(dev->of_node);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  820  	if (IS_ERR(priv->mmap)) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  821  		dev_err(dev, "Failed to map iomem!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  822  		return PTR_ERR(priv->mmap);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  823  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  824  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  825  	ret = sso_probe_gpios(priv);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  826  	if (ret) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  827  		regmap_exit(priv->mmap);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  828  		return ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  829  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  830  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  831  	INIT_LIST_HEAD(&priv->led_list);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  832  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  833  	platform_set_drvdata(pdev, priv);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  834  	sso_init_freq(priv);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  835  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  836  	priv->gptc_clkrate = DEF_GPTC_CLK_RATE;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  837  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  838  	ret = sso_led_dt_parse(priv);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  839  	if (ret) {
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  840  		regmap_exit(priv->mmap);
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  841  		return ret;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  842  	}
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  843  	dev_info(priv->dev, "sso LED init success!\n");
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  844  
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10 @845  	return 0;
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  846  }
c3987cd2bca34d Amireddy Mallikarjuna reddy 2020-12-10  847  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42136 bytes --]

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-02-27 22:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 22:28 drivers/leds/blink/leds-lgm-sso.c:845 intel_sso_led_probe() warn: 'priv->gclk' not released on lines: 803 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.