All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
@ 2021-02-24  8:54 dingsenjie
  2021-03-01 14:21   ` Mark Brown
  2021-03-01 23:34   ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: dingsenjie @ 2021-02-24  8:54 UTC (permalink / raw)
  To: perex, tiwai, lgirdwood, broonie; +Cc: alsa-devel, linux-kernel, dingsenjie

From: dingsenjie <dingsenjie@yulong.com>

Simplify the return expression in the aio-cpu.c.

Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
 sound/soc/uniphier/aio-cpu.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c
index 25c40c2..cf98141 100644
--- a/sound/soc/uniphier/aio-cpu.c
+++ b/sound/soc/uniphier/aio-cpu.c
@@ -256,17 +256,12 @@ static int uniphier_aio_startup(struct snd_pcm_substream *substream,
 {
 	struct uniphier_aio *aio = uniphier_priv(dai);
 	struct uniphier_aio_sub *sub = &aio->sub[substream->stream];
-	int ret;
 
 	sub->substream = substream;
 	sub->pass_through = 0;
 	sub->use_mmap = true;
 
-	ret = aio_init(sub);
-	if (ret)
-		return ret;
-
-	return 0;
+	return aio_init(sub);
 }
 
 static void uniphier_aio_shutdown(struct snd_pcm_substream *substream,
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
  2021-02-24  8:54 [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup dingsenjie
@ 2021-03-01 14:21   ` Mark Brown
  2021-03-01 23:34   ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-01 14:21 UTC (permalink / raw)
  To: dingsenjie; +Cc: perex, tiwai, lgirdwood, alsa-devel, linux-kernel, dingsenjie

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

On Wed, Feb 24, 2021 at 04:54:07PM +0800, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
> 
> Simplify the return expression in the aio-cpu.c.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
@ 2021-03-01 14:21   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-01 14:21 UTC (permalink / raw)
  To: dingsenjie; +Cc: alsa-devel, linux-kernel, lgirdwood, tiwai, dingsenjie

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

On Wed, Feb 24, 2021 at 04:54:07PM +0800, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
> 
> Simplify the return expression in the aio-cpu.c.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
  2021-02-24  8:54 [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup dingsenjie
@ 2021-03-01 23:34   ` Mark Brown
  2021-03-01 23:34   ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-01 23:34 UTC (permalink / raw)
  To: tiwai, dingsenjie, lgirdwood, perex; +Cc: linux-kernel, dingsenjie, alsa-devel

On Wed, 24 Feb 2021 16:54:07 +0800, dingsenjie@163.com wrote:
> Simplify the return expression in the aio-cpu.c.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
      commit: e3fdb6288dd08d965dea4bf00186e20f79153b2b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
@ 2021-03-01 23:34   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-01 23:34 UTC (permalink / raw)
  To: tiwai, dingsenjie, lgirdwood, perex; +Cc: dingsenjie, linux-kernel, alsa-devel

On Wed, 24 Feb 2021 16:54:07 +0800, dingsenjie@163.com wrote:
> Simplify the return expression in the aio-cpu.c.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup
      commit: e3fdb6288dd08d965dea4bf00186e20f79153b2b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-02  7:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24  8:54 [PATCH] sound: soc/uniphier: Simplify the return expression of uniphier_aio_startup dingsenjie
2021-03-01 14:21 ` Mark Brown
2021-03-01 14:21   ` Mark Brown
2021-03-01 23:34 ` Mark Brown
2021-03-01 23:34   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.