* [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description
@ 2021-03-02 4:27 Nidhi Gupta
2021-03-02 5:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: added test description (rev2) Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Nidhi Gupta @ 2021-03-02 4:27 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_cursor_legacy.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 6034ad04..746e1153 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -1365,6 +1365,9 @@ igt_main
igt_display_require(&display, display.drm_fd);
}
+ /*Test description for pipe-* and all-pipe-* tests*/
+ igt_describe("Test checks how many cursor updates we can fit between vblanks"
+ "on single pipe with different modes, priority and number of processes");
igt_subtest_group {
enum pipe n;
for_each_pipe_static(n) {
@@ -1412,6 +1415,10 @@ igt_main
igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
nonblocking_modeset_vs_cursor(&display, 16);
+ /*Test Description for 2x-* tests*/
+ igt_describe("This test executes flips on both CRTCs"
+ "while running cursor updates in parallel");
+
igt_subtest("2x-flip-vs-cursor-legacy")
two_screens_flip_vs_cursor(&display, 8, false, false);
@@ -1442,18 +1449,28 @@ igt_main
igt_subtest("2x-long-cursor-vs-flip-atomic")
two_screens_cursor_vs_flip(&display, 50, true);
+ /*Test description for cursor-crc tests*/
+ igt_describe("Test will first does a page flip and then cursor update");
igt_subtest("flip-vs-cursor-crc-legacy")
flip_vs_cursor_crc(&display, false);
igt_subtest("flip-vs-cursor-crc-atomic")
flip_vs_cursor_crc(&display, true);
+ /*Test description for busy-crc tests*/
+ igt_describe("this test perform a busy bo update followed by a cursor update");
igt_subtest("flip-vs-cursor-busy-crc-legacy")
flip_vs_cursor_busy_crc(&display, false);
igt_subtest("flip-vs-cursor-busy-crc-atomic")
flip_vs_cursor_busy_crc(&display, true);
+ igt_describe("Adds variety of tests:"
+ "varying-size: change the size of cursor b/w 64*64 to maxw x maxh"
+ "atomic-transition: alternates between a full screen sprite plane"
+ "and full screen primary plane"
+ "toggle: which toggles cursor visibility and make sure cursor moves"
+ "between updates");
for (i = 0; i <= flip_test_last; i++) {
const char *modes[flip_test_last+1] = {
"legacy",
@@ -1485,11 +1502,14 @@ igt_main
}
}
+ igt_describe("The essence of the basic test is that neither the cursor nor the"
+ "nonblocking flip stall the application of the next");
igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
igt_subtest_f("flip-vs-cursor-%s", modes[i])
flip_vs_cursor(&display, i, 150);
+
igt_subtest_f("cursor-vs-flip-%s", modes[i])
cursor_vs_flip(&display, i, 50);
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: added test description (rev2)
2021-03-02 4:27 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Nidhi Gupta
@ 2021-03-02 5:47 ` Patchwork
2021-03-02 5:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-03-02 5:47 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 6994 bytes --]
== Series Details ==
Series: tests/kms_cursor_legacy: added test description (rev2)
URL : https://patchwork.freedesktop.org/series/86430/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9819 -> IGTPW_5562
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5562 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5562, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5562:
### IGT changes ###
#### Possible regressions ####
* igt@gem_tiled_fence_blits@basic:
- fi-kbl-8809g: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-kbl-8809g/igt@gem_tiled_fence_blits@basic.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][3] ([i915#1982]) -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
Known issues
------------
Here are the changes found in IGTPW_5562 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@memory-alloc:
- fi-cml-u2: NOTRUN -> [SKIP][5] ([fdo#109315]) +17 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@amdgpu/amd_basic@memory-alloc.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][6] -> [DMESG-WARN][7] ([i915#402]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-cml-u2: NOTRUN -> [SKIP][8] ([i915#1208]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#2411] / [i915#402])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][11] ([i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@gem_huc_copy@huc-copy.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][12] -> [FAIL][13] ([i915#1372])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][14] ([i915#1004]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_chamelium@vga-edid-read:
- fi-cml-u2: NOTRUN -> [SKIP][15] ([fdo#109309]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@kms_chamelium@vga-edid-read.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][16] ([fdo#109285])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-cml-u2: NOTRUN -> [SKIP][17] ([fdo#109278] / [i915#533])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-cml-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
#### Possible fixes ####
* igt@gem_linear_blits@basic:
- fi-kbl-8809g: [TIMEOUT][18] ([i915#2502]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-kbl-8809g/igt@gem_linear_blits@basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-kbl-8809g/igt@gem_linear_blits@basic.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][20] ([i915#402]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9819/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1004]: https://gitlab.freedesktop.org/drm/intel/issues/1004
[i915#1021]: https://gitlab.freedesktop.org/drm/intel/issues/1021
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (42 -> 40)
------------------------------
Additional (2): fi-cml-u2 fi-ehl-1
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6016 -> IGTPW_5562
CI-20190529: 20190529
CI_DRM_9819: 52e5817b130a97930caddaf02dcbaca717028b77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5562: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
IGT_6016: 2107b0a53692fb329175bc16169c3699712187aa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
[-- Attachment #1.2: Type: text/html, Size: 7818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_cursor_legacy: added test description (rev2)
2021-03-02 4:27 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Nidhi Gupta
2021-03-02 5:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: added test description (rev2) Patchwork
@ 2021-03-02 5:59 ` Patchwork
2021-03-03 11:02 ` [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Modem, Bhanuprakash
2021-03-03 16:09 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_cursor_legacy: added test description (rev3) Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-03-02 5:59 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]
== Series Details ==
Series: tests/kms_cursor_legacy: added test description (rev2)
URL : https://patchwork.freedesktop.org/series/86430/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9819_full -> IGTPW_5562_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
Changes
-------
No changes found
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* IGT: IGT_6016 -> IGTPW_5562
CI_DRM_9819: 52e5817b130a97930caddaf02dcbaca717028b77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5562: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
IGT_6016: 2107b0a53692fb329175bc16169c3699712187aa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5562/index.html
[-- Attachment #1.2: Type: text/html, Size: 1561 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description
2021-03-02 4:27 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Nidhi Gupta
2021-03-02 5:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: added test description (rev2) Patchwork
2021-03-02 5:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
@ 2021-03-03 11:02 ` Modem, Bhanuprakash
2021-03-03 16:09 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_cursor_legacy: added test description (rev3) Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Modem, Bhanuprakash @ 2021-03-03 11:02 UTC (permalink / raw)
To: Gupta, Nidhi1, igt-dev
> -----Original Message-----
> From: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
> Sent: Tuesday, March 2, 2021 9:58 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>; Gupta, Nidhi1
> <nidhi1.gupta@intel.com>
> Subject: [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_cursor_legacy.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 6034ad04..746e1153 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -1365,6 +1365,9 @@ igt_main
> igt_display_require(&display, display.drm_fd);
> }
>
> + /*Test description for pipe-* and all-pipe-* tests*/
> + igt_describe("Test checks how many cursor updates we can fit between
> vblanks"
> + "on single pipe with different modes, priority and number
> of processes");
> igt_subtest_group {
> enum pipe n;
> for_each_pipe_static(n) {
> @@ -1412,6 +1415,10 @@ igt_main
> igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
> nonblocking_modeset_vs_cursor(&display, 16);
>
> + /*Test Description for 2x-* tests*/
> + igt_describe("This test executes flips on both CRTCs"
> + "while running cursor updates in parallel");
> +
> igt_subtest("2x-flip-vs-cursor-legacy")
> two_screens_flip_vs_cursor(&display, 8, false, false);
>
> @@ -1442,18 +1449,28 @@ igt_main
> igt_subtest("2x-long-cursor-vs-flip-atomic")
> two_screens_cursor_vs_flip(&display, 50, true);
>
> + /*Test description for cursor-crc tests*/
> + igt_describe("Test will first does a page flip and then cursor
> update");
> igt_subtest("flip-vs-cursor-crc-legacy")
> flip_vs_cursor_crc(&display, false);
>
> igt_subtest("flip-vs-cursor-crc-atomic")
> flip_vs_cursor_crc(&display, true);
>
> + /*Test description for busy-crc tests*/
> + igt_describe("this test perform a busy bo update followed by a
> cursor update");
> igt_subtest("flip-vs-cursor-busy-crc-legacy")
> flip_vs_cursor_busy_crc(&display, false);
>
> igt_subtest("flip-vs-cursor-busy-crc-atomic")
> flip_vs_cursor_busy_crc(&display, true);
>
> + igt_describe("Adds variety of tests:"
> + "varying-size: change the size of cursor b/w 64*64 to maxw
> x maxh"
> + "atomic-transition: alternates between a full screen
> sprite plane"
> + "and full screen primary plane"
> + "toggle: which toggles cursor visibility and make sure
> cursor moves"
> + "between updates");
> for (i = 0; i <= flip_test_last; i++) {
> const char *modes[flip_test_last+1] = {
> "legacy",
> @@ -1485,11 +1502,14 @@ igt_main
> }
> }
>
> + igt_describe("The essence of the basic test is that neither the
> cursor nor the"
In case of multiline description, please add a space at the end of each line
also, try to group the subtets, so that same description will apply for all
similar tests, how about below git diff on top of this change?
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 746e11532..eb226d90f 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -1366,7 +1366,7 @@ igt_main
}
/*Test description for pipe-* and all-pipe-* tests*/
- igt_describe("Test checks how many cursor updates we can fit between vblanks"
+ igt_describe("Test checks how many cursor updates we can fit between vblanks "
"on single pipe with different modes, priority and number of processes");
igt_subtest_group {
enum pipe n;
@@ -1394,83 +1394,87 @@ igt_main
}
}
- igt_subtest("all-pipes-single-bo")
- stress(&display, -1, 1, DRM_MODE_CURSOR_BO, 20);
- igt_subtest("all-pipes-single-move")
- stress(&display, -1, 1, DRM_MODE_CURSOR_MOVE, 20);
-
- igt_subtest("all-pipes-forked-bo")
- stress(&display, -1, ncpus, DRM_MODE_CURSOR_BO, 20);
- igt_subtest("all-pipes-forked-move")
- stress(&display, -1, ncpus, DRM_MODE_CURSOR_MOVE, 20);
-
- igt_subtest("all-pipes-torture-bo")
- stress(&display, -1, -ncpus, DRM_MODE_CURSOR_BO, 20);
- igt_subtest("all-pipes-torture-move")
- stress(&display, -1, -ncpus, DRM_MODE_CURSOR_MOVE, 20);
-
- igt_subtest("nonblocking-modeset-vs-cursor-atomic")
- nonblocking_modeset_vs_cursor(&display, 1);
-
- igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
- nonblocking_modeset_vs_cursor(&display, 16);
+ /*Test description for pipe-* and all-pipe-* tests*/
+ igt_describe("Test checks how many cursor updates we can fit between vblanks "
+ "on all pipes with different modes, priority and number of processes");
+ igt_subtest_group {
+ igt_subtest("all-pipes-single-bo")
+ stress(&display, -1, 1, DRM_MODE_CURSOR_BO, 20);
+ igt_subtest("all-pipes-single-move")
+ stress(&display, -1, 1, DRM_MODE_CURSOR_MOVE, 20);
+
+ igt_subtest("all-pipes-forked-bo")
+ stress(&display, -1, ncpus, DRM_MODE_CURSOR_BO, 20);
+ igt_subtest("all-pipes-forked-move")
+ stress(&display, -1, ncpus, DRM_MODE_CURSOR_MOVE, 20);
+
+ igt_subtest("all-pipes-torture-bo")
+ stress(&display, -1, -ncpus, DRM_MODE_CURSOR_BO, 20);
+ igt_subtest("all-pipes-torture-move")
+ stress(&display, -1, -ncpus, DRM_MODE_CURSOR_MOVE, 20);
+
+ igt_subtest("nonblocking-modeset-vs-cursor-atomic")
+ nonblocking_modeset_vs_cursor(&display, 1);
+
+ igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
+ nonblocking_modeset_vs_cursor(&display, 16);
+ }
/*Test Description for 2x-* tests*/
- igt_describe("This test executes flips on both CRTCs"
+ igt_describe("This test executes flips on both CRTCs "
"while running cursor updates in parallel");
+ igt_subtest_group {
+ igt_subtest("2x-flip-vs-cursor-legacy")
+ two_screens_flip_vs_cursor(&display, 8, false, false);
- igt_subtest("2x-flip-vs-cursor-legacy")
- two_screens_flip_vs_cursor(&display, 8, false, false);
-
- igt_subtest("2x-flip-vs-cursor-atomic")
- two_screens_flip_vs_cursor(&display, 8, false, true);
+ igt_subtest("2x-flip-vs-cursor-atomic")
+ two_screens_flip_vs_cursor(&display, 8, false, true);
- igt_subtest("2x-cursor-vs-flip-legacy")
- two_screens_cursor_vs_flip(&display, 8, false);
+ igt_subtest("2x-cursor-vs-flip-legacy")
+ two_screens_cursor_vs_flip(&display, 8, false);
- igt_subtest("2x-long-flip-vs-cursor-legacy")
- two_screens_flip_vs_cursor(&display, 150, false, false);
+ igt_subtest("2x-long-flip-vs-cursor-legacy")
+ two_screens_flip_vs_cursor(&display, 150, false, false);
- igt_subtest("2x-long-flip-vs-cursor-atomic")
- two_screens_flip_vs_cursor(&display, 150, false, true);
+ igt_subtest("2x-long-flip-vs-cursor-atomic")
+ two_screens_flip_vs_cursor(&display, 150, false, true);
- igt_subtest("2x-long-cursor-vs-flip-legacy")
- two_screens_cursor_vs_flip(&display, 50, false);
+ igt_subtest("2x-long-cursor-vs-flip-legacy")
+ two_screens_cursor_vs_flip(&display, 50, false);
- igt_subtest("2x-nonblocking-modeset-vs-cursor-atomic")
- two_screens_flip_vs_cursor(&display, 4, true, true);
+ igt_subtest("2x-nonblocking-modeset-vs-cursor-atomic")
+ two_screens_flip_vs_cursor(&display, 4, true, true);
- igt_subtest("2x-cursor-vs-flip-atomic")
- two_screens_cursor_vs_flip(&display, 8, true);
+ igt_subtest("2x-cursor-vs-flip-atomic")
+ two_screens_cursor_vs_flip(&display, 8, true);
- igt_subtest("2x-long-nonblocking-modeset-vs-cursor-atomic")
- two_screens_flip_vs_cursor(&display, 15, true, true);
+ igt_subtest("2x-long-nonblocking-modeset-vs-cursor-atomic")
+ two_screens_flip_vs_cursor(&display, 15, true, true);
- igt_subtest("2x-long-cursor-vs-flip-atomic")
- two_screens_cursor_vs_flip(&display, 50, true);
+ igt_subtest("2x-long-cursor-vs-flip-atomic")
+ two_screens_cursor_vs_flip(&display, 50, true);
+ }
/*Test description for cursor-crc tests*/
igt_describe("Test will first does a page flip and then cursor update");
- igt_subtest("flip-vs-cursor-crc-legacy")
- flip_vs_cursor_crc(&display, false);
+ igt_subtest_group {
+ igt_subtest("flip-vs-cursor-crc-legacy")
+ flip_vs_cursor_crc(&display, false);
- igt_subtest("flip-vs-cursor-crc-atomic")
- flip_vs_cursor_crc(&display, true);
+ igt_subtest("flip-vs-cursor-crc-atomic")
+ flip_vs_cursor_crc(&display, true);
+ }
/*Test description for busy-crc tests*/
igt_describe("this test perform a busy bo update followed by a cursor update");
- igt_subtest("flip-vs-cursor-busy-crc-legacy")
- flip_vs_cursor_busy_crc(&display, false);
-
- igt_subtest("flip-vs-cursor-busy-crc-atomic")
- flip_vs_cursor_busy_crc(&display, true);
-
- igt_describe("Adds variety of tests:"
- "varying-size: change the size of cursor b/w 64*64 to maxw x maxh"
- "atomic-transition: alternates between a full screen sprite plane"
- "and full screen primary plane"
- "toggle: which toggles cursor visibility and make sure cursor moves"
- "between updates");
+ igt_subtest_group {
+ igt_subtest("flip-vs-cursor-busy-crc-legacy")
+ flip_vs_cursor_busy_crc(&display, false);
+
+ igt_subtest("flip-vs-cursor-busy-crc-atomic")
+ flip_vs_cursor_busy_crc(&display, true);
+ }
+
for (i = 0; i <= flip_test_last; i++) {
const char *modes[flip_test_last+1] = {
"legacy",
@@ -1491,39 +1495,44 @@ igt_main
default: break;
}
- igt_subtest_f("%sflip-before-cursor-%s", prefix, modes[i])
- basic_flip_cursor(&display, i, FLIP_BEFORE_CURSOR, 0);
-
- if (!cursor_slowpath(i)) {
- igt_subtest_f("%sbusy-flip-before-cursor-%s", prefix, modes[i]) {
- igt_require_gem(display.drm_fd);
- basic_flip_cursor(&display, i, FLIP_BEFORE_CURSOR,
- BASIC_BUSY);
+ igt_describe("varying-size: change the size of cursor b/w 64*64 to maxw*maxh. "
+ "atomic-transition: alternates between a sprite and primary planes. "
+ "toggle: toggle cursor visibility and make sure cursor moves between updates.");
+ igt_subtest_group {
+ igt_subtest_f("%sflip-before-cursor-%s", prefix, modes[i])
+ basic_flip_cursor(&display, i, FLIP_BEFORE_CURSOR, 0);
+
+ if (!cursor_slowpath(i)) {
+ igt_subtest_f("%sbusy-flip-before-cursor-%s", prefix, modes[i]) {
+ igt_require_gem(display.drm_fd);
+ basic_flip_cursor(&display, i,
+ FLIP_BEFORE_CURSOR,
+ BASIC_BUSY);
+
+ }
}
- }
- igt_describe("The essence of the basic test is that neither the cursor nor the"
- "nonblocking flip stall the application of the next");
- igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
- basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
+ igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
+ basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
- igt_subtest_f("flip-vs-cursor-%s", modes[i])
- flip_vs_cursor(&display, i, 150);
+ igt_subtest_f("flip-vs-cursor-%s", modes[i])
+ flip_vs_cursor(&display, i, 150);
- igt_subtest_f("cursor-vs-flip-%s", modes[i])
- cursor_vs_flip(&display, i, 50);
+ igt_subtest_f("cursor-vs-flip-%s", modes[i])
+ cursor_vs_flip(&display, i, 50);
- igt_subtest_f("cursorA-vs-flipA-%s", modes[i])
- flip(&display, 0, 0, 10, i);
+ igt_subtest_f("cursorA-vs-flipA-%s", modes[i])
+ flip(&display, 0, 0, 10, i);
- igt_subtest_f("cursorA-vs-flipB-%s", modes[i])
- flip(&display, 0, 1, 10, i);
+ igt_subtest_f("cursorA-vs-flipB-%s", modes[i])
+ flip(&display, 0, 1, 10, i);
- igt_subtest_f("cursorB-vs-flipA-%s", modes[i])
- flip(&display, 1, 0, 10, i);
+ igt_subtest_f("cursorB-vs-flipA-%s", modes[i])
+ flip(&display, 1, 0, 10, i);
- igt_subtest_f("cursorB-vs-flipB-%s", modes[i])
- flip(&display, 1, 1, 10, i);
+ igt_subtest_f("cursorB-vs-flipB-%s", modes[i])
+ flip(&display, 1, 1, 10, i);
+ }
}
igt_fixture {
> + "nonblocking flip stall the application of the
> next");
> igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
> basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
>
> igt_subtest_f("flip-vs-cursor-%s", modes[i])
> flip_vs_cursor(&display, i, 150);
> +
> igt_subtest_f("cursor-vs-flip-%s", modes[i])
> cursor_vs_flip(&display, i, 50);
>
> --
> 2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_cursor_legacy: added test description (rev3)
2021-03-02 4:27 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Nidhi Gupta
` (2 preceding siblings ...)
2021-03-03 11:02 ` [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Modem, Bhanuprakash
@ 2021-03-03 16:09 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-03-03 16:09 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev
== Series Details ==
Series: tests/kms_cursor_legacy: added test description (rev3)
URL : https://patchwork.freedesktop.org/series/86430/
State : failure
== Summary ==
Applying: tests/kms_cursor_legacy: added test description
Using index info to reconstruct a base tree...
M tests/kms_cursor_legacy.c
Patch failed at 0001 tests/kms_cursor_legacy: added test description
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-03 16:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 4:27 [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Nidhi Gupta
2021-03-02 5:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cursor_legacy: added test description (rev2) Patchwork
2021-03-02 5:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2021-03-03 11:02 ` [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_legacy: added test description Modem, Bhanuprakash
2021-03-03 16:09 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_cursor_legacy: added test description (rev3) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.