From: Mark Brown <broonie@kernel.org>
To: tangbin <tangbin@cmss.chinamobile.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe()
Date: Tue, 2 Mar 2021 13:20:43 +0000 [thread overview]
Message-ID: <20210302132043.GF4522@sirena.org.uk> (raw)
In-Reply-To: <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
On Tue, Mar 02, 2021 at 08:55:25PM +0800, tangbin wrote:
> Yes, I would have written it in your ways, but considered the variable
> "ret", I gave up, and just deleted dev_err().
If it's not used any more it can just be removed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: tangbin <tangbin@cmss.chinamobile.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe()
Date: Tue, 2 Mar 2021 13:20:43 +0000 [thread overview]
Message-ID: <20210302132043.GF4522@sirena.org.uk> (raw)
In-Reply-To: <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
On Tue, Mar 02, 2021 at 08:55:25PM +0800, tangbin wrote:
> Yes, I would have written it in your ways, but considered the variable
> "ret", I gave up, and just deleted dev_err().
If it's not used any more it can just be removed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-02 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 12:11 [PATCH] ASoC: codec: Omit superfluous error message in jz4760_codec_probe() Tang Bin
2021-03-02 12:23 ` Paul Cercueil
2021-03-02 12:23 ` Paul Cercueil
2021-03-02 12:55 ` [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe() tangbin
2021-03-02 12:55 ` tangbin
2021-03-02 13:20 ` Mark Brown [this message]
2021-03-02 13:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302132043.GF4522@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.