* [PATCH] kbuild: show warning for 'make headers_check'
@ 2021-03-02 14:26 Masahiro Yamada
2021-03-09 15:29 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-03-02 14:26 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, Masahiro Yamada, Michal Marek
Since commit 7ecaf069da52 ("kbuild: move headers_check rule to
usr/include/Makefile"), the headers_check target is no-op.
This stub target is remaining here in case some scripts still invoke
'make headers_check'. In order to prompt people to remove stale code,
show a noisy warning message if used. The stub will be really removed
after the Linux 5.15 release.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f9b54da2fca0..a3336d9b4a22 100644
--- a/Makefile
+++ b/Makefile
@@ -1339,7 +1339,11 @@ headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
# Deprecated. It is no-op now.
PHONY += headers_check
headers_check:
- @:
+ @echo >&2 "=================== WARNING ==================="
+ @echo >&2 "Since Linux 5.5, 'make headers_check' is no-op,"
+ @echo >&2 "and will be removed after Linux 5.15 release."
+ @echo >&2 "Please remove headers_check from your scripts."
+ @echo >&2 "==============================================="
ifdef CONFIG_HEADERS_INSTALL
prepare: headers
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: show warning for 'make headers_check'
2021-03-02 14:26 [PATCH] kbuild: show warning for 'make headers_check' Masahiro Yamada
@ 2021-03-09 15:29 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2021-03-09 15:29 UTC (permalink / raw)
To: Linux Kbuild mailing list; +Cc: Linux Kernel Mailing List, Michal Marek
On Tue, Mar 2, 2021 at 11:26 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Since commit 7ecaf069da52 ("kbuild: move headers_check rule to
> usr/include/Makefile"), the headers_check target is no-op.
>
> This stub target is remaining here in case some scripts still invoke
> 'make headers_check'. In order to prompt people to remove stale code,
> show a noisy warning message if used. The stub will be really removed
> after the Linux 5.15 release.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Applied to linux-kbuild.
>
> Makefile | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f9b54da2fca0..a3336d9b4a22 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1339,7 +1339,11 @@ headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders archscripts
> # Deprecated. It is no-op now.
> PHONY += headers_check
> headers_check:
> - @:
> + @echo >&2 "=================== WARNING ==================="
> + @echo >&2 "Since Linux 5.5, 'make headers_check' is no-op,"
> + @echo >&2 "and will be removed after Linux 5.15 release."
> + @echo >&2 "Please remove headers_check from your scripts."
> + @echo >&2 "==============================================="
>
> ifdef CONFIG_HEADERS_INSTALL
> prepare: headers
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-09 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 14:26 [PATCH] kbuild: show warning for 'make headers_check' Masahiro Yamada
2021-03-09 15:29 ` Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.