All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Murilo Opsfelder Araujo" <muriloo@linux.ibm.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Liam Merwick" <liam.merwick@oracle.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Igor Kotrasinski" <i.kotrasinsk@partner.samsung.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Thomas Huth" <thuth@redhat.com>,
	kvm@vger.kernel.org, qemu-s390x@nongnu.org
Subject: Re: [PATCH v1 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()
Date: Tue, 2 Mar 2021 15:54:32 -0500	[thread overview]
Message-ID: <20210302205432.GP397383@xz-x1> (raw)
In-Reply-To: <91613148-9ade-c192-4b73-0cb5a54ada98@redhat.com>

On Tue, Mar 02, 2021 at 08:02:34PM +0100, David Hildenbrand wrote:
> > > @@ -174,12 +175,18 @@ void *qemu_ram_mmap(int fd,
> > >                       size_t align,
> > >                       bool readonly,
> > >                       bool shared,
> > > -                    bool is_pmem)
> > > +                    bool is_pmem,
> > > +                    bool noreserve)
> > 
> > Maybe at some point we should use flags too here to cover all bools.
> > 
> 
> Right. I guess the main point was to not reuse RAM_XXX.
> 
> Should I introduce RAM_MMAP_XXX ?

Maybe we can directly use MAP_*?  Since I see qemu_ram_mmap() should only exist
with CONFIG_POSIX.  However indeed I see no sign to extend more bools in the
near future either, so maybe also fine to keep it as is, as 4 bools still looks
okay - your call. :)

-- 
Peter Xu


WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-s390x@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Murilo Opsfelder Araujo" <muriloo@linux.ibm.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	qemu-devel@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Igor Kotrasinski" <i.kotrasinsk@partner.samsung.com>
Subject: Re: [PATCH v1 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()
Date: Tue, 2 Mar 2021 15:54:32 -0500	[thread overview]
Message-ID: <20210302205432.GP397383@xz-x1> (raw)
In-Reply-To: <91613148-9ade-c192-4b73-0cb5a54ada98@redhat.com>

On Tue, Mar 02, 2021 at 08:02:34PM +0100, David Hildenbrand wrote:
> > > @@ -174,12 +175,18 @@ void *qemu_ram_mmap(int fd,
> > >                       size_t align,
> > >                       bool readonly,
> > >                       bool shared,
> > > -                    bool is_pmem)
> > > +                    bool is_pmem,
> > > +                    bool noreserve)
> > 
> > Maybe at some point we should use flags too here to cover all bools.
> > 
> 
> Right. I guess the main point was to not reuse RAM_XXX.
> 
> Should I introduce RAM_MMAP_XXX ?

Maybe we can directly use MAP_*?  Since I see qemu_ram_mmap() should only exist
with CONFIG_POSIX.  However indeed I see no sign to extend more bools in the
near future either, so maybe also fine to keep it as is, as 4 bools still looks
okay - your call. :)

-- 
Peter Xu



  reply	other threads:[~2021-03-03  7:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 13:49 [PATCH v1 0/9] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 1/9] softmmu/physmem: drop "shared" parameter from ram_block_add() David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 2/9] util/mmap-alloc: factor out calculation of the pagesize for the guard page David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 3/9] util/mmap-alloc: factor out reserving of a memory region to mmap_reserve() David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 4/9] util/mmap-alloc: factor out activating of memory to mmap_activate() David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 5/9] softmmu/memory: pass ram_flags into qemu_ram_alloc_from_fd() David Hildenbrand
2021-03-02 17:17   ` Peter Xu
2021-02-09 13:49 ` [PATCH v1 6/9] softmmu/memory: pass ram_flags into memory_region_init_ram_shared_nomigrate() David Hildenbrand
2021-03-02 17:17   ` Peter Xu
2021-02-09 13:49 ` [PATCH v1 7/9] memory: introduce RAM_NORESERVE and wire it up in qemu_ram_mmap() David Hildenbrand
2021-02-09 13:49   ` David Hildenbrand
2021-03-02 17:32   ` Peter Xu
2021-03-02 17:32     ` Peter Xu
2021-03-02 19:02     ` David Hildenbrand
2021-03-02 19:02       ` David Hildenbrand
2021-03-02 20:54       ` Peter Xu [this message]
2021-03-02 20:54         ` Peter Xu
2021-03-02 20:58         ` David Hildenbrand
2021-03-02 20:58           ` David Hildenbrand
2021-03-03 11:35       ` Cornelia Huck
2021-03-03 11:35         ` Cornelia Huck
2021-03-03 11:37         ` David Hildenbrand
2021-03-03 11:37           ` David Hildenbrand
2021-03-03 12:12           ` Thomas Huth
2021-03-03 12:12             ` Thomas Huth
2021-03-03 12:24             ` David Hildenbrand
2021-03-03 12:24               ` David Hildenbrand
2021-03-03 11:39         ` Thomas Huth
2021-03-03 11:39           ` Thomas Huth
2021-03-03 11:41           ` David Hildenbrand
2021-03-03 11:41             ` David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 8/9] util/mmap-alloc: support RAM_NORESERVE via MAP_NORESERVE David Hildenbrand
2021-03-02 17:51   ` Peter Xu
2021-03-02 19:01     ` David Hildenbrand
2021-03-02 21:44       ` Peter Xu
2021-03-03 10:14         ` David Hildenbrand
2021-03-03 17:05           ` Peter Xu
2021-03-04 16:15             ` David Hildenbrand
2021-02-09 13:49 ` [PATCH v1 9/9] hostmem: wire up RAM_NORESERVE via "reserve" property David Hildenbrand
2021-03-02 17:55   ` Peter Xu
2021-03-02 13:12 ` [PATCH v1 0/9] RAM_NORESERVE, MAP_NORESERVE and hostmem " David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302205432.GP397383@xz-x1 \
    --to=peterx@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=i.kotrasinsk@partner.samsung.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=liam.merwick@oracle.com \
    --cc=mst@redhat.com \
    --cc=muriloo@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.