* [PATCH] iwlwifi: fix ARCH=i386 compilation warnings
@ 2021-03-02 1:16 Pierre-Louis Bossart
2021-03-02 5:58 ` Kalle Valo
2021-03-03 15:58 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2021-03-02 1:16 UTC (permalink / raw)
To: linux-wireless, Luca Coelho
Cc: Pierre-Louis Bossart, Kalle Valo, David S. Miller,
Jakub Kicinski, Johannes Berg, open list:NETWORKING DRIVERS,
open list
An unsigned long variable should rely on '%lu' format strings, not '%zd'
Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
warnings found with v5.12-rc1 and next-20210301
drivers/net/wireless/intel/iwlwifi/fw/pnvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
index fd070ca5e517..40f2109a097f 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
@@ -271,12 +271,12 @@ static int iwl_pnvm_get_from_efi(struct iwl_trans *trans,
err = efivar_entry_get(pnvm_efivar, NULL, &package_size, package);
if (err) {
IWL_DEBUG_FW(trans,
- "PNVM UEFI variable not found %d (len %zd)\n",
+ "PNVM UEFI variable not found %d (len %lu)\n",
err, package_size);
goto out;
}
- IWL_DEBUG_FW(trans, "Read PNVM fro UEFI with size %zd\n", package_size);
+ IWL_DEBUG_FW(trans, "Read PNVM fro UEFI with size %lu\n", package_size);
*data = kmemdup(package->data, *len, GFP_KERNEL);
if (!*data)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings
2021-03-02 1:16 [PATCH] iwlwifi: fix ARCH=i386 compilation warnings Pierre-Louis Bossart
@ 2021-03-02 5:58 ` Kalle Valo
2021-03-02 7:24 ` Coelho, Luciano
2021-03-03 15:58 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2021-03-02 5:58 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: linux-wireless, Luca Coelho, David S. Miller, Jakub Kicinski,
Johannes Berg, open list:NETWORKING DRIVERS, open list
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes:
> An unsigned long variable should rely on '%lu' format strings, not '%zd'
>
> Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> warnings found with v5.12-rc1 and next-20210301
Luca, can I take this to wireless-drivers?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings
2021-03-02 5:58 ` Kalle Valo
@ 2021-03-02 7:24 ` Coelho, Luciano
2021-03-02 8:25 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Coelho, Luciano @ 2021-03-02 7:24 UTC (permalink / raw)
To: pierre-louis.bossart, kvalo
Cc: linux-wireless, linux-kernel, Berg, Johannes, davem, kuba, netdev
On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote:
> Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes:
>
> > An unsigned long variable should rely on '%lu' format strings, not '%zd'
> >
> > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > ---
> > warnings found with v5.12-rc1 and next-20210301
>
> Luca, can I take this to wireless-drivers?
Yes, please.
Acked-by: Luca Coelho <luciano.coelho@intel.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings
2021-03-02 7:24 ` Coelho, Luciano
@ 2021-03-02 8:25 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-03-02 8:25 UTC (permalink / raw)
To: Coelho, Luciano
Cc: pierre-louis.bossart, linux-wireless, linux-kernel, Berg,
Johannes, davem, kuba, netdev
"Coelho, Luciano" <luciano.coelho@intel.com> writes:
> On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote:
>> Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> writes:
>>
>> > An unsigned long variable should rely on '%lu' format strings, not '%zd'
>> >
>> > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
>> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> > ---
>> > warnings found with v5.12-rc1 and next-20210301
>>
>> Luca, can I take this to wireless-drivers?
>
> Yes, please.
>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
Thansk. I don't see this in patchwork yet (I guess vger is slow again)
so I cannot assign it to me at the moment, will do it later.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings
2021-03-02 1:16 [PATCH] iwlwifi: fix ARCH=i386 compilation warnings Pierre-Louis Bossart
2021-03-02 5:58 ` Kalle Valo
@ 2021-03-03 15:58 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2021-03-03 15:58 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: linux-wireless, Luca Coelho, Pierre-Louis Bossart,
David S. Miller, Jakub Kicinski, Johannes Berg,
open list:NETWORKING DRIVERS, open list
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote:
> An unsigned long variable should rely on '%lu' format strings, not '%zd'
>
> Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI")
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers.git, thanks.
436b265671d6 iwlwifi: fix ARCH=i386 compilation warnings
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210302011640.1276636-1-pierre-louis.bossart@linux.intel.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-03 21:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 1:16 [PATCH] iwlwifi: fix ARCH=i386 compilation warnings Pierre-Louis Bossart
2021-03-02 5:58 ` Kalle Valo
2021-03-02 7:24 ` Coelho, Luciano
2021-03-02 8:25 ` Kalle Valo
2021-03-03 15:58 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.