All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-rt-devel:linux-5.11.y-rt-rebase 29/208] kernel/printk/printk.c:867:35: error: incompatible type for argument 2 of 'prb_read_valid_info'
@ 2021-03-03 20:40 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-03-03 20:40 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5098 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.11.y-rt-rebase
head:   a4517bf5f3c3585f79f24d02ee15c4d6a9f64841
commit: e42cc1876596147e87a64689191d356c95c39121 [29/208] printk: use atomic64_t for devkmsg_user.seq
config: i386-randconfig-a006-20210302 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=e42cc1876596147e87a64689191d356c95c39121
        git remote add linux-rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
        git fetch --no-tags linux-rt-devel linux-5.11.y-rt-rebase
        git checkout e42cc1876596147e87a64689191d356c95c39121
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-rt-devel/linux-5.11.y-rt-rebase HEAD a4517bf5f3c3585f79f24d02ee15c4d6a9f64841 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   kernel/printk/printk.c: In function 'devkmsg_poll':
>> kernel/printk/printk.c:867:35: error: incompatible type for argument 2 of 'prb_read_valid_info'
     867 |  if (prb_read_valid_info(prb, user->seq, &info, NULL)) {
         |                               ~~~~^~~~~
         |                                   |
         |                                   atomic64_t {aka struct <anonymous>}
   In file included from kernel/printk/printk.c:58:
   kernel/printk/printk_ringbuffer.h:376:60: note: expected 'u64' {aka 'long long unsigned int'} but argument is of type 'atomic64_t' {aka 'struct <anonymous>'}
     376 | bool prb_read_valid_info(struct printk_ringbuffer *rb, u64 seq,
         |                                                        ~~~~^~~
   kernel/printk/printk.c: In function 'printk_sprint':
   kernel/printk/printk.c:2018:2: warning: function 'printk_sprint' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    2018 |  text_len = vscnprintf(text, size, fmt, args);
         |  ^~~~~~~~


vim +/prb_read_valid_info +867 kernel/printk/printk.c

e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  854  
9dd957485d7d89 kernel/printk/printk.c Al Viro            2017-07-03  855  static __poll_t devkmsg_poll(struct file *file, poll_table *wait)
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  856  {
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  857  	struct devkmsg_user *user = file->private_data;
1fd81489746702 kernel/printk/printk.c John Ogness        2021-02-11  858  	struct printk_info info;
9dd957485d7d89 kernel/printk/printk.c Al Viro            2017-07-03  859  	__poll_t ret = 0;
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  860  
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  861  	if (!user)
a9a08845e9acbd kernel/printk/printk.c Linus Torvalds     2018-02-11  862  		return EPOLLERR|EPOLLNVAL;
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  863  
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  864  	poll_wait(file, &log_wait, wait);
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  865  
de6fcbdb68b29b kernel/printk/printk.c Sergey Senozhatsky 2016-12-27  866  	logbuf_lock_irq();
1fd81489746702 kernel/printk/printk.c John Ogness        2021-02-11 @867  	if (prb_read_valid_info(prb, user->seq, &info, NULL)) {
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  868  		/* return error when data has vanished underneath us */
e42cc187659614 kernel/printk/printk.c John Ogness        2020-12-10  869  		if (info.seq != atomic64_read(&user->seq))
a9a08845e9acbd kernel/printk/printk.c Linus Torvalds     2018-02-11  870  			ret = EPOLLIN|EPOLLRDNORM|EPOLLERR|EPOLLPRI;
0a285317daf785 kernel/printk.c        Nicolas Kaiser     2013-04-29  871  		else
a9a08845e9acbd kernel/printk/printk.c Linus Torvalds     2018-02-11  872  			ret = EPOLLIN|EPOLLRDNORM;
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  873  	}
de6fcbdb68b29b kernel/printk/printk.c Sergey Senozhatsky 2016-12-27  874  	logbuf_unlock_irq();
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  875  
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  876  	return ret;
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  877  }
e11fea92e13fb9 kernel/printk.c        Kay Sievers        2012-05-03  878  

:::::: The code at line 867 was first introduced by commit
:::::: 1fd81489746702fd711315bba9d7bd3c9971840b printk: avoid prb_first_valid_seq() where possible

:::::: TO: John Ogness <john.ogness@linutronix.de>
:::::: CC: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45029 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-03 20:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 20:40 [linux-rt-devel:linux-5.11.y-rt-rebase 29/208] kernel/printk/printk.c:867:35: error: incompatible type for argument 2 of 'prb_read_valid_info' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.